Feedback-ID: i0c21471d:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-144-ge5821d614e-fm-20240125.002-ge5821d61
MIME-Version: 1.0
Message-Id: <9b2256ea-484d-404d-a3cf-b8e86674951e@app.fastmail.com>
In-Reply-To: 
 <CAFcNs+pPtw+y7Be00BK0MBpHhLk2s66tLM286g=k5rew8kUxjg@mail.gmail.com>
References: <5ac50071-f2ed-4ace-a8fd-b892cffd33eb@www.fastmail.com>
 <4710d895-689a-4ae6-b8e3-344286dbf970@app.fastmail.com>
 <da078f11-d2de-420e-9611-f3b7d4dadd9a@eisentraut.org>
 <ZUrEclC-uZV-rGd2@paquier.xyz>
 <96e3b739-d63d-4d35-90a3-7869465b7167@eisentraut.org>
 <ZU1nR5KMZtSTEQDf@paquier.xyz>
 <e02a2c17-22e5-4ba6-b788-de696ab74f1e@app.fastmail.com>
 <CALDaNm098Jkbh+ye6zMj9Ro9j1bBe6FfPV80BFbs1=pUuTJ07g@mail.gmail.com>
 <2736443c-58e3-42df-8cc4-8c66106e3da5@app.fastmail.com>
 <CAA4eK1KtGC-v_CYd8yaCwisrQvoZN=+As90p9hBM29DAxA+Pmg@mail.gmail.com>
 <CANhcyEUdYCR9oSt4HsZRqYZZVXsb4x-HoPGqDSxSeA2SYz-YGg@mail.gmail.com>
 <CAA4eK1KMQNMhSPmsRdrCQpuc=Tsc08h6=XkLNZ5F35Q2REom6g@mail.gmail.com>
 <CANhcyEXjOcnOJKdOfK8Z1+bbymuZzwSjrppbt4FKHbrDD_t7Mg@mail.gmail.com>
 <CANhcyEUCt-g4JLQU3Q3ofFk_Vt-Tqh3ZdXoLcpT8fjz9LY_-ww@mail.gmail.com>
 <bcd3db13-f56e-47e3-8fa7-7f0c6243c8a6@app.fastmail.com>
 <CAA4eK1JRgnhv_ySzuFjN7UaX9qxz5Hqcwew7Fk=+AbJbu0Kd9w@mail.gmail.com>
 <TY3PR01MB98895BA6C1D72CB8582CACC4F5682@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <aabc91d2-505b-4412-af08-7dae2df1d437@app.fastmail.com>
 <TY3PR01MB9889C362FF76102C88FA1C29F56F2@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <TY3PR01MB9889C5D55206DDD978627D07F5752@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <CANhcyEXhpfWgc0-FdHmUG6WGD=2cxYqBePr1yxJ8VSZ0gV3XKA@mail.gmail.com>
 <c402b130-0226-4a2c-bb92-9e83bd6af006@app.fastmail.com>
 <b315c7da-7ab1-4014-a2a9-8ab6ae26017c@app.fastmail.com>
 <TY3PR01MB98895A551923953B3DA3C7C8F5792@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <d0b1534e-9f63-4966-8fb7-deedb0a626d0@app.fastmail.com>
 <1cd45c1e-8ed1-42fc-9357-f1c43e0d6ac8@app.fastmail.com>
 <OS3PR01MB98828B15DD9502C91E0C50D7F57D2@OS3PR01MB9882.jpnprd01.prod.outlook.com>
 <TY3PR01MB9889320DDAF153FC8A532630F57C2@TY3PR01MB9889.jpnprd01.prod.outlook.com>
 <CAFcNs+pPtw+y7Be00BK0MBpHhLk2s66tLM286g=k5rew8kUxjg@mail.gmail.com>
Date: Wed, 31 Jan 2024 11:34:57 -0300
From: "Euler Taveira" <euler@eulerto.com>
To: =?UTF-8?Q?Fabr=C3=ADzio_de_Royes_Mello?= <fabriziomello@gmail.com>,
 "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>
Cc: 
 "pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
 "vignesh C" <vignesh21@gmail.com>, "Michael Paquier" <michael@paquier.xyz>,
 "Peter Eisentraut" <peter@eisentraut.org>,
 "Andres Freund" <andres@anarazel.de>,
 "Ashutosh Bapat" <ashutosh.bapat.oss@gmail.com>,
 "Amit Kapila" <amit.kapila16@gmail.com>,
 "Shlok Kyal" <shlok.kyal.oss@gmail.com>
Subject: Re: speed up a logical replica setup
Content-Type: multipart/alternative;
 boundary=4064db19368649cb84e91211a818cf2a
Archived-At: 
 <https://www.postgresql.org/message-id/9b2256ea-484d-404d-a3cf-b8e86674951e%40app.fastmail.com>
Precedence: bulk

--4064db19368649cb84e91211a818cf2a
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Wed, Jan 31, 2024, at 11:25 AM, Fabr=C3=ADzio de Royes Mello wrote:
> Jumping into this a bit late here... I'm trying a simple pg_createsubs=
criber but getting an error:

Try v11. It seems v12-0002 is not correct.

> Seems we need to escape connection params similar we do in dblink [1]

I think it is a consequence of v12-0003. I didn't review v12 yet but alt=
hough I
have added a comment saying it might be possible to use primary_conninfo=
, I'm
not 100% convinced that's the right direction.

        /*
         * TODO use primary_conninfo (if available) from subscriber and
         * extract publisher connection string. Assume that there are
         * identical entries for physical and logical replication. If th=
ere is
         * not, we would fail anyway.
         */


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--4064db19368649cb84e91211a818cf2a
Content-Type: text/html;charset=utf-8
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE html><html><head><title></title><style type=3D"text/css">p.Mso=
Normal,p.MsoNoSpacing{margin:0}</style></head><body><div>On Wed, Jan 31,=
 2024, at 11:25 AM, Fabr=C3=ADzio de Royes Mello wrote:<br></div><blockq=
uote type=3D"cite" id=3D"qt" style=3D""><div dir=3D"ltr"><div><span clas=
s=3D"qt-gmail_signature_prefix">Jumping into this a bit late here... I'm=
 trying a simple pg_createsubscriber but getting an error:</span><br></d=
iv></div></blockquote><div><br></div><div>Try v11. It seems v12-0002 is =
not correct.<br></div><div><br></div><blockquote type=3D"cite" id=3D"qt"=
 style=3D""><div dir=3D"ltr"><div><span class=3D"qt-gmail_signature_pref=
ix">Seems we need to escape connection params similar we do in dblink [1=
]</span><br></div></div></blockquote><div><br></div><div>I think it is a=
 consequence of v12-0003. I didn't review v12 yet but although I<br></di=
v><div>have added a comment saying it might be possible to use primary_c=
onninfo, I'm<br></div><div>not 100% convinced that's the right direction=
.<br></div><div><br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp=
; /*<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * TO=
DO use primary_conninfo (if available) from subscriber and<br></div><div=
>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * extract publisher co=
nnection string. Assume that there are<br></div><div>&nbsp;&nbsp;&nbsp;&=
nbsp;&nbsp;&nbsp;&nbsp;&nbsp; * identical entries for physical and logic=
al replication. If there is<br></div><div>&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;=
&nbsp;&nbsp;&nbsp; * not, we would fail anyway.<br></div><div>&nbsp;&nbs=
p;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp; */<br></div><div><br></div><div><=
br></div><div id=3D"sig112409080"><div class=3D"signature">--<br></div><=
div class=3D"signature">Euler Taveira<br></div><div class=3D"signature">=
EDB&nbsp;&nbsp; <a href=3D"https://www.enterprisedb.com/">https://www.en=
terprisedb.com/</a><br></div></div><div><br></div></body></html>
--4064db19368649cb84e91211a818cf2a--