Date: Tue, 18 Feb 2025 20:11:22 +0800
From: Zhang Mingli <zmlpostgres@gmail.com>
To: Richard Guo <guofenglinux@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Message-ID: <9b43912c-fbcd-430b-b4ea-b15df3401270@Spark>
In-Reply-To: <CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com>
References: <56f5ab23-e92b-4380-929d-d2aa68ccc2ca@Spark>
 <198a8d1e-0792-4e7f-828e-902aa342f36e@Spark>
 <CAMbWs4-u0a9XkP7xNiEuQJLBjyOb7OQf5OScyhPC0TXbDc+JXw@mail.gmail.com>
Subject: Re: Fix outdated code comments in nodeAgg.c
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="67b478ef_67fb67a2_7ffc"
Archived-At: <https://www.postgresql.org/message-id/9b43912c-fbcd-430b-b4ea-b15df3401270%40Spark>
Precedence: bulk

--67b478ef_67fb67a2_7ffc
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On =46eb 10, 2025 at 16:45 +0800, Richard Guo <guofenglinux=40gmail.com>,=
 wrote:
> On Sun, =46eb 9, 2025 at 11:15=E2=80=AFPM Zhang Mingli <zmlpostgres=40g=
mail.com> wrote:
> > By reading the codes in nodeAgg.c, I found that some comments are out=
dated.
> > The comments referred to the function lookup=5Fhash=5Fentry(), which =
has been removed in commit b563594.
> > I've adjusted the comments to refer to the correct function to make i=
t clear.
>
> LGTM. This seems to be an oversight from 200f6100a, in which the
> function lookup=5Fhash=5Fentry() was removed.
>
> Thanks
> Richard
Hi,

Thanks for review, added it to commitfest=C2=A0https://commitfest.postgre=
sql.org/patch/5580/


--
Zhang Mingli
HashData

--67b478ef_67fb67a2_7ffc
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

<html xmlns=3D=22http://www.w3.org/1999/xhtml=22>
<head>
<title></title>
</head>
<body>
<div name=3D=22messageReplySection=22>
<div dir=3D=22auto=22>On =46eb 10, 2025 at 16:45 +0800, Richard Guo &lt;g=
uofenglinux=40gmail.com&gt;, wrote:</div>
<blockquote style=3D=22border-left-color: rgb(26, 188, 156); margin: 5px;=
 padding-left: 10px; border-left-width: thin; border-left-style: solid;=22=
>On Sun, =46eb 9, 2025 at 11:15=E2=80=AFPM Zhang Mingli &lt;zmlpostgres=40=
gmail.com&gt; wrote:<br />
<blockquote style=3D=22border-left-color: rgb(230, 126, 34); margin: 5px;=
 padding-left: 10px; border-left-width: thin; border-left-style: solid;=22=
>By reading the codes in nodeAgg.c, I found that some comments are outdat=
ed.<br />
The comments referred to the function lookup=5Fhash=5Fentry(), which has =
been removed in commit b563594.<br />
I've adjusted the comments to refer to the correct function to make it cl=
ear.</blockquote>
<br />
LGTM. This seems to be an oversight from 200f6100a, in which the<br />
function lookup=5Fhash=5Fentry() was removed.<br />
<br />
Thanks<br />
Richard</blockquote>
<div dir=3D=22auto=22>Hi,<br />
<br />
Thanks for review, added it to commitfest&=23160;<a href=3D=22https://com=
mitfest.postgresql.org/patch/5580/=22 target=3D=22=5Fblank=22>https://com=
mitfest.postgresql.org/patch/5580/</a><br />
<br />
<br />
--<br />
Zhang Mingli<br />
HashData</div>
</div>
</body>
</html>

--67b478ef_67fb67a2_7ffc--