Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qXwaf-000OGE-UV for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:32:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qXwae-002HcV-Qo for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Aug 2023 04:32:32 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qXwae-002HcM-FB for pgsql-hackers@lists.postgresql.org; Mon, 21 Aug 2023 04:32:32 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qXwaa-0006Ye-Vo for pgsql-hackers@lists.postgresql.org; Mon, 21 Aug 2023 04:32:31 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id F3C906078C; Mon, 21 Aug 2023 13:32:24 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_0769e950df9d20a07ab05a80c37a7600" Content-Transfer-Encoding: 7bit Date: Mon, 21 Aug 2023 13:32:24 +0900 From: Masahiro Ikeda To: Kyotaro Horiguchi Cc: Masahiko Sawada , Andres Freund , pgsql-hackers@lists.postgresql.org, mitsuru.hinata.5432@gmail.com Subject: Re: Fix pg_stat_reset_single_table_counters function In-Reply-To: <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com> References: <7cc69f863d9b1bc677544e3accd0e4b4@oss.nttdata.com> <9a4a6718abb47647ae83f1f4b3f9bf68@oss.nttdata.com> <20230812191207.aerskqox7aoan3ud@awork3.anarazel.de> <97c9f7a46681f051b1356e2987c3fd6c@oss.nttdata.com> <93d14a670cf090c08994f1f4958efa25@oss.nttdata.com> <0c0dfe89-528c-c93f-bd00-e21781336ff0@gmail.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9b5dbfd294a7deabe1323b04fa29f9db@oss.nttdata.com> X-Sender: ikedamsh@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_0769e950df9d20a07ab05a80c37a7600 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed On 2023-08-21 11:33, Kyotaro Horiguchi wrote: > On 2023/08/15 14:13, Masahiro Ikeda wrote: >> On 2023-08-15 11:48, Masahiko Sawada wrote: >>> +COMMENT ON DATABASE :current_database IS 'This is a test comment'; >>> -- insert or update in 'pg_shdescription' >>> >>> I think the current_database should be quoted (see other examples >>> where using current_database(), e.g. collate.linux.utf8.sql). Also it >>> would be better to reset the comment after the test. >> > > I'm not sure about others, but I would avoid using the name > "current_database" for the variable. > > I would just use "database" or "db" instead. Thanks! I agree your comment. I fixed in v5 patch. Regards, -- Masahiro Ikeda NTT DATA CORPORATION --=_0769e950df9d20a07ab05a80c37a7600 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=v5-0001-Fix-pg_stat_reset_single_table_counters-function.patch Content-Disposition: attachment; filename=v5-0001-Fix-pg_stat_reset_single_table_counters-function.patch; size=4889 RnJvbSA1OTgwYzA0MWUzM2ZkMTgwZTQzODY4Y2JkYzg3OGFjMGNmOTMxMTJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXNhaGlybyBJa2VkYSA8bXNoci5pa2VkYUBudHQuY29tPgpE YXRlOiBNb24sIDIxIEF1ZyAyMDIzIDEzOjI0OjI3ICswOTAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IHBnX3N0YXRfcmVzZXRfc2luZ2xlX3RhYmxlX2NvdW50ZXJzIGZ1bmN0aW9uLgoKVGhpcyBjb21t aXQgcmV2aXZlcyB0aGUgZmVhdHVyZSB0byByZXNldCBzdGF0aXN0aWNzIGZvciBhIHNpbmdsZQpy ZWxhdGlvbiBzaGFyZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIgdG8gemVy bywgd2hpY2gKd2FzIGltcGxlbWVudGVkIGJ5IHRoZSBmb2xsb3dpbmcgY29tbWl0LgoqIEVuaGFu Y2UgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVfY291bnRlcnMgZnVuY3Rpb24oZTA0MjY3ODQ0 KQoKVGhlIGZvbGxvd2luZyBjb21taXQgYWNjaWRlbnRhbGx5IGRlbGV0ZWQgdGhlIGZlYXR1cmUu CiogcGdzdGF0OiBzdG9yZSBzdGF0aXN0aWNzIGluIHNoYXJlZCBtZW1vcnkoNTg5MWM3YThlKQoK TmVlZCB0byBiYWNrcGF0Y2ggZnJvbSAxNS4KClJlcG9ydGVkLWJ5OiBNaXRzdXJ1IEhpbmF0YQot LS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jIHwgIDkgKysrKystLQogc3Jj L3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQgfCA0MiArKysrKysrKysrKysrKysrKysr KysrKysrKysrKwogc3JjL3Rlc3QvcmVncmVzcy9zcWwvc3RhdHMuc3FsICAgICAgfCAyNiArKysr KysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgNzUgaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC91dGlscy9hZHQvcGdzdGF0ZnVuY3Mu YyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCmluZGV4IDJhNGM4ZWY4N2Yu LjJiOTc0MmFkMjEgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5j cy5jCisrKyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9wZ3N0YXRmdW5jcy5jCkBAIC0xNyw2ICsx Nyw3IEBACiAjaW5jbHVkZSAiYWNjZXNzL2h0dXBfZGV0YWlscy5oIgogI2luY2x1ZGUgImFjY2Vz cy94bG9nLmgiCiAjaW5jbHVkZSAiYWNjZXNzL3hsb2dwcmVmZXRjaGVyLmgiCisjaW5jbHVkZSAi Y2F0YWxvZy9jYXRhbG9nLmgiCiAjaW5jbHVkZSAiY2F0YWxvZy9wZ19hdXRoaWQuaCIKICNpbmNs dWRlICJjYXRhbG9nL3BnX3R5cGUuaCIKICNpbmNsdWRlICJjb21tb24vaXAuaCIKQEAgLTE3NzYs MTMgKzE3NzcsMTcgQEAgcGdfc3RhdF9yZXNldF9zaGFyZWQoUEdfRlVOQ1RJT05fQVJHUykKIAlQ R19SRVRVUk5fVk9JRCgpOwogfQogCi0vKiBSZXNldCBhIHNpbmdsZSBjb3VudGVyIGluIHRoZSBj dXJyZW50IGRhdGFiYXNlICovCisvKgorICogUmVzZXQgYSBzdGF0aXN0aWNzIGZvciBhIHNpbmds ZSBvYmplY3QsIHdoaWNoIG1heSBiZSBvZiBjdXJyZW50CisgKiBkYXRhYmFzZSBvciBzaGFyZWQg YWNyb3NzIGFsbCBkYXRhYmFzZXMgaW4gdGhlIGNsdXN0ZXIuCisgKi8KIERhdHVtCiBwZ19zdGF0 X3Jlc2V0X3NpbmdsZV90YWJsZV9jb3VudGVycyhQR19GVU5DVElPTl9BUkdTKQogewogCU9pZAkJ CXRhYm9pZCA9IFBHX0dFVEFSR19PSUQoMCk7CisJT2lkCQkJZGJvaWQgPSAoSXNTaGFyZWRSZWxh dGlvbih0YWJvaWQpID8gSW52YWxpZE9pZCA6IE15RGF0YWJhc2VJZCk7CiAKLQlwZ3N0YXRfcmVz ZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIE15RGF0YWJhc2VJZCwgdGFib2lkKTsKKwlwZ3N0YXRf cmVzZXQoUEdTVEFUX0tJTkRfUkVMQVRJT04sIGRib2lkLCB0YWJvaWQpOwogCiAJUEdfUkVUVVJO X1ZPSUQoKTsKIH0KZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3MvZXhwZWN0ZWQvc3RhdHMu b3V0IGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKaW5kZXggMzE5MTY0YTVl OS4uOTk4NTU3OWUxOCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0 cy5vdXQKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9zdGF0cy5vdXQKQEAgLTc2NCw2 ICs3NjQsNDggQEAgRlJPTSBwZ19zdGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAndGVzdF9s YXN0X3NjYW4nOjpyZWdjbGFzczsKICAgICAgICAgMiB8IHQgICAgICB8ICAgICAgICAzIHwgdAog KDEgcm93KQogCistLS0tLQorLS0gVGVzdCB0byByZXNldCBzdGF0cyBmb3IgYSB0YWJsZSBzaGFy ZWQgYWNyb3NzIGFsbCBkYXRhYmFzZXMgKGV4LiBwZ19zaGRlc2NyaXB0aW9uKQorLS0tLS0KKy0t IHN0b3JlIHRoZSBvbGQgY29tbWVudCB0byByZXNldAorU0VMRUNUIHNob2JqX2Rlc2NyaXB0aW9u KGQub2lkLCAncGdfZGF0YWJhc2UnKSBhcyBkZXNjcmlwdGlvbl9iZWZvcmUKK0ZST00gcGdfZGF0 YWJhc2UgZCBXSEVSRSBkYXRuYW1lID0gY3VycmVudF9kYXRhYmFzZSgpIFxnc2V0CistLSB1cGRh dGUgdGhlIHN0YXRzIGluIHBnX3NoZGVzY3JpcHRpb24KK0JFR0lOOworU0VMRUNUIGN1cnJlbnRf ZGF0YWJhc2UoKSBhcyBkYiBcZ3NldAorQ09NTUVOVCBPTiBEQVRBQkFTRSA6ImRiIiBJUyAnVGhp cyBpcyBhIHRlc3QgY29tbWVudCc7CitTRUxFQ1QgcGdfc3RhdF9mb3JjZV9uZXh0X2ZsdXNoKCk7 CisgcGdfc3RhdF9mb3JjZV9uZXh0X2ZsdXNoIAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0K KyAKKygxIHJvdykKKworQ09NTUlUOworLS0gY2hlY2sgdG8gcmVzZXQgdGhlIHN0YXRzCitTRUxF Q1Qgbl90dXBfaW5zICsgbl90dXBfdXBkID4gMCBGUk9NIHBnX3N0YXRfYWxsX3RhYmxlcyBXSEVS RSByZWxpZCA9ICdwZ19zaGRlc2NyaXB0aW9uJzo6cmVnY2xhc3M7CisgP2NvbHVtbj8gCistLS0t LS0tLS0tCisgdAorKDEgcm93KQorCitTRUxFQ1QgcGdfc3RhdF9yZXNldF9zaW5nbGVfdGFibGVf Y291bnRlcnMoJ3BnX3NoZGVzY3JpcHRpb24nOjpyZWdjbGFzcyk7CisgcGdfc3RhdF9yZXNldF9z aW5nbGVfdGFibGVfY291bnRlcnMgCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCisgCisoMSByb3cpCisKK1NFTEVDVCBuX3R1cF9pbnMgKyBuX3R1cF91cGQgRlJPTSBwZ19z dGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAncGdfc2hkZXNjcmlwdGlvbic6OnJlZ2NsYXNz OworID9jb2x1bW4/IAorLS0tLS0tLS0tLQorICAgICAgICAwCisoMSByb3cpCisKKy0tIGNsZWFu dXAgdGhlIGNvbW1lbnQKK1xpZiA6ez9kZXNjcmlwdGlvbl9iZWZvcmV9CisgIENPTU1FTlQgT04g REFUQUJBU0UgOiJkYiIgSVMgOidkZXNjcmlwdGlvbl9iZWZvcmUnOworXGVsc2UKKyAgQ09NTUVO VCBPTiBEQVRBQkFTRSA6ImRiIiBJUyBOVUxMOworXGVuZGlmCiAtLS0tLQogLS0gVGVzdCB0aGF0 IHZhcmlvdXMgc3RhdHMgdmlld3MgYXJlIGJlaW5nIHByb3Blcmx5IHBvcHVsYXRlZAogLS0tLS0K ZGlmZiAtLWdpdCBhL3NyYy90ZXN0L3JlZ3Jlc3Mvc3FsL3N0YXRzLnNxbCBiL3NyYy90ZXN0L3Jl Z3Jlc3Mvc3FsL3N0YXRzLnNxbAppbmRleCA5YTE2ZGYxYzQ5Li41MzkzYjE4ZmFhIDEwMDY0NAot LS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9zdGF0cy5zcWwKKysrIGIvc3JjL3Rlc3QvcmVncmVz cy9zcWwvc3RhdHMuc3FsCkBAIC0zNzYsNiArMzc2LDMyIEBAIENPTU1JVDsKIFNFTEVDVCBzZXFf c2NhbiwgOid0ZXN0X2xhc3Rfc2VxJyA9IGxhc3Rfc2VxX3NjYW4gQVMgc2VxX29rLCBpZHhfc2Nh biwgOid0ZXN0X2xhc3RfaWR4JyA8IGxhc3RfaWR4X3NjYW4gQVMgaWR4X29rCiBGUk9NIHBnX3N0 YXRfYWxsX3RhYmxlcyBXSEVSRSByZWxpZCA9ICd0ZXN0X2xhc3Rfc2Nhbic6OnJlZ2NsYXNzOwog CistLS0tLQorLS0gVGVzdCB0byByZXNldCBzdGF0cyBmb3IgYSB0YWJsZSBzaGFyZWQgYWNyb3Nz IGFsbCBkYXRhYmFzZXMgKGV4LiBwZ19zaGRlc2NyaXB0aW9uKQorLS0tLS0KKworLS0gc3RvcmUg dGhlIG9sZCBjb21tZW50IHRvIHJlc2V0CitTRUxFQ1Qgc2hvYmpfZGVzY3JpcHRpb24oZC5vaWQs ICdwZ19kYXRhYmFzZScpIGFzIGRlc2NyaXB0aW9uX2JlZm9yZQorRlJPTSBwZ19kYXRhYmFzZSBk IFdIRVJFIGRhdG5hbWUgPSBjdXJyZW50X2RhdGFiYXNlKCkgXGdzZXQKKworLS0gdXBkYXRlIHRo ZSBzdGF0cyBpbiBwZ19zaGRlc2NyaXB0aW9uCitCRUdJTjsKK1NFTEVDVCBjdXJyZW50X2RhdGFi YXNlKCkgYXMgZGIgXGdzZXQKK0NPTU1FTlQgT04gREFUQUJBU0UgOiJkYiIgSVMgJ1RoaXMgaXMg YSB0ZXN0IGNvbW1lbnQnOworU0VMRUNUIHBnX3N0YXRfZm9yY2VfbmV4dF9mbHVzaCgpOworQ09N TUlUOworCistLSBjaGVjayB0byByZXNldCB0aGUgc3RhdHMKK1NFTEVDVCBuX3R1cF9pbnMgKyBu X3R1cF91cGQgPiAwIEZST00gcGdfc3RhdF9hbGxfdGFibGVzIFdIRVJFIHJlbGlkID0gJ3BnX3No ZGVzY3JpcHRpb24nOjpyZWdjbGFzczsKK1NFTEVDVCBwZ19zdGF0X3Jlc2V0X3NpbmdsZV90YWJs ZV9jb3VudGVycygncGdfc2hkZXNjcmlwdGlvbic6OnJlZ2NsYXNzKTsKK1NFTEVDVCBuX3R1cF9p bnMgKyBuX3R1cF91cGQgRlJPTSBwZ19zdGF0X2FsbF90YWJsZXMgV0hFUkUgcmVsaWQgPSAncGdf c2hkZXNjcmlwdGlvbic6OnJlZ2NsYXNzOworCistLSBjbGVhbnVwIHRoZSBjb21tZW50CitcaWYg Ons/ZGVzY3JpcHRpb25fYmVmb3JlfQorICBDT01NRU5UIE9OIERBVEFCQVNFIDoiZGIiIElTIDon ZGVzY3JpcHRpb25fYmVmb3JlJzsKK1xlbHNlCisgIENPTU1FTlQgT04gREFUQUJBU0UgOiJkYiIg SVMgTlVMTDsKK1xlbmRpZgogCiAtLS0tLQogLS0gVGVzdCB0aGF0IHZhcmlvdXMgc3RhdHMgdmll d3MgYXJlIGJlaW5nIHByb3Blcmx5IHBvcHVsYXRlZAotLSAKMi4yNS4xCgo= --=_0769e950df9d20a07ab05a80c37a7600--