MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Fri, 16 Jun 2023 20:44:53 +0900
From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Support to define custom wait events for extensions
In-Reply-To: <ZIwTWbXOogM5yO/H@paquier.xyz>
References: <b9f5411acda0cf15c8fbb767702ff43e@oss.nttdata.com>
 <ZIrFEo5qLcNAGjTs@paquier.xyz>
 <f3ce6711268cd443e71120eea3ba5cc0@oss.nttdata.com>
 <ZIwTWbXOogM5yO/H@paquier.xyz>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9b7a7edfc9fbe8dad9f0e35ada6d0c7e@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9b7a7edfc9fbe8dad9f0e35ada6d0c7e%40oss.nttdata.com>
Precedence: bulk

On 2023-06-16 16:46, Michael Paquier wrote:
> On Fri, Jun 16, 2023 at 11:14:05AM +0900, Masahiro Ikeda wrote:
>> I tried to query on pg_stat_activity to check the background worker
>> invoked by pg_prewarm. But, I found that pg_stat_activity doesn't show
>> it although I may be missing something...
>> 
>> So, I tried to implement TAP tests. But I have a problem with it.
>> I couldn't find the way to check the status of another backend
>> while the another backend wait with custom wait events.
> 
> Hmm.  Right.  It seems to me that BGWORKER_BACKEND_DATABASE_CONNECTION
> is required in this case, with BackgroundWorkerInitializeConnection()
> to connect to a database (or not, like the logical replication
> launcher if only access to shared catalogs is wanted).
> 
> I have missed that the leader process of pg_prewarm does not use that,
> because it has no need to connect to a database, but its workers do.
> So it is not going to show up in pg_stat_activity.

Yes. Thanks to your advice, I understood that
BGWORKER_BACKEND_DATABASE_CONNECTION is the reason.

I could make the TAP test that invokes a background worker waiting 
forever
and checks its custom wait event in pg_stat_activity. So, I'll make 
patches
including test codes next week.

Regards,
-- 
Masahiro Ikeda
NTT DATA CORPORATION