Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUqwj-00021z-R4 for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Mar 2022 14:17:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nUqwh-0004cr-Rp for pgsql-hackers@arkaria.postgresql.org; Thu, 17 Mar 2022 14:17:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUqwg-0004ci-SS for pgsql-hackers@lists.postgresql.org; Thu, 17 Mar 2022 14:17:43 +0000 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nUqwb-0001oR-AH for pgsql-hackers@postgresql.org; Thu, 17 Mar 2022 14:17:42 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 8C5A5320094D; Thu, 17 Mar 2022 10:17:33 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Thu, 17 Mar 2022 10:17:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=OJ0+r1WNeZINNYOHaWCQKJNLJlzama+V5vMqMbV2x pk=; b=TFJx9dHyzn9cx5Ufu/56nnHZk0gl/h8VXPfZVDoDcES65Q8w7LWd+hOz2 v2VDR6syOB1PcvNC645Km6qUnefqsdJZyBVQxiufcwVWlXpBjzyA8PuQbbgF9K9H zjZTRLSdPY6Ej+JS444poY/shB37c2qWGHUs7fB3EME7IegF5wM7rl6g2jFRxtsL Wap+bI+pqH8PNh1xXg6hLE1QJ4OJJ7ymzSLkx0yqkBhTGUoEy/FIxwGpbRx62MA5 GG94uQ83csfuK0ATblp1TAbKDYiogZs35Sz0yl8y57qvDvkvz9MF1zXx6cgaymM4 ybPXQ2ULw8mVg4hS0rPli+o191gQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudefgedgieduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvfhfhjggtgfesthejredttdefjeenucfhrhhomheprfgvthgv rhcugfhishgvnhhtrhgruhhtuceophgvthgvrhdrvghishgvnhhtrhgruhhtsegvnhhtvg hrphhrihhsvggusgdrtghomheqnecuggftrfgrthhtvghrnhepfeejgeehteeuhfevvedu leeufedtjeetiefftedvudfhtdeifefgueettdevgefgnecuvehluhhsthgvrhfuihiivg eptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhhtrhgruhht segvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 17 Mar 2022 10:17:30 -0400 (EDT) Message-ID: <9c0dd1f3-c1b9-9c10-eca6-35f22104434a@enterprisedb.com> Date: Thu, 17 Mar 2022 15:17:29 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: Column Filtering in Logical Replication Content-Language: en-US To: Tomas Vondra , Amit Kapila Cc: "houzj.fnst@fujitsu.com" , Alvaro Herrera , Justin Pryzby , Rahila Syed , Peter Smith , pgsql-hackers , "shiy.fnst@fujitsu.com" References: <202201120041.p24wvsfcsope@alvherre.pgsql> <78b8d385-57cb-9a3f-cfe5-9f300f15eced@enterprisedb.com> <822a8e40-287c-59ff-0ea9-35eb759f4fe6@enterprisedb.com> <2b8471f9-3849-c91f-ef82-9181d4bca0a7@enterprisedb.com> <16e83ce3-8415-b732-37b2-c3329a2c13a1@enterprisedb.com> From: Peter Eisentraut In-Reply-To: <16e83ce3-8415-b732-37b2-c3329a2c13a1@enterprisedb.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk I notice that the publication.sql regression tests contain a number of comments like +-- error: replica identity "a" not included in the column list +ALTER PUBLICATION testpub_fortable ADD TABLE testpub_tbl5 (b, c); but the error doesn't actually happen, because of the way the replica identity checking was changed. This needs to be checked again.