MIME-Version: 1.0
Content-Type: multipart/mixed;
 boundary="=_ed298423bbd139946dacd81fa98130cb"
Content-Transfer-Encoding: 7bit
Date: Thu, 27 Jun 2024 16:09:37 +0900
From: ikedarintarof <ikedarintarof@oss.nttdata.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: pgsql-hackers@postgresql.org
Subject: Re: doc: modify the comment in function libpqrcv_check_conninfo()
In-Reply-To: 
 <CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
References: <6a1ca81b27fec4da0ccdfaaaec787982@oss.nttdata.com>
 <CAGECzQRjJkCQ9AUQA_7kJw8c4iUwVAXPfD_VQu+-DVcd-LCT8A@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9c15a4b74d09348d03b02934fc429c94@oss.nttdata.com>
Archived-At: 
 <https://www.postgresql.org/message-id/9c15a4b74d09348d03b02934fc429c94%40oss.nttdata.com>
Precedence: bulk

--=_ed298423bbd139946dacd81fa98130cb
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=US-ASCII;
 format=flowed

Thank you for your comment!

I've added the must_use_password argument. A new patch is attached.


On 2024-06-26 23:36, Jelte Fennema-Nio wrote:
> On Wed, 26 Jun 2024 at 14:53, ikedarintarof
> <ikedarintarof@oss.nttdata.com> wrote:
>> The function 'libpqrcv_check_conninfo()' returns 'void', but the 
>> comment
>> above says that the function returns true or false.
>> I've attached a patch to modify the comment.
> 
> Agreed that the current comment is wrong, but the new comment should
> mention the must_use_password argument. Because only if
> must_use_password is true, will it throw an error.

--=_ed298423bbd139946dacd81fa98130cb
Content-Transfer-Encoding: base64
Content-Type: text/x-diff;
 name=0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch
Content-Disposition: attachment;
 filename=0001-modify-the-commnet-in-libpqrcv_check_conninfo.patch;
 size=1282

RnJvbSAxOGMzMDI2MjUxNzZhMzhlY2Y5NWVkZTBiZDBlNWE0MTA0MzU4ODIzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiBSaW50YXJvIElrZWRhIDw1MTM5NDc2NityaW5pa2VkYUB1c2Vy
cy5ub3JlcGx5LmdpdGh1Yi5jb20+CkRhdGU6IFRodSwgMjcgSnVuIDIwMjQgMTY6MDQ6MDggKzA5
MDAKU3ViamVjdDogW1BBVENIXSBtb2RpZnkgdGhlIGNvbW1uZXQgaW4gbGlicHFyY3ZfY2hlY2tf
Y29ubmluZm8oKQoKLS0tCiBzcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9saWJwcXdhbHJlY2VpdmVy
L2xpYnBxd2FscmVjZWl2ZXIuYyB8IDUgKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlv
bnMoKyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvcmVwbGljYXRp
b24vbGlicHF3YWxyZWNlaXZlci9saWJwcXdhbHJlY2VpdmVyLmMgYi9zcmMvYmFja2VuZC9yZXBs
aWNhdGlvbi9saWJwcXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYwppbmRleCAwMmYxMmYy
OTIxLi4yNTJlOTdhMTliIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9yZXBsaWNhdGlvbi9saWJw
cXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYworKysgYi9zcmMvYmFja2VuZC9yZXBsaWNh
dGlvbi9saWJwcXdhbHJlY2VpdmVyL2xpYnBxd2FscmVjZWl2ZXIuYwpAQCAtMzA5LDggKzMwOSw5
IEBAIGJhZF9jb25uZWN0aW9uOgogICogbG9jYWwgZmlsZXN5c3RlbSBhY2Nlc3MgdG8gYmUgYXR0
ZW1wdGVkLgogICoKICAqIElmIHRoZSBjb25uZWN0aW9uIHN0cmluZyBjYW4ndCBiZSBwYXJzZWQs
IHRoaXMgZnVuY3Rpb24gd2lsbCByYWlzZQotICogYW4gZXJyb3IgYW5kIHdpbGwgbm90IHJldHVy
bi4gSWYgaXQgY2FuLCBpdCB3aWxsIHJldHVybiB0cnVlIGlmIHRoaXMKLSAqIGNvbm5lY3Rpb24g
c3RyaW5nIHNwZWNpZmllcyBhIHBhc3N3b3JkIGFuZCBmYWxzZSBvdGhlcndpc2UuCisgKiBhbiBl
cnJvci4gSWYgaXQgY2FuIGFuZCBtdXN0X3VzZV9wYXNzd29yZCBpcyBmYWxzZSwgaXQgd2lsbCBk
byBub3RoaW5nLgorICogSWYgbXVzdF91c2VfcGFzc3dvcmQgaXMgdHJ1ZSwgdGhlIGZ1bmN0aW9u
IGNoZWNrcyB3aHRoZXIgYSBwYXNzd29yZCBpcyAKKyAqIHByb3ZpZGVkIGFuZCBkZWNpZGVzIGFu
IGVycm9yIHNob3VsZCBiZSByYWlzZWQuCiAgKi8KIHN0YXRpYyB2b2lkCiBsaWJwcXJjdl9jaGVj
a19jb25uaW5mbyhjb25zdCBjaGFyICpjb25uaW5mbywgYm9vbCBtdXN0X3VzZV9wYXNzd29yZCkK
LS0gCjIuMzkuMyAoQXBwbGUgR2l0LTE0NikKCg==
--=_ed298423bbd139946dacd81fa98130cb--