Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rubWi-006Omd-Qg for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Apr 2024 17:14:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rubWh-005bPG-2i for pgsql-hackers@arkaria.postgresql.org; Wed, 10 Apr 2024 17:14:23 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rubWg-005bOB-L5 for pgsql-hackers@lists.postgresql.org; Wed, 10 Apr 2024 17:14:22 +0000 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1rubWe-000ELr-1s for pgsql-hackers@lists.postgresql.org; Wed, 10 Apr 2024 17:14:21 +0000 Received: by mail-pj1-x1036.google.com with SMTP id 98e67ed59e1d1-2a3095907ffso3628989a91.0 for ; Wed, 10 Apr 2024 10:14:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20230601.gappssmtp.com; s=20230601; t=1712769258; x=1713374058; darn=lists.postgresql.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=4UaJaxCkuzRO7KhTH9Wkp1HberfRUlW36pid8lVuKuQ=; b=YQOWws6f+kT8QUZWqjp/l8TQnOkCxM8y/4797hEZxNiibXbnhLHPKdmwz6kmDuurb7 2S6I4+AuoUujdkCXZQO75g6JHw3jrWssWUbWGSHbfkP8Z8m4jH4s/nsp8qwtWv8YdvB0 ug4rJidRn1PIAmFv5pRu8nlwVQQVtYUB4onM9P/QveM8WBPTAtsRe++31APMKZxe5hPq EZ5Ag2/5QthPoJ9eHcR0+3a4hXAE7JI7ktGDcXTUA9pYgKCwpb/LLE5R5iiIq7dSjcdR M23Ql116C7wXQ9oqI3co66cBa3c0PX52jdjYeV4yrb9/2NErVLy2ugCH6yY3WbsNOm4H U6Hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712769258; x=1713374058; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4UaJaxCkuzRO7KhTH9Wkp1HberfRUlW36pid8lVuKuQ=; b=MGhvRO4HnifvKSL1WOYg4o+i6t/l9lRzJlfrt95S7E7edQqtLASvOBrFI7hhvGC1RF DmsCNpG43VuhLNQOIKaN/n3qUtPbixHVXxb6QqQWj0Yzq36JylcWt7mzRZ0TwOPUafbs UMmq42NCRAf28+iRHavQZfGHWXBs6/SNoclZKqY/ocU+zB52iUHXQTQHXefBjuH20crB n/Zxg2uj1pdyHy2QGpidSxwJIaxZ/hn6ZR69n9Xi5fjwRju7/Urat5LSBVPQhS4Qx6dG eIPgilq3fSfqQEJvV4ZVO0He/SMcaY/frDSuXIqjODC2WfWoafPClK2t5lfVPV5nZy1X QTtA== X-Forwarded-Encrypted: i=1; AJvYcCUddKb0/FLxd4FI8MmUshZUIt3IVqMZlatO3sRD9RSvUCa6UfMzQnuZbL6mEFCpw6IUVeqomGhfACg1CzdisSO38yolwq9Ucq/nJfM1UgFRJylt X-Gm-Message-State: AOJu0Ywk8CGAbPUuW3FGADzVl/bpR5/38Vk3WoLBqxPgou/+ImhhCj9Y CM2+2m5JkUBPeEw5ApO1A17SHHUUx0tFU8DvT/yhZEaA1G2G/SOe7WJvky6O0A== X-Google-Smtp-Source: AGHT+IEFusffhFZyWF7CIxQVKzswLQjtOWCGR1rweeMwCRmU+syZT5WAocbanvDJZ0YA4YNmvY32+w== X-Received: by 2002:a17:90a:e38f:b0:2a2:437:18ec with SMTP id b15-20020a17090ae38f00b002a2043718ecmr2709210pjz.46.1712769257913; Wed, 10 Apr 2024 10:14:17 -0700 (PDT) Received: from jeff-laptop.lan (c-76-102-242-158.hsd1.ca.comcast.net. [76.102.242.158]) by smtp.gmail.com with ESMTPSA id 95-20020a17090a09e800b002a53ec5cec0sm1733812pjo.27.2024.04.10.10.14.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Apr 2024 10:14:17 -0700 (PDT) Message-ID: <9c7f66fadea820bba375540ef80a402fdcf5b642.camel@j-davis.com> Subject: Re: Improve eviction algorithm in ReorderBuffer From: Jeff Davis To: Heikki Linnakangas , Michael Paquier Cc: Masahiko Sawada , Amit Kapila , vignesh C , Peter Smith , Tomas Vondra , "Hayato Kuroda (Fujitsu)" , Shubham Khanna , Dilip Kumar , PostgreSQL Hackers Date: Wed, 10 Apr 2024 10:14:16 -0700 In-Reply-To: <91098347-c594-486d-9c19-26481125a399@iki.fi> References: <791d98f474e518387d09eb390b8a12f265d130cc.camel@j-davis.com> <8cb6bbf6-57e7-4d14-9664-89505993afaa@iki.fi> <10f5dcecb5224c9967a7d595b6168a4144ffc24e.camel@j-davis.com> <4ce8dd017b911e8b2772147992db468deed71896.camel@j-davis.com> <91098347-c594-486d-9c19-26481125a399@iki.fi> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu2 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2024-04-10 at 08:30 +0300, Heikki Linnakangas wrote: > My #1 choice would be to write a patch to switch the pairing heap,=20 > performance test that, and revert the binary heap changes. Sounds good to me. I would expect it to perform better than the extra hash table, if anything. It also has the advantage that we don't change the API for binaryheap in 17. Regards, Jeff Davis