Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCJhg-0002by-Dj for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2019 08:28:16 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iCJhe-00052y-5N for pgsql-hackers@arkaria.postgresql.org; Mon, 23 Sep 2019 08:28:14 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iCJhd-00052r-Qx for pgsql-hackers@lists.postgresql.org; Mon, 23 Sep 2019 08:28:13 +0000 Received: from www4.webmail.pair.com ([66.39.3.58]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iCJhb-0007sQ-D1 for pgsql-hackers@postgresql.org; Mon, 23 Sep 2019 08:28:12 +0000 Received: from rc.webmail.pair.com (localhost [127.0.0.1]) by www4.webmail.pair.com (Postfix) with ESMTP id 55BD1B400AB; Mon, 23 Sep 2019 04:28:09 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Mon, 23 Sep 2019 10:28:09 +0200 From: Tels To: David Fetter Cc: Andrew Gierth , Kyotaro Horiguchi , pgsql-hackers@postgresql.org Subject: Re: Efficient output for integer types Organization: Highly Unorganized Reply-To: nospam-pg-abuse@bloodgate.com Mail-Reply-To: nospam-pg-abuse@bloodgate.com In-Reply-To: <20190922215804.GL31596@fetter.org> References: <20190917065504.GT31596@fetter.org> <20190917070156.GU31596@fetter.org> <20190918034201.GX31596@fetter.org> <20190918.162746.139473050.horikyota.ntt@gmail.com> <20190920191450.GD31596@fetter.org> <20190920210916.GF31596@fetter.org> <20190920211813.GG31596@fetter.org> <87h856pekw.fsf@news-spur.riddles.org.uk> <20190921060835.GH31596@fetter.org> <87a7ayp4bm.fsf@news-spur.riddles.org.uk> <20190922215804.GL31596@fetter.org> Message-ID: <9cb0b9d6d98472d7d56dd6f78e9b40d4@bloodgate.com> X-Sender: nospam-pg-abuse@bloodgate.com User-Agent: Roundcube Webmail/1.3.8 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Moin, On 2019-09-22 23:58, David Fetter wrote: > On Sat, Sep 21, 2019 at 07:29:25AM +0100, Andrew Gierth wrote: >> >>>>> "David" == David Fetter writes: > Fixed. Good work, more performance is sure nice :) Noticed one more thing in the patch: > - *start++ = *a; > - *a-- = swap; > + memcpy(pos - 2, DIGIT_TABLE + c, 2); > + i += 2; > } > + else > + *a = (char) ('0' + value2); > + > + return olength; > } The line "i += 2;" modifies i, but i is never used again nor returned. Best regards, Tels