Message-ID: <9cbbd8fc-4e46-495d-8260-a267196a1826@163.com>
Date: Thu, 16 Apr 2026 13:27:13 +0800
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid
To: Fujii Masao <masao.fujii@gmail.com>, vignesh C <vignesh21@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: 
 <CALDaNm16knMFtcqyAG3XYSkyagmVXfhaR0T=hau8UTAU0+eLQQ@mail.gmail.com>
 <CAHGQGwEuEd2StEYuP9vj+jCFT=hQbX8xcQeq8=Kj8r9xT3vmyg@mail.gmail.com>
 <CALDaNm0zJuUon52OEx5SpMoP8LEGJh+=PyYqwmcD7Zh97_dnJg@mail.gmail.com>
 <CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
From: Xiaopeng Wang <wxp_728@163.com>
In-Reply-To: 
 <CAHGQGwGFP1AEQ1+=95LrVpUUOOPeebi13aEXXebSZ7bvWVT=wA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/9cbbd8fc-4e46-495d-8260-a267196a1826%40163.com>
Precedence: bulk

在 2026/4/16 12:11, Fujii Masao 写道:
> On Mon, Apr 13, 2026 at 4:10 PM vignesh C <vignesh21@gmail.com> wrote:
>> I felt these also should be updated, the attached v2 version patch
>> includes the changes for the same.
> Thanks for updating the patch!
>
> -       applyPtr = (latestApplyPtr == InvalidXLogRecPtr) ?
> +       applyPtr = (XLogRecPtrIsInvalid(latestApplyPtr)) ?
>
> XLogRecPtrIsValid() should be used here, instead?
>
> Regards,
>

Yeah, I was about to raise the same comment, and Fujii-san beat me. I believe it should be XLogRecPtrIsValid().

Otherwise, the patch looks good to me.

Regards,
Xiaopeng Wang