Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt63u-0004ak-FF for pgsql-hackers@arkaria.postgresql.org; Mon, 23 May 2022 11:17:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nt63t-0002dx-4H for pgsql-hackers@arkaria.postgresql.org; Mon, 23 May 2022 11:17:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt63s-0002dn-Qc for pgsql-hackers@lists.postgresql.org; Mon, 23 May 2022 11:17:20 +0000 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nt63p-0004XT-Eh for pgsql-hackers@lists.postgresql.org; Mon, 23 May 2022 11:17:20 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id DF4FA3200939; Mon, 23 May 2022 07:17:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Mon, 23 May 2022 07:17:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1653304634; x= 1653391034; bh=EwDRWYSmQr48zLptF8+1VImrq87Uqy54U4w+9n2FaJ8=; b=t rTVYp/bD5YQBd4B9GZZeywqAT4T7qJG0ojVHabqkIpf8U2gsMX+cZeP3MFm+2igq 1M2bxtRW/WDlthxSUhYsJ+5M2PzmLmLzru7WtgqT12+pcbeXYd6x8FnzKqYOaEPf J8C8hEHrPhmzw0SaSNeHfebhMa4qZA3xqwmAc0VMMtrPrSNrmhzr6JdgkaJhW9lf a/k815fI1Ck1vk6Xcx215Pdy7HnhI4yW/lKB4L4dR+F8i5yhboII6ZRnAgW2zbNw ZONOquq1FTLEYLy7yMsJnSrpj3IN4Hk3MU/xxVIUqq6n6KPouHzrygRp4YV2RGLF rR3nzHUouK4dmEYa08D3g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrjedugddtkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfuffvvehfhfgjtgfgsehtje ertddtfeejnecuhfhrohhmpefrvghtvghrucfgihhsvghnthhrrghuthcuoehpvghtvghr rdgvihhsvghnthhrrghuthesvghnthgvrhhprhhishgvuggsrdgtohhmqeenucggtffrrg htthgvrhhnpeelfeevieetfedugeelgeegveehjeeggfegtdegueevfefgkeegieejgffh hedvvdenucffohhmrghinhepfihikhhtihhonhgrrhihrdhorhhgnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepphgvthgvrhdrvghishgvnhht rhgruhhtsegvnhhtvghrphhrihhsvggusgdrtghomh X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 23 May 2022 07:17:13 -0400 (EDT) Message-ID: <9cdc8156-d059-e4e4-418a-589df822c070@enterprisedb.com> Date: Mon, 23 May 2022 13:17:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: create_help.pl treats as replaceable Content-Language: en-US To: Kyotaro Horiguchi Cc: tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org References: <1581685.1652800163@sss.pgh.pa.us> <20220518.095805.2164390691449974704.horikyota.ntt@gmail.com> <304e2c49-14b4-e93c-ff64-8a5a0d54e408@enterprisedb.com> <20220519.111233.1054039569955825310.horikyota.ntt@gmail.com> From: Peter Eisentraut In-Reply-To: <20220519.111233.1054039569955825310.horikyota.ntt@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 19.05.22 04:12, Kyotaro Horiguchi wrote: > At Wed, 18 May 2022 18:23:57 +0200, Peter Eisentraut wrote in >> "Boolean" is correct; see for >> example. > > Ok, so, don't we in turn need to replace "boolean"s with "Boolean"? > > "only boolean operators can have negators" > "only boolean operators can have restriction selectivity" > ... > > And I'm not sure how to do with "bool". Should it be "Boolean" instead > from the point of uniformity? > > errmsg("only bool, numeric, and text types could be " The SQL data type is called BOOLEAN, and we typically lower-case type names in PostgreSQL, so messages should be like column %s should be of type integer column %s should be of type boolean As an adjective, not a type, it should be spelled Boolean, because that's how it's in the dictionary (cf. Gaussian). %s should have a string value %s should have a Boolean value "bool" should normally not appear in user-facing messages, unless we are dealing with internal type names (cf. int4) or C types. Of course, the lines between all of the above are blurry.