MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Wed, 20 Sep 2023 09:43:15 +0900
From: Shinya Kato <Shinya11.Kato@oss.nttdata.com>
To: Ryoga Yoshida <bt23yoshidar@oss.nttdata.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Fix bug in VACUUM and ANALYZE docs
In-Reply-To: <9374034cb91b647b55a774a8980b0228@oss.nttdata.com>
References: <9374034cb91b647b55a774a8980b0228@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <9cece9c906c15fc54ee1bcb27ada5b49@oss.nttdata.com>
Archived-At: <https://www.postgresql.org/message-id/9cece9c906c15fc54ee1bcb27ada5b49%40oss.nttdata.com>
Precedence: bulk

On 2023-09-19 17:59, Ryoga Yoshida wrote:
> Hi,
> 
> Issue1:
> VACUUM and ANALYZE docs explain that the parameter of
> BUFFER_USAGE_LIMIT is optional as follows. But this is not true. The
> argument, size, is required for BUFFER_USAGE_LIMIT. So the docs should
> be fixed this issue.
> BUFFER_USAGE_LIMIT [ size ]
> https://www.postgresql.org/docs/devel/sql-vacuum.html
> https://www.postgresql.org/docs/devel/sql-analyze.html
> 
> Issue2:
> Sizes may also be specified as a string containing the numerical size
> followed by any one of the following memory units: kB (kilobytes), MB
> (megabytes), GB (gigabytes), or TB (terabytes).
> VACUUM and ANALYZE docs explain that the argument of
> BUFFER_USAGE_LIMIT accepts the units like kB (kilobytes), MB
> (megabytes), GB (gigabytes), or TB (terabytes). But it also actually
> accepts B(bytes) as an unit. So the docs should include "B(bytes)" as
> an unit that the argument of BUFFER_USAGE_LIMIT can accept.
> 
> You can see the patch in the attached file.

Thanks for the patch.
You're right. It looks good to me.

-- 
Regards,
Shinya Kato
NTT DATA GROUP CORPORATION