Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWPzB-0001p3-AP for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 21:54:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nWPz9-0007ME-NB for pgsql-hackers@arkaria.postgresql.org; Mon, 21 Mar 2022 21:54:43 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nWPz8-0007M5-Ke for pgsql-hackers@lists.postgresql.org; Mon, 21 Mar 2022 21:54:43 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1nWPz5-0007Hc-IR for pgsql-hackers@lists.postgresql.org; Mon, 21 Mar 2022 21:54:41 +0000 Received: by mail-ej1-x62d.google.com with SMTP id qx21so32498677ejb.13 for ; Mon, 21 Mar 2022 14:54:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb.com; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=yM1wA7qVUR0M19NMvVqEfAD+8kuLF0vAIj+4YPWIVzc=; b=aQsCP4seqTErXzThYnjuIgj+kgwqcfjFXSdmXDfpib+/OiFh6SDl5w5AMPjzpaksz9 K6TmxNa/CcJc8+geijMgwlxNb/W2rk47VvgC4iYoN7Njtv91EimbpypwWpnmgWSxsKF8 3mn6QvcuxXygkFU1OJqEC9KYISja+NjYdwFxeHEN3kDv4Flao2lForWGJtY11eSM1BPl wrVZyzaYwnvQVLmstHcfU8Pw6KiKK6ctUswhlFzlTU8tYkqy5zEXIapIT+7biz7YCkjA 3qZCs57HAM5WaUAXghE3EHJTqJoNi3giyIuRKbOLqIS2ipgtS0hRZFZVUOj0pL1QL5GA KOYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=yM1wA7qVUR0M19NMvVqEfAD+8kuLF0vAIj+4YPWIVzc=; b=063zOMtjX1Cyias+GK4FyvytFBY6H/6g5FPkd0D0welv3U3xkj5u0WI1P4xWoDnz9F 04GZDQKCgpo2cacH7M4pCipAqjt4PTaNcFjmS0hFM59I0I2WjgOYoVCq9eE1IPaP9pee sRtAZuTNyy+dcPGKlFPYUPR4f5GoBeKJPKl5dBmGPv7M4LIur7Y6wxD6PI8GbxVA5vaP UYHk3KAmNExaos/fVqVW4UEZ804++zok2hGZ+J2dgNfxe2ycyf4zbSev0EaBe3MwsRHQ bwxVLr75oyA8uKixzqxjPadu/VrTO+PhDOXIY/YjXa27JmvSJ840DoU0CG4LYul227SU 85PA== X-Gm-Message-State: AOAM531suD3b9XNrrCPn4TsCz1gNxYcU2ifhDhE+3SpU9YNXuoOzHErz QxB6w5s0m2xrRZQfG9UJr1d26IGj1rbVoyO4a+z0fldVZn/B8C2q9Vk2iEtwZqV14/I5AI+UT+7 ucNbrDNEyfjm9yciCpQFPHHi+uBbs6rkYeR7GqgxM5z9ZrNfFYaU4RT45xisLKde1a2cOIFRtl/ 0wOd0vB/ZO+jVez/N0gorI93119JlDdNkpHDp3CXY63lfudvZN2RSi X-Google-Smtp-Source: ABdhPJxedCQVSgeJ9fZ/Kfc6cD9BDyrY8EZhhSIJQsavmUQPLnSH2NPPanb1jMDcGIdGtEmVMEDy+g== X-Received: by 2002:a17:907:3d87:b0:6e0:bef:c3cb with SMTP id he7-20020a1709073d8700b006e00befc3cbmr6883652ejc.503.1647899677990; Mon, 21 Mar 2022 14:54:37 -0700 (PDT) Received: from [10.137.0.17] (cst-prg-78-113.cust.vodafone.cz. [46.135.78.113]) by smtp.gmail.com with ESMTPSA id g9-20020aa7c849000000b00412fc6bf26dsm8711027edt.80.2022.03.21.14.54.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 21 Mar 2022 14:54:37 -0700 (PDT) Message-ID: <9d8b3351-9094-0ae9-ae7c-e03bab81a6ec@enterprisedb.com> Date: Mon, 21 Mar 2022 22:54:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 Subject: Re: logical decoding and replication of sequences Content-Language: en-US To: Peter Eisentraut Cc: Amit Kapila , PostgreSQL Hackers , Petr Jelinek References: <3d68b45a-ceb5-6824-3a39-f53411fd0c88@enterprisedb.com> <802f8b1b-a798-be52-c829-7f0fb9faafd5@enterprisedb.com> <983bf0c7-9757-fd13-3896-8452cf4c4c52@enterprisedb.com> <9211312a-6501-1caf-ee7b-c0d4814b6091@enterprisedb.com> <41ada110-bc7c-32a3-08bd-fb5023dd74ba@enterprisedb.com> <2eed0f76-3a1a-8b8b-ac1b-e0f9a0d98287@enterprisedb.com> <9defb937-20a9-1d9f-6972-f1c4b4da4f73@enterprisedb.com> <8e766e0f-ed3e-fd68-4b0f-10dd2db60c88@enterprisedb.com> <6b21233e-c880-e4ad-5df2-7832f769296c@enterprisedb.com> <9da788c7-01eb-f11d-aa08-c5f61fe9f33a@enterprisedb.com> From: Tomas Vondra In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 3/21/22 14:05, Peter Eisentraut wrote: > On 20.03.22 23:55, Tomas Vondra wrote: >> Attached is a rebased patch, addressing most of the remaining issues. > > This looks okay to me, if the two FIXMEs are addressed.  Remember to > also update protocol.sgml if you change LOGICAL_REP_MSG_SEQUENCE. Thanks. Do we want to use a different constant for the sequence message? I've used 'X' for the WIP patch, but maybe there's a better value? regards -- Tomas Vondra EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company