Content-Type: multipart/mixed; boundary="------------DXh56tCQLAnlsgZM1OggGx5j"
Message-ID: <9ecfa109-7ef8-26bb-3881-f14741abad66@gmail.com>
Date: Mon, 20 Mar 2023 11:57:31 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Reconcile stats in find_tabstat_entry() and get rid of
 PgStat_BackendFunctionEntry
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>,
 Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
 pgsql-hackers@lists.postgresql.org
References: <20230214.151102.1070436528757437157.horikyota.ntt@gmail.com>
 <9262b2a9-6785-1f83-bf7f-7fcf90c2c113@gmail.com>
 <20230215.095644.822493184688844040.horikyota.ntt@gmail.com>
 <130095b4-7c6d-b6f1-69d4-94f66231f81d@gmail.com>
 <20230216212121.uvav7xgdh2ysqjy5@awork3.anarazel.de>
 <f08fee25-1dac-b68b-19af-f4b55ceb3802@gmail.com>
 <ZBK3S5Na71pjgGCX@paquier.xyz>
 <621ed53c-4d9a-8f77-ab8c-20235f2d95a1@gmail.com>
 <ZBMBh5ve3tyqH5/m@paquier.xyz>
 <f6ea424b-fabe-b702-e4e3-b71ebc827d59@gmail.com>
 <ZBeeH5UoNkTPrwHO@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZBeeH5UoNkTPrwHO@paquier.xyz>
Archived-At: <https://www.postgresql.org/message-id/9ecfa109-7ef8-26bb-3881-f14741abad66%40gmail.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------DXh56tCQLAnlsgZM1OggGx5j
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 3/20/23 12:43 AM, Michael Paquier wrote:
> At the
> end, documenting both still sounds like the best move to me.

Agree.

Please find attached v1-0001-pg_stat_get_xact_blocks_fetched-and_hit-doc.patch doing so.

I did not put the exact same wording as the one being removed in ddfc2d9, as:

- For pg_stat_get_xact_blocks_hit(), I think it's better to be closer to say the
pg_statio_all_tables.heap_blks_hit definition.

- For pg_stat_get_xact_blocks_fetched(), I think that using "buffer" is better (than block) as at the
end it's related to pgstat_count_buffer_read().

At the end there is a choice to be made for both for the wording between block and buffer. Indeed their
counters get incremented in "buffer" macros while retrieved in those "blocks" functions.

"Buffer" sounds more appropriate to me, so the attached has been done that way.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
--------------DXh56tCQLAnlsgZM1OggGx5j
Content-Type: text/plain; charset=UTF-8;
 name="v1-0001-pg_stat_get_xact_blocks_fetched-and_hit-doc.patch"
Content-Disposition: attachment;
 filename*0="v1-0001-pg_stat_get_xact_blocks_fetched-and_hit-doc.patch"
Content-Transfer-Encoding: base64

ZGlmZiAtLWdpdCBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwgYi9kb2Mvc3JjL3Nn
bWwvbW9uaXRvcmluZy5zZ21sCmluZGV4IDYyNDliYjUwZDAuLmZiYThlODkyY2YgMTAwNjQ0
Ci0tLSBhL2RvYy9zcmMvc2dtbC9tb25pdG9yaW5nLnNnbWwKKysrIGIvZG9jL3NyYy9zZ21s
L21vbml0b3Jpbmcuc2dtbApAQCAtNTY5Nyw2ICs1Njk3LDMyIEBAIFNFTEVDVCBwaWQsIHdh
aXRfZXZlbnRfdHlwZSwgd2FpdF9ldmVudCBGUk9NIHBnX3N0YXRfYWN0aXZpdHkgV0hFUkUg
d2FpdF9ldmVudCBpCiAgICAgICAgPC9wYXJhPjwvZW50cnk+CiAgICAgICA8L3Jvdz4KIAor
ICAgICAgPHJvdz4KKyAgICAgICA8ZW50cnkgcm9sZT0iZnVuY190YWJsZV9lbnRyeSI+PHBh
cmEgcm9sZT0iZnVuY19zaWduYXR1cmUiPgorICAgICAgICA8aW5kZXh0ZXJtPgorICAgICAg
ICAgPHByaW1hcnk+cGdfc3RhdF9nZXRfeGFjdF9ibG9ja3NfZmV0Y2hlZDwvcHJpbWFyeT4K
KyAgICAgICAgPC9pbmRleHRlcm0+CisgICAgICAgIDxmdW5jdGlvbj5wZ19zdGF0X2dldF94
YWN0X2Jsb2Nrc19mZXRjaGVkPC9mdW5jdGlvbj4gKCA8dHlwZT5vaWQ8L3R5cGU+ICkKKyAg
ICAgICAgPHJldHVybnZhbHVlPmJpZ2ludDwvcmV0dXJudmFsdWU+CisgICAgICAgPC9wYXJh
PgorICAgICAgIDxwYXJhPgorICAgICAgICBSZXR1cm5zIHRoZSBudW1iZXIgb2YgYnVmZmVy
IGZldGNoZXMgZm9yIHRhYmxlIG9yIGluZGV4LCBpbiB0aGUgY3VycmVudCB0cmFuc2FjdGlv
bgorICAgICAgIDwvcGFyYT48L2VudHJ5PgorICAgICAgPC9yb3c+CisKKyAgICAgIDxyb3c+
CisgICAgICAgPGVudHJ5IHJvbGU9ImZ1bmNfdGFibGVfZW50cnkiPjxwYXJhIHJvbGU9ImZ1
bmNfc2lnbmF0dXJlIj4KKyAgICAgICAgPGluZGV4dGVybT4KKyAgICAgICAgIDxwcmltYXJ5
PnBnX3N0YXRfZ2V0X3hhY3RfYmxvY2tzX2hpdDwvcHJpbWFyeT4KKyAgICAgICAgPC9pbmRl
eHRlcm0+CisgICAgICAgIDxmdW5jdGlvbj5wZ19zdGF0X2dldF94YWN0X2Jsb2Nrc19oaXQ8
L2Z1bmN0aW9uPiAoIDx0eXBlPm9pZDwvdHlwZT4gKQorICAgICAgICA8cmV0dXJudmFsdWU+
YmlnaW50PC9yZXR1cm52YWx1ZT4KKyAgICAgICA8L3BhcmE+CisgICAgICAgPHBhcmE+Cisg
ICAgICAgIFJldHVybnMgdGhlIG51bWJlciBvZiBidWZmZXIgaGl0cyBmb3IgdGFibGUgb3Ig
aW5kZXgsIGluIHRoZSBjdXJyZW50IHRyYW5zYWN0aW9uCisgICAgICAgPC9wYXJhPjwvZW50
cnk+CisgICAgICA8L3Jvdz4KKwogICAgICAgPHJvdz4KICAgICAgICA8ZW50cnkgcm9sZT0i
ZnVuY190YWJsZV9lbnRyeSI+PHBhcmEgcm9sZT0iZnVuY19zaWduYXR1cmUiPgogICAgICAg
ICA8aW5kZXh0ZXJtPgo=

--------------DXh56tCQLAnlsgZM1OggGx5j--