Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRtwQ-001uqI-Bp for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jul 2024 13:34:34 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sRtwO-00EGxs-IO for pgsql-hackers@arkaria.postgresql.org; Thu, 11 Jul 2024 13:34:32 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRtwN-00EGxk-Qk for pgsql-hackers@lists.postgresql.org; Thu, 11 Jul 2024 13:34:32 +0000 Received: from fhigh3-smtp.messagingengine.com ([103.168.172.154]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sRtwK-001Xbu-Ev for pgsql-hackers@lists.postgresql.org; Thu, 11 Jul 2024 13:34:30 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id 46D6A1140395; Thu, 11 Jul 2024 09:34:27 -0400 (EDT) Received: from imap49 ([10.202.2.99]) by compute2.internal (MEProxy); Thu, 11 Jul 2024 09:34:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eulerto.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:subject :subject:to:to; s=fm3; t=1720704867; x=1720791267; bh=hUkWICoxio cLIRTguG8w0gqbbv8McEL1KEAurkbnwF4=; b=sKhlb3g5M92h9ZBHuSuwwV52Jb /cs1gPPLZDZpD/p7FLCjoZ1Fj87KbCXMOw8r7qei+uQ7x8W5oSPsSdS7/9u/9ppE YOmBFFt2ppLSYZuq5pSRtjhucFcBKBfrUG7x9mY00NzKoPxSCIsFMybXcyQ7/9lL m4jr189KpSkM6Luq9VLP5V3jaJarKc2nUnOcQznTBglffXarhxpg52ZzhdFjTCQh HFbgLZCVEV+SZGR89csKrmlsj+2HCc8IgqFn8FQmpxl31GV7p/SkSiVz5+EeGUjN NrgXM5vN/EO8sgRaOIWeyVBpht8IKQ3Zt6FDy9/9JyOW3i9cihavuDCNirzQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:subject:subject:to :to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1720704867; x=1720791267; bh=hUkWICoxiocLIRTguG8w0gqbbv8M cEL1KEAurkbnwF4=; b=lexu1r9oRgM+A1SKLFfnDKKIz65v+YAmzWDSCjIy4TQo HLQBPHdEfQLsJhu7NFmvlnb9RkGq80JyV0bkaCL0dzbmIhPRhNXzczfzcd13UE7K /pbznzWqqtz/CxBTPJepYtz11ELCPf5ahoGx0WNUlAq7BR3CwZA6ZAUBiRsaSMMo 9hFrwUNOsoQDtXc1kQtPwbNf+05uBhG9Ojy6/SeVVJZfq2NmW5/M6Xb4SdM5YLUr +iZKj36jwswcWBNo+KMOxAz6iemotHHOi2k6CeKzU1LEH7af+3/nqlOd68x1F8iG g0r/cFhGe00HL8z9TwT2mtWqR4oJCf4tNSMa4ODd7w== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrfeeggdeiiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgesrgdtreerreertdenucfhrhhomhepfdfguhhl vghrucfvrghvvghirhgrfdcuoegvuhhlvghrsegvuhhlvghrthhordgtohhmqeenucggtf frrghtthgvrhhnpefgffejvdeivdekvdeivdetudeikeduieevtdfhhfduvdetgeelteei ffekgefhvdenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluh hsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepvghulhgvrhesvghu lhgvrhhtohdrtghomh X-ME-Proxy: Feedback-ID: i0c21471d:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id E5E6E15A0092; Thu, 11 Jul 2024 09:34:25 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.11.0-alpha0-568-g843fbadbe-fm-20240701.003-g843fbadb MIME-Version: 1.0 Message-Id: <9ee2d69a-62e1-4a79-91b1-d65580b53547@app.fastmail.com> In-Reply-To: References: <9a9c7e65-c47b-4400-a63e-ac6169c0860e@app.fastmail.com> <2e86cf53-c806-49d2-9a10-1a1257776d1f@app.fastmail.com> <5da4b286-e570-4341-8262-92d763f6b1a4@app.fastmail.com> <776c5cac-5ef5-4001-b1bc-5b698bc0c62a@app.fastmail.com> <3c024250-3f13-4f4d-b8e9-55f176db4abf@eisentraut.org> <0dffca12-bf17-4a7a-334d-225569de5e6e@gmail.com> Date: Thu, 11 Jul 2024 10:34:04 -0300 From: "Euler Taveira" To: "houzj.fnst@fujitsu.com" , "Amit Kapila" , "Alexander Lakhin" Cc: "kuroda.hayato@fujitsu.com" , "pgsql-hackers@lists.postgresql.org" Subject: Re: speed up a logical replica setup Content-Type: multipart/alternative; boundary=50e01ed19305490ab78aa5a50f98400d List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --50e01ed19305490ab78aa5a50f98400d Content-Type: text/plain On Thu, Jul 11, 2024, at 8:22 AM, Zhijie Hou (Fujitsu) wrote: > The analysis and suggestion look reasonable to me. > Here is a small patch which does the same. LGTM. However, I would add a comment above the INSERT you moved around to remind you that a transaction cannot be added there because it will break this test. -- Euler Taveira EDB https://www.enterprisedb.com/ --50e01ed19305490ab78aa5a50f98400d Content-Type: text/html
On Thu, Jul 11, 2024, at 8:22 AM, Zhijie Hou (Fujitsu) wrote:
The analysis and suggestion look reasonable to me.
Here is a small patch which does the same.

LGTM. However, I would add a comment above the INSERT you moved around to remind
you that a transaction cannot be added there because it will break this test.


--
Euler Taveira
EDB   https://www.enterprisedb.com/

--50e01ed19305490ab78aa5a50f98400d--