MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Thu, 09 Jul 2020 21:59:32 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Daniel Gustafsson <daniel@yesql.se>, pgsql-hackers@postgresql.org
Subject: Re: [doc] modifying unit from characters to bytes
In-Reply-To: <8f9844a7-9cae-87c8-6d8a-02db264f7915@oss.nttdata.com>
References: <cd5b49a5a14e887542f5f569c1c6bde2@oss.nttdata.com>
 <df4c5cef-2f69-ca3c-60e2-c784c404f02d@oss.nttdata.com>
 <A96F46F3-65BB-4E1E-A423-8EE29729547F@yesql.se>
 <88056e7e-24a8-3beb-590d-03adeeb52111@oss.nttdata.com>
 <91282F61-9D45-45AC-8881-CCD15BD46246@yesql.se>
 <8f9844a7-9cae-87c8-6d8a-02db264f7915@oss.nttdata.com>
Message-ID: <9eefa8b88d42516d2027ff359aca9cb6@oss.nttdata.com>
User-Agent: Roundcube Webmail/1.1.9
Precedence: bulk

On 2020-07-09 13:47, Fujii Masao wrote:
> On 2020/07/08 17:12, Daniel Gustafsson wrote:
>>> On 8 Jul 2020, at 10:05, Fujii Masao <masao.fujii@oss.nttdata.com> 
>>> wrote:
>>> 
>>> On 2020/07/08 16:17, Daniel Gustafsson wrote:
>>>>> On 8 Jul 2020, at 04:25, Fujii Masao <masao.fujii@oss.nttdata.com> 
>>>>> wrote:
>>>>> 
>>>>> On 2020/07/08 10:54, torikoshia wrote:
>>>>>> Hi,
>>>>>> The manual describes the size of pg_stat_activity.query
>>>>>> as below:
>>>>>>   | By default the query text is truncated at 1024 characters;
>>>>>> When considering multibyte characters, it seems more
>>>>>> accurate to change the unit from "characters" to "bytes".
>>>>> 
>>>>> Agreed. Barring any objection, I will commit this patch.
>>>> +1 to commit this patch, following the link to 
>>>> track_activity_query_size it's
>>>> even specified to be bytes there.  IIRC the NULL terminator is also 
>>>> included in
>>>> the 1024 bytes which prevents it from being 1024 characters even for
>>>> non-multibyte.
>>> 
>>> Yes, so we should document "truncated at 1023 bytes" for accuracy, 
>>> instead?
>>> This might be more confusing for users, though....
>> 
>> I think that's overcomplicating things, since we do (will) specify 
>> bytes and
>> not characters.
> 
> Agreed. So I pushed the proposed patch. Thanks!

Thanks for applying!

Regards,


--
Atsushi Torikoshi
NTT DATA CORPORATION