Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTb3-0003Ey-Fu for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Sep 2022 02:18:21 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oWTb1-0007FM-M1 for pgsql-hackers@arkaria.postgresql.org; Fri, 09 Sep 2022 02:18:19 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTb1-0007F7-Cq for pgsql-hackers@lists.postgresql.org; Fri, 09 Sep 2022 02:18:19 +0000 Received: from oss.nttdata.com ([49.212.34.109]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWTay-0004J7-SW for pgsql-hackers@postgresql.org; Fri, 09 Sep 2022 02:18:18 +0000 Received: from oss.nttdata.com (localhost [127.0.0.1]) by oss.nttdata.com (Postfix) with ESMTPA id B44DD609DE for ; Fri, 9 Sep 2022 11:18:13 +0900 (JST) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.7 at oss.nttdata.com MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=_2f34f54913c0587cb88b8d413d4612fa" Content-Transfer-Encoding: 7bit Date: Fri, 09 Sep 2022 11:18:13 +0900 From: bt22kawamotok To: pgsql-hackers@postgresql.org Subject: [PATCH]Feature improvement for MERGE tab completion User-Agent: Roundcube Webmail/1.4.11 Message-ID: <9f1ad2a87a58cd5e7d64f3993130958d@oss.nttdata.com> X-Sender: bt22kawamotok@oss.nttdata.com List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --=_2f34f54913c0587cb88b8d413d4612fa Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed Hi! I created a patch for improving MARGE tab completion. Currently there is a problem with "MERGE INTO dst as d Using src as s ON d.key = s.key WHEN " is typed, "MATCHED" and "NOT MATCHED" is not completed. There is also a problem that typing "MERGE INTO a AS " completes "USING". This patch solves the above problems. Regards, Kotaro Kawamoto --=_2f34f54913c0587cb88b8d413d4612fa Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=fix_tab_complete_merge.patch Content-Disposition: attachment; filename=fix_tab_complete_merge.patch; size=1412 ZGlmZiAtLWdpdCBhL3NyYy9iaW4vcHNxbC90YWItY29tcGxldGUuYyBiL3NyYy9iaW4vcHNxbC90 YWItY29tcGxldGUuYwppbmRleCA2MmEzOTc3OWI5Li5lZDFmOGM1ZjE3IDEwMDY0NAotLS0gYS9z cmMvYmluL3BzcWwvdGFiLWNvbXBsZXRlLmMKKysrIGIvc3JjL2Jpbi9wc3FsL3RhYi1jb21wbGV0 ZS5jCkBAIC00MDY4LDcgKzQwNjgsNyBAQCBwc3FsX2NvbXBsZXRpb24oY29uc3QgY2hhciAqdGV4 dCwgaW50IHN0YXJ0LCBpbnQgZW5kKQogCS8qIHdpdGggW0FTXSBhbGlhcyAqLwogCWVsc2UgaWYg KFRhaWxNYXRjaGVzKCJNRVJHRSIsICJJTlRPIiwgTWF0Y2hBbnksICJBUyIsIE1hdGNoQW55KSkK IAkJQ09NUExFVEVfV0lUSCgiVVNJTkciKTsKLQllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0Ui LCAiSU5UTyIsIE1hdGNoQW55LCBNYXRjaEFueSkpCisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIk1F UkdFIiwgIklOVE8iLCBNYXRjaEFueSwgTWF0Y2hBbnkpICYmICFUYWlsTWF0Y2hlcygiQVMiKSkK IAkJQ09NUExFVEVfV0lUSCgiVVNJTkciKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hlcygiTUVSR0Ui LCAiSU5UTyIsIE1hdGNoQW55LCAiQVMiLCBNYXRjaEFueSwgIlVTSU5HIikpCiAJCUNPTVBMRVRF X1dJVEhfU0NIRU1BX1FVRVJZKFF1ZXJ5X2Zvcl9saXN0X29mX3RhYmxlcyk7CkBAIC00MDk1LDYg KzQwOTUsMTIgQEAgcHNxbF9jb21wbGV0aW9uKGNvbnN0IGNoYXIgKnRleHQsIGludCBzdGFydCwg aW50IGVuZCkKIAkJQ09NUExFVEVfV0lUSCgiV0hFTiBNQVRDSEVEIiwgIldIRU4gTk9UIE1BVENI RUQiKTsKIAllbHNlIGlmIChUYWlsTWF0Y2hlcygiVVNJTkciLCBNYXRjaEFueSwgTWF0Y2hBbnks ICJPTiIsIE1hdGNoQW55KSkKIAkJQ09NUExFVEVfV0lUSCgiV0hFTiBNQVRDSEVEIiwgIldIRU4g Tk9UIE1BVENIRUQiKTsKKwllbHNlIGlmIChUYWlsTWF0Y2hlcygiVVNJTkciLCBNYXRjaEFueSwg Ik9OIiwgTWF0Y2hBbnksICJXSEVOIikpCisJCUNPTVBMRVRFX1dJVEgoIk1BVENIRUQiLCAiTk9U IE1BVENIRUQiKTsKKwllbHNlIGlmIChUYWlsTWF0Y2hlcygiVVNJTkciLCBNYXRjaEFueSwgIkFT IiwgTWF0Y2hBbnksICJPTiIsIE1hdGNoQW55LCAiV0hFTiIpKQorCQlDT01QTEVURV9XSVRIKCJN QVRDSEVEIiwgIk5PVCBNQVRDSEVEIik7CisJZWxzZSBpZiAoVGFpbE1hdGNoZXMoIlVTSU5HIiwg TWF0Y2hBbnksIE1hdGNoQW55LCAiT04iLCBNYXRjaEFueSwgIldIRU4iKSkKKwkJQ09NUExFVEVf V0lUSCgiTUFUQ0hFRCIsICJOT1QgTUFUQ0hFRCIpOwogCWVsc2UgaWYgKFRhaWxNYXRjaGVzKCJX SEVOIiwgIk1BVENIRUQiKSkKIAkJQ09NUExFVEVfV0lUSCgiVEhFTiIsICJBTkQiKTsKIAllbHNl IGlmIChUYWlsTWF0Y2hlcygiV0hFTiIsICJOT1QiLCAiTUFUQ0hFRCIpKQo= --=_2f34f54913c0587cb88b8d413d4612fa--