Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hf0uA-0001fk-0x for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Jun 2019 11:43:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1hf0u7-0002t5-MN for pgsql-hackers@arkaria.postgresql.org; Sun, 23 Jun 2019 11:43:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hf0u7-0002rF-AJ for pgsql-hackers@lists.postgresql.org; Sun, 23 Jun 2019 11:43:27 +0000 Received: from mail-wr1-x42b.google.com ([2a00:1450:4864:20::42b]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hf0u3-0007mc-Hv for pgsql-hackers@lists.postgresql.org; Sun, 23 Jun 2019 11:43:26 +0000 Received: by mail-wr1-x42b.google.com with SMTP id k11so10884450wrl.1 for ; Sun, 23 Jun 2019 04:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:openpgp:autocrypt:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gNRQ3Od6B8FyHtP9jM7ytiuUapgoV2XxtnOZD1lF3dM=; b=rp3XncBnfmFrD6Y0ZKQmIS8figkRG0XII9CiHv3i3KPqiUMY2i3bMrRgFB1bLDyI9K Qfsi4uvm8U6bmD+sJ8Pjryg1eiN7rU+XFVojZWwXgE4DFrHE6yKRtJhwUFFKA1XgDQ8r GoWL8tiHu0cZSP7hbcMYFJaAxMQs+X2NP+Oy5hZWEl+02yXPMeW+peTjnf/rLiNGTd3P pX+du+JliyAL29slFZW+d8zTGYLnsjzCmuZ/w1lelKJsgmWQRs/fpbgBGsLl06H9gk9T kMcoUOZjnAEjNAzqD/nk/1UF646VNoZn4WqNNz1BycQ/uu7Kf0YPCvbrRbfl3bO+Uevh kZcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :organization:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=gNRQ3Od6B8FyHtP9jM7ytiuUapgoV2XxtnOZD1lF3dM=; b=mcl4kkGDt+5rgx4TH2312WzEip6ReyDT6CeC9rAC1hd51AF2kgLRt05pQpXXB2GOcx doWfT+vqQRy7/3YlnWCPU2lHe/POuaVLka9ZpK7S0CxZppWlUmOYMwpXkujPJ2BKjEGu mC59zAz/cPWDULwihtgODwUakj7qRznwsZraVhsN1GVyJFNAiAIr4WK8+svMUxPtyGzI G0g+S9SsYVEDujwbUyjWQqsSC4jRLWsNFpEMtd2Pq2okMl3YhYDt0Q+CeJQr5aSu+bbz Ly2pmPthl1lKxjZIAa63od5X3FVwzUN/Cgst/Q7UFXn4yJifZH3JB0bv4LzoqoOJ1HQU jL1A== X-Gm-Message-State: APjAAAWZzOVp4XVeVD81tGlILx9AQFvVSB0NO/V7t4lcFrgXm1vapcxc lRra2Bdmkq24qQdEisJIIH/1On+1C1/vqXBvE9RfP4tlY/X2bbQIjAF7twzPAqgU1UzkK62qOQf DYv4ek07iXTYlo+vxkfRuto4b89l5a0dYcr1BB2npjz45DLVW/s3yKDETPshMp7IdDZlFrCWtEv 8V+8su5mhUG6fahHRE1fBO X-Google-Smtp-Source: APXvYqwHnDinSAKtKmqVnZHe4q64WUirjnrwpbJj2rAis43NE7ckBcRn2ESvHJQouZb0eE91/Y3G5Q== X-Received: by 2002:a5d:5283:: with SMTP id c3mr22428506wrv.268.1561290202232; Sun, 23 Jun 2019 04:43:22 -0700 (PDT) Received: from [192.168.0.3] (ath91-3-88-167-161-184.fbx.proxad.net. [88.167.161.184]) by smtp.gmail.com with ESMTPSA id l8sm17576952wrg.40.2019.06.23.04.43.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 23 Jun 2019 04:43:21 -0700 (PDT) Subject: Re: Code comment change To: Thomas Munro Cc: PostgreSQL Hackers References: <150d3e9f-c7ec-3fb3-4fdb-def47c4144af@2ndquadrant.com> From: Vik Fearing Openpgp: preference=signencrypt Autocrypt: addr=vik.fearing@2ndquadrant.com; prefer-encrypt=mutual; keydata= mQINBFg9q8kBEADfBQMKbYmvL7k4D4ghRYon0lMRf9c+dADesMGsBh5SYTK1/t4S4iCfbc8d QUCyJWSiJYkT1MZNSywbr3hNahZ7qAN0y4kvGNUIxXJGcza5qH5gHQYFrpB/IDoZcZ5/l260 Y5roqQos7kimpALNrl2cXWkR98Z9FWZOocImzdBnKV+qHzD9ZCPISPqR92N67gPqLD4YNx5Y T4NkT2N2nYZlyvv6X3t5/haLWpSLTJ/7ESD6jwTs7Ok4meLidSqr8U25p/L4mb+pscR6l5Hq aJXagW9oQ0uI50Wlri1GeE/JTqaURxfOCWBE3RzrRdhH0HYMOz49gLqba0s4eBlMw18R0OWt TD4mRnpD41X4aaSrMEqm2xXZAa8T+UFlQXWliMvFJ4rQhAogPLN9yI93FDy5pqJdtu3T/mJu HycJfiJHtgGVP8bsMQdg5X4kNWO2LnerJQiO+cYambgb5RWBS3byjO8f05sIXQxIR1nLdGEY 7Cy5/eIN6+qRA3kpRjfQ2QOlEKxVWNLu9t+xGphRi6TidZWnhHRwfCkeelR9R4niubLQPirl /XvToUtm0opXBHbVxTVblM0i7z+x9tnQUCa1f710pnJ/LRqE2Se/JPbEeg5JH4MLLGdr8uxf fv9E8dJVvmTRIWOJFNFnd9e3b9K6I/ek+ysVFsNrKnP9dS4R0QARAQABtCBWaWsgRmVhcmlu ZyA8dmlrQDJuZHF1YWRyYW50LmZyPokCPQQTAQgAJwUCWD2ryQIbIwUJCWYBgAULCQgHAgYV CAkKCwIEFgIDAQIeAQIXgAAKCRBzOWT4unEhz0W+D/0ZqG/7SmWxSPSm3IcwQaGvxKIE/XFv jZ5USS6W1U/Ttq8qXnJbWOTzEKl6NVQcAuAIAYdvOjwrDDR9SMSMPvHmd7LniOZ4/+V2rdLj fOXzExI+1yJ1TYv1pGTgt5ZmjARIvge942iEYHQey5pavoNI1/C9V0RLuh2yS6dLax21295V OFOhQD11mDJLJ8c/ILVpadqt90V9bQzBWycPOjnwjhxD4kVXMjihnl54EuMp08UW6OTCP4ux /SxJFfTM1WDr+GDk7RgsG3bJfwftdUP2Qc8drwu0LAT41edmaigFGM1RMKeBWeo5Tdcm/Wmo uDeLJwL+CGvEZEjNrLxoXBhuRcv+9m5eYOafqewKgZXTmeZImbk75Jp502LCQHXhdatr9O8a KKjmkKqz+uPOV+4qsvqXdMCCFWb15/Pd/a8ffPMRwq6ebDOPYXJUkGqc65tSlf0gRxfIKof3 gO3TevZ0U1nc7kBa/QNe2QN6RC24+GbyJNEvQ6g2ZbBddffiuYZElsGM3+yiM6jz2RWG4uLQ /Qjw6ZwhNUCOepVa3SsLkSE0HN2M2emN8exQIdJw37IiKIsZPPFa+J3netLfXB4F+/BnwVqK GW8eaLYQWQYRBPTMKgLCqGDCgNIB8cVG7zmx7zYDPXNEwKPfcGSkixfQJxgq1InWDyVg2qwU TP0iVLkCDQRYPavJARAAsdzHCSxLnqy1UW0qNhJoZaIkSbQQ6Bjqgfo4KZKvt2eBe363ubgw 5j6VCfpBpOSJYQrOadY7GOKw0m8iwtr1bvrNg/7SoqfwoKLBTvuxo5WsUD9e8f/Hy1CoMz/3 o1qAvBiQK+MnZvmgtwvwqWpx/g+H2uH8aPttNC1x9lO866o4JtoVWumi01si6KKjO+ZNazPi n9a0JW4OVeLxhIy0OnrE4KMOrnHZlJPIdGP36dtFMK9tyqQ3z3zOp/HN+3mrQZAphH/2idLK wRZURPpisvy3HES9yN/JAWtPEYB0OAhKGJhgLDue08zM8FRNa5ldc/oJCqMEC8D5bh6g3LCz uIM11hOMD8OJNX1lGnzdicBLMghUfhtAJ+KfBGqIG3hLxzYp8RiIfG/HJyA6dhqpxG3y6yjO 0r24THuXceW7ygqQUB+J2KK8B1iWTwiMBvvIav9tOQTcYkU+EFtN7zwkC3aN2HV8I7QLDUWw OyWZ1+J1ff3xyCjMhZ0SaBV8kUy981RE8lnmy/T6lE9iFfj2roSkCLcUkODb9mz1BSeg7l1J yRGqQ2ypxS3l77h+JC1SMRrDUz1vFIIAuvQEjJgnV5JUjmNi/0s+/HQU8YRlQWERSH9pHwFL ZgSwH5hqCLFjiGLxxHqJ4JZLoP7J1I5tpuUkbVPhreRNNZ9ro0Wtd9cAEQEAAYkCJQQYAQgA DwUCWD2ryQIbDAUJCWYBgAAKCRBzOWT4unEhz2qgD/95NfvOedTfZ2P0hXTHlE0oGL9pIP21 dOng/fJT1yc4nA4MfNV3Hf72Gpw/XLpnMgovanqj+15ZyFPirCaB9lCjEiorzSsLN9k0I1OC +gIbouFHgYo3nzeRJf/hMlAzef7sqjuD5WyI7miMeaKXkjTGyjC39xX2nq5EHCI8V/uBtT94 3cyZmCrEl64AKjlnFfkNKhlYWpfDWSVSxz79QAIw0wW4ILNFfAp3z4DPjqGut98XBlmtQlDj RMlqeUHDIGLQjKNmxH95vbTS9eAFom6jA99Bl4nWCWUYHoGA/y7Ov6z9vQwqkJ4WqPMg+mas 7nZNQiexBj3tG5pRU2M7NURnaLiINFXid+kjKmNEUgNyd0haIqiIRtkRWZ2zvAwfudS7HDq1 RB6GWGHtJrVFRIkgs3gBoyPz3kSwlYieid6Ywquxd3dQqkN6cdlnvt2uossgRnqXx5HugP81 Faadir4t4t6HqoLHynzvvT9fMijT//O6Fb0MFqZP2rf3i7zh7/rwtpdxI2m/SbTJgvMqlvGn riBgDbjEz8XNMGqMk/WPNcKkk8prCPta9ltMl7yd3LqzCG6KRz7TtQae25BcBF1IKobZYbgf qc5fRxkCHCy6IDu70pve2tt1hzvZquE2Z5uTMFp2k213HJQKklY/jAOmVhM2O2T2oSaKAr1u MUmXcw== Organization: 2ndQuadrant France Message-ID: <9f75b541-04eb-8de4-29aa-600476f88caa@2ndquadrant.com> Date: Sun, 23 Jun 2019 13:43:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 23/06/2019 12:35, Thomas Munro wrote: > On Sun, Jun 23, 2019 at 9:21 PM Vik Fearing wrote: >> There is some language in a code comment that has been bothering me for >> several years now. After pointing it out in a conversation off-list >> recently, I figured it was past time to do something about it. >> >> Patch attached. > > Pushed. Thanks! Thank you! -- Vik Fearing +33 6 46 75 15 36 http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support