Message-ID: <9fc78855-bce0-463f-a045-892ee3e142f5@iki.fi>
Date: Fri, 15 Mar 2024 17:56:14 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Weird test mixup
Content-Language: en-US
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <10fd6cdd-c5d9-46fe-9fa1-7e661191309e@iki.fi>
 <2387221.1710454778@sss.pgh.pa.us> <ZfOABU4ahF2QZQ6N@paquier.xyz>
 <2393552.1710458033@sss.pgh.pa.us>
 <44f5bf13-b46e-4b87-84de-2ac70fddbda0@iki.fi>
 <8e4cf596-dd70-432e-9068-16466ed596ed@iki.fi>
 <2498595.1710511222@sss.pgh.pa.us>
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <2498595.1710511222@sss.pgh.pa.us>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/9fc78855-bce0-463f-a045-892ee3e142f5%40iki.fi>
Precedence: bulk

On 15/03/2024 16:00, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
>> On 15/03/2024 13:09, Heikki Linnakangas wrote:
>>> I committed a patch to do that, to put out the fire.
> 
>> That's turning the buildfarm quite red. Many, but not all animals are
>> failing like this:
> 
> It may be even worse than it appears from the buildfarm status page.
> My animals were stuck in infinite loops that required a manual "kill"
> to get out of, and it's reasonable to assume there are others that
> will require owner intervention.  Why would this test have done that,
> if the module failed to load?

The gin_incomplete_split test inserts rows until it hits the injection 
point, at page split. There is a backstop, it should give up after 10000 
iterations, but that was broken. Fixed that, thanks for the report!

Hmm, don't we have any timeout that would kill tests if they get stuck?

-- 
Heikki Linnakangas
Neon (https://neon.tech)