public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Fujii Masao <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Fix pg_stat_progress_data_checksums counter initialization
Date: Fri, 10 Jul 2026 10:29:15 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHGQGwEOQyEzW2cqrHEzvwbcsAsuH8MEe7MMidFOFxECy0E1_Q@mail.gmail.com>
References: <CAHGQGwEOQyEzW2cqrHEzvwbcsAsuH8MEe7MMidFOFxECy0E1_Q@mail.gmail.com>

> On 10 Jul 2026, at 09:13, Fujii Masao <[email protected]> wrote:

> The attached patch fixes this by initializing all data checksum progress
> counters to -1 immediately after progress reporting starts for both
> launcher and worker processes.
> 
> While looking at this code, I also found that blocks_done is not reset
> when a worker starts processing a new relation fork. As a result,
> blocks_done can temporarily exceed blocks_total, or a stale blocks_done
> value can remain visible for an empty relation fork. The attached patch
> resets blocks_done together with blocks_total when starting each
> relation fork.

LGTM, thanks!

--
Daniel Gustafsson

view thread (13+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Fix pg_stat_progress_data_checksums counter initialization
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox