Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQw5m-0001Sa-Mv for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Aug 2023 20:35:42 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qQw4m-00055V-Oo for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Aug 2023 20:34:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQw4m-00053i-Bd for pgsql-hackers@lists.postgresql.org; Tue, 01 Aug 2023 20:34:40 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qQvzQ-0000JG-BN for pgsql-hackers@lists.postgresql.org; Tue, 01 Aug 2023 20:29:09 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id D0BA52FA2108 for ; Tue, 1 Aug 2023 22:29:06 +0200 (CEST) Received: from s934.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id BFF5F2E2F4EC; Tue, 1 Aug 2023 22:29:06 +0200 (CEST) Received: from s476.loopia.se (unknown [172.22.191.6]) by s934.loopia.se (Postfix) with ESMTP id BB9237CEAC5; Tue, 1 Aug 2023 22:29:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s979.loopia.se ([172.22.191.6]) by s476.loopia.se (s476.loopia.se [172.22.190.16]) (amavisd-new, port 10024) with LMTP id Qf-ZCUe_5hEc; Tue, 1 Aug 2023 22:29:06 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 81.236.183.12 Received: from smtpclient.apple (81-236-183-12-no272.tbcn.telia.com [81.236.183.12]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id 1CE3310BC36A; Tue, 1 Aug 2023 22:29:06 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: explain analyze rows=%.0f From: Daniel Gustafsson In-Reply-To: Date: Tue, 1 Aug 2023 22:29:05 +0200 Cc: "Gregory Stark (as CFM)" , Tom Lane , Robert Haas , Amit Kapila , Justin Pryzby , Peter Geoghegan , vignesh C , "David G. Johnston" , pgsql-hackers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <20220707222015.GD13040@telsasoft.com> <2954811.1667711530@sss.pgh.pa.us> To: Ibrar Ahmed X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 3 Jul 2023, at 18:34, Daniel Gustafsson wrote: >=20 >> On 8 Jun 2023, at 19:49, Ibrar Ahmed wrote: >> On Mon, Mar 20, 2023 at 7:56=E2=80=AFPM Gregory Stark (as CFM) = > wrote: >=20 >> This patch was marked Returned with Feedback and then later Waiting = on >> Author. And it hasn't had any updates since January. What is the = state >> on this feedback? If it's already done we can set the patch to Ready >> for Commit and if not do you disagree with the proposed changes? >>=20 >> If there is a consensus to modify the test cases' output, I am = willing to >> make the necessary changes and adjust the patch accordingly. However, >> if there is a preference to keep the output of certain test cases = unchanged, >> I can rebase and modify the patch accordingly to accommodate those = preferences. >=20 > As there hasn't been any other comments I suggest updating your patch = to > address Tom's comments to see if we can make progress here. Since there hasn't been any updates here, and the thread has been = stalled, I'm marking this returned with feedback. Please feel free to resubmit a = version of the patch addressing comments to a future CF. -- Daniel Gustafsson