Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jr0Rh-0004a8-Kk for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Jul 2020 14:44:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1jr0Rg-0007uz-Jj for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Jul 2020 14:44:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jr0Rg-0007us-Cp for pgsql-hackers@lists.postgresql.org; Thu, 02 Jul 2020 14:44:12 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jr0Re-0002jb-I7 for pgsql-hackers@postgresql.org; Thu, 02 Jul 2020 14:44:12 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 6EDA730A80EA for ; Thu, 2 Jul 2020 16:44:09 +0200 (CEST) Received: from s630.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 4D1DB2E28DC8; Thu, 2 Jul 2020 16:44:09 +0200 (CEST) Received: from s472.loopia.se (unknown [172.22.191.5]) by s630.loopia.se (Postfix) with ESMTP id 1A62F13ABFA2; Thu, 2 Jul 2020 16:44:09 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s500.loopia.se ([172.22.191.6]) by s472.loopia.se (s472.loopia.se [172.22.190.12]) (amavisd-new, port 10024) with LMTP id qWplwfFvG0F3; Thu, 2 Jul 2020 16:44:08 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 94.234.33.184 Received: from [192.168.1.100] (c-5eea21b8-74736162.cust.telenor.se [94.234.33.184]) (Authenticated sender: daniel@yesql.se) by s500.loopia.se (Postfix) with ESMTPSA id B81B21E1479B; Thu, 2 Jul 2020 16:44:07 +0200 (CEST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Subject: Re: Built-in connection pooler From: Daniel Gustafsson In-Reply-To: Date: Thu, 2 Jul 2020 16:44:07 +0200 Cc: David Steele , "ideriha.takeshi@fujitsu.com" , Jaime Casanova , Tomas Vondra , Ryan Lambert , Thomas Munro , PostgreSQL Hackers , Bruce Momjian , Dimitri Fontaine , Alvaro Herrera Content-Transfer-Encoding: quoted-printable Message-Id: References: <20190925201404.GA23270@alvherre.pgsql> <307bab45-7b5e-909a-72e0-965901ecf87a@postgrespro.ru> <7f34257f-3dbe-2361-122d-1c9ba33c1bdc@postgrespro.ru> <3edbc4d2-ebe8-d73f-a3f4-e043bc504f17@pgmasters.net> To: Konstantin Knizhnik X-Mailer: Apple Mail (2.3445.104.14) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk > On 2 Jul 2020, at 13:33, Konstantin Knizhnik = wrote: > On 01.07.2020 12:30, Daniel Gustafsson wrote: >>> On 24 Mar 2020, at 17:24, Konstantin Knizhnik = wrote: >>> Rebased version of the patch is attached. >> And this patch also fails to apply now, can you please submit a new = version? >> Marking the entry as Waiting on Author in the meantime. >>=20 >> cheers ./daniel > Rebased version of the patch is attached. Both Travis and Appveyor fails to compile this version: proxy.c: In function =E2=80=98client_connect=E2=80=99: proxy.c:302:6: error: too few arguments to function = =E2=80=98ParseStartupPacket=E2=80=99 if (ParseStartupPacket(chan->client_port, chan->proxy->parse_ctx, = startup_packet+4, startup_packet_size-4, false) !=3D STATUS_OK) /* skip = packet size */ ^ In file included from proxy.c:8:0: ../../../src/include/postmaster/postmaster.h:71:12: note: declared here extern int ParseStartupPacket(struct Port* port, MemoryContext memctx, = void* pkg_body, int pkg_size, bool ssl_done, bool gss_done); ^ : recipe for target 'proxy.o' failed make[3]: *** [proxy.o] Error 1 cheers ./daniel=