Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.600.51.1.1\))
Subject: Re: Fix bug of UPDATE/DELETE FOR PORTION OF with inheritance tables
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CA+renyV6BS+cUxAbxB1X-bBn8+9NDEwRah8pSD_EVdhtb1TcUA@mail.gmail.com>
Date: Tue, 26 May 2026 14:55:01 +0800
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A6C9443A-1F61-4172-8A9A-5ECED30AB8BF@gmail.com>
References: <4245F94D-84F1-4E05-BF81-C458A6CF9901@gmail.com>
 <260A544F-FBD6-40CC-9449-5987049DD2D4@gmail.com>
 <CA+renyV6BS+cUxAbxB1X-bBn8+9NDEwRah8pSD_EVdhtb1TcUA@mail.gmail.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Archived-At: 
 <https://www.postgresql.org/message-id/A6C9443A-1F61-4172-8A9A-5ECED30AB8BF%40gmail.com>
Precedence: bulk


> On May 26, 2026, at 07:01, Paul A Jungwirth =
<pj@illuminatedcomputing.com> wrote:
>=20
> On Fri, May 8, 2026 at 10:48=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>=20
>>> On May 7, 2026, at 11:40, Chao Li <li.evan.chao@gmail.com> wrote:
>>> After looking into the code, I found that leftover row insertion =
only considers the partitioned-table case, where leftovers need to be =
inserted through the root relation for partition routing. Plain =
inheritance is different, leftover rows should be inserted back into the =
actual child relation.
>>>=20
>>> While debugging this, I also noticed another issue around mapping =
the range column=E2=80=99s attnum. In multiple-inheritance cases, the =
range column=E2=80=99s attnum in a child table may be different from the =
one in its parent, so we need to use the child=E2=80=99s actual attnum.
>>>=20
>>> Please see the attached patch for the fix details and the new tests. =
Since I believe this bug was introduced in 19, I=E2=80=99m going to add =
it to the open items.
>>>=20
>>> Best regards,
>>> --
>>> Chao Li (Evan)
>>> HighGo Software Co., Ltd.
>>> https://www.highgo.com/
>>>=20
>>>=20
>>>=20
>>>=20
>>> <v1-0001-Fix-FOR-PORTION-OF-leftovers-for-inheritance-chil.patch>
>>=20
>> Merged into [1].
>>=20
>> [1] =
https://postgr.es/m/CAHg+QDcd=3Dt69gLf9yQexO07EJ2mx0Z70NFHo6h94X1EDA=3DhM0=
g@mail.gmail.com
>=20
> Here is a new patch for this. I don't think it makes sense to combine
> it with the other fix anymore.
>=20
> Per [1], we are now checking for UPDATE permission on the FOR PORTION
> OF column, so most of that other patch went away, and the fix here can
> be done independently. That's what v2 here does. I didn't really
> change anything from the v12-0002 patch on that other thread, except
> for moving some tests into the other patch (since they had nothing to
> do with traditional inheritance). The patch here now passes, whether
> applied to master directly or applied on top of v13 from the
> updatedCols fix. (Combining them will give a rebase conflict in the
> test files, but it's pretty trivial to fix.)
>=20
> [1] =
https://www.postgresql.org/message-id/CA%2BrenyXyLfvtvVv--hGWGTgzFP%3D-%2B=
dPLy4RWvEmioAPyJMM%2Buw%40mail.gmail.com
>=20
> Yours,
>=20
> --=20
> Paul              ~{:-)
> pj@illuminatedcomputing.com
> <v2-0001-Fix-FOR-PORTION-OF-with-partitions-and-inheritanc.patch>

Now v2 mixes two separate changes:

1) Adding ExecInitForPortionOf() to address the UPDATE OF trigger issue
2) Fixing the inheritance/leftover bug originally reported in this =
thread

I=E2=80=99d prefer not to combine these in a single patch. Could you =
please split out the refactoring that adds ExecInitForPortionOf() into a =
separate patch, with tests showing that the UPDATE OF trigger issue is =
fixed? Then I can rework my inheritance/leftover fix on top of that.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/