Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wLBy4-001bNj-0s for pgsql-hackers@arkaria.postgresql.org; Fri, 08 May 2026 03:33:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wLBy3-007Swg-0d for pgsql-hackers@arkaria.postgresql.org; Fri, 08 May 2026 03:33:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wLBy2-007SwY-2x for pgsql-hackers@lists.postgresql.org; Fri, 08 May 2026 03:33:34 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.98.2) (envelope-from ) id 1wLBy0-000000018nY-2v03 for pgsql-hackers@postgresql.org; Fri, 08 May 2026 03:33:34 +0000 Received: by mail-pj1-x1030.google.com with SMTP id 98e67ed59e1d1-36608b2f2dcso892130a91.2 for ; Thu, 07 May 2026 20:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778211210; x=1778816010; darn=postgresql.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=IRguXJdbe/d3Qd0RoGpPI3r9N81dizGlgdKp0ete3es=; b=jczEnFS/M0JbOOwUUFKsjhN9ghPYfZP+WmvWwuazFdU2NnV2/6sYMMhRKyX/i373JN XXTC+OvJWf6kahVARBzWk0Bb3KTyPYJHtlQh7vSw+nli6NS2ljhqoTsOhREZSuJsczly E+T7I6PMXZkjo1gYKS9/tlWyBqjUEij+qW+/NDs0mSpWKq/NvRPBklxsxdh61EOS+iJz I3ULIz7Bj0nPAJlo7zB1Vg6EsehJ7XWtjr9doXJHZn6q69m6JM3WEKuRr9D2X9+qowtl UImVlA1f6JnPGdnF+25sHGN/WIfH/+m8HwwWEan6CKtrhuvguHdEitAMIpra7hZ3nUuj gWSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778211210; x=1778816010; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=IRguXJdbe/d3Qd0RoGpPI3r9N81dizGlgdKp0ete3es=; b=iCIPMhe9gn7p96vHWSW/3R41WVsz9QreJ2b0y219vXGh4Q/PsVIIneWWVt8Li2pEZY sYWygvL60BPnLcbuvF2WnMO2lfU8OFV76jEq/P1xz1VNKlvBZkjDRQuu8A9ozDyQRU6z tOq3S0DE4vGl17Mub1/adeQBjjoBJlIxWfvU0DvQsTTeX9D+ucfA5Unq4cR7xK9XlMYr +s2JrB3iGo66t8UPkaUhCxqmEDnopnIGNPiNABh6O6kdJQIHzqe/e3wrXMKd3K4yn2MU sHHq5TCKcaodFuJ2/fnQ/zvkUZA0A8I12OlaCHfPOnhpVFjSh9jzbDAm+jnqnpme5GTJ w4/A== X-Forwarded-Encrypted: i=1; AFNElJ+WDkbt4SpiSipFtfJo/TXMoUrhUYvctKdyqsxHAXj+YSVjABSsmpofFDJvIZNMJlIwmvOyszLFIMCAfrk8@postgresql.org X-Gm-Message-State: AOJu0YzthOEZ3JMNtubwoPUeqPGV5abCBssbNJtg2PXj4PfwzBfnTL/t mCIZEBE+9yAK9SthOeCsvCajcL8hu6g3gT4BmbdDLEYgCjY7UO1WGLam X-Gm-Gg: Acq92OFwVK6GiEsNAqf87E9ZcmTUyI2xAZaF2TEbFGULYHYuAcyOkQzsB4+ReFyr1FM Mysnic59wEbgRCrv2wJrGe0tCp4YKLOvGLldTMcul2o4iNneiBRWKboP4+ZJ6fRml6If06Yq7bj QRSWMqhfWYcdv+1tkjiRWdZrRD2AdjZWu/lPu9cIJQdtcm1twOLYFDDgYQgguvQ4L22U4OqrqFJ H9pCFhPXqm+fYa5iKJnUpf6PREoYnrWVoEU/sUwBug8hkUJH2vxu3fQCHUReITYOfqjhnzKOlg6 btam5RtM95qpFpZg0wysLVkT/Y3Ftw89n8vECqMEzK+LtvhXfEdBeCBk/dL8DuYStR09YwXJj8p 7VaBkyyl2nXf8/1MXPTbzfPg5YaRiViOD80VuXgsl3f1GLGOuo4K90VHxrTsptNbIpKmqGfvYQY XFY2Br0mWtLVp3RsTa7fHQTYxuL4yDnic= X-Received: by 2002:a17:90b:2e49:b0:365:5690:f25f with SMTP id 98e67ed59e1d1-365ac47d1c4mr10095918a91.20.1778211210310; Thu, 07 May 2026 20:33:30 -0700 (PDT) Received: from smtpclient.apple ([45.32.121.103]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36645c53693sm386115a91.4.2026.05.07.20.33.28 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 07 May 2026 20:33:29 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: Call EndCopyFrom() after initial table sync in logical replication From: Chao Li X-Priority: 3 In-Reply-To: Date: Fri, 8 May 2026 11:32:50 +0800 Cc: Fujii Masao , Shinya Kato , PostgreSQL-development Content-Transfer-Encoding: quoted-printable Message-Id: References: To: cca5507 X-Mailer: Apple Mail (2.3864.400.21) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On May 8, 2026, at 10:34, cca5507 wrote: >=20 > Hi, >=20 > Maybe we want to add "free_parsestate(pstate);" after the = "EndCopyFrom()" as well? >=20 I agree. While here, looks like attnamelist can also be freed. Best regards, -- Chao Li (Evan) HighGo Software Co., Ltd. https://www.highgo.com/