Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Fix unsafe PlannedStmt access in pg_stat_statements
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <agP9fFXriRN1HR5k@paquier.xyz>
Date: Wed, 13 May 2026 13:31:01 +0800
Cc: Andres Freund <andres@anarazel.de>,
 pgsql-hackers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A90FA5E9-ECB2-4AF7-B487-EA9C89B04091@gmail.com>
References: <2F91906A-F2B5-4A6B-9695-D136957D4545@gmail.com>
 <CE0E4BE8-2180-46CB-9D3C-6F42D145AB3D@gmail.com>
 <agKe7cS_I-60GlpD@paquier.xyz>
 <0A9A8DAC-BC3C-4C7A-9504-2C6050405544@anarazel.de>
 <agP9fFXriRN1HR5k@paquier.xyz>
To: Michael Paquier <michael@paquier.xyz>
Archived-At: 
 <https://www.postgresql.org/message-id/A90FA5E9-ECB2-4AF7-B487-EA9C89B04091%40gmail.com>
Precedence: bulk


> On May 13, 2026, at 12:26, Michael Paquier <michael@paquier.xyz> =
wrote:
>=20
> On Tue, May 12, 2026 at 11:00:16AM +0200, Andres Freund wrote:
>> Seems like the code should make this clearer, by simply unsetting
>> pstmt at the point it becomes unsafe to use?
>=20
> Sure, we could do that as well and crash hard if something decides to
> do the same mistake.  Like the simple patch attached for example?  I
> am not sure if we need to update the comment.  It's pretty clear what
> the intention is, at least to me.
> --
> Michael
> <pgss-pstmt.patch>

Yeah, this is the exactly same change I was about to reply. And I agree =
the current comment is clear enough, no more needed to add.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/