Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: reporting TID/table with corruption error
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: 
 <CAH2-Wz=wiEJ85m+KoXcHw2eEuFo1zyAmnL2v+ZW6ubWq3toeRQ@mail.gmail.com>
Date: Thu, 19 Aug 2021 11:19:36 -0700
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
 Alvaro Herrera <alvherre@alvh.no-ip.org>,
 Pg Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AADA126D-5757-4D2F-B988-725CE50806E8@enterprisedb.com>
References: <202108191637.oqyzrdtnheir@alvherre.pgsql>
 <CAH2-WzmCLNK09r_C+A9ZxmmdZ2AjgDGyCJjVYWBun2LUws_gJw@mail.gmail.com>
 <924415DA-A514-4B67-AC66-E3D6C5F13F89@yandex-team.ru>
 <F412B035-AF83-40C6-BA0A-4C7AA810091E@enterprisedb.com>
 <CAH2-Wz=wiEJ85m+KoXcHw2eEuFo1zyAmnL2v+ZW6ubWq3toeRQ@mail.gmail.com>
To: Peter Geoghegan <pg@bowt.ie>
Archived-At: 
 <https://www.postgresql.org/message-id/AADA126D-5757-4D2F-B988-725CE50806E8%40enterprisedb.com>
Precedence: bulk


> On Aug 19, 2021, at 10:57 AM, Peter Geoghegan <pg@bowt.ie> wrote:
>=20
> High
> verbosity makes a lot of sense here.

Works for me.  We could create another function, "verify_heapam_full" =
perhaps, that returns additional columns matching those from =
pageinspect's heap_page_items():

    OUT lp smallint,
    OUT lp_off smallint,
    OUT lp_flags smallint,
    OUT lp_len smallint,
    OUT t_xmin xid,
    OUT t_xmax xid,
    OUT t_field3 int4,
    OUT t_ctid tid,
    OUT t_infomask2 integer,
    OUT t_infomask integer,
    OUT t_hoff smallint,
    OUT t_bits text,
    OUT t_oid oid,
    OUT t_data bytea

Should it also return the full page?  That would be quite verbose (an =
extra 8k per row), but it could be fed into any of pageinspect's =
functions for further analysis.

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company