Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.1\))
Subject: Re: Converting pqsignal to void return
From: Paul Ramsey <pramsey@cleverelephant.ca>
In-Reply-To: <a33wjek7umo5gjzaj7guyi5qucg4i6ho7to6r7wardtvggpyxu@ddrzklqt5f3x>
Date: Wed, 22 Jan 2025 09:01:09 -0800
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Nathan Bossart <nathandbossart@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <AD9CFCF4-B2AD-4138-8E69-76DB068873A3@cleverelephant.ca>
References: <4E796D56-79B5-4447-9DA7-5428BC1A6B53@cleverelephant.ca>
 <a33wjek7umo5gjzaj7guyi5qucg4i6ho7to6r7wardtvggpyxu@ddrzklqt5f3x>
To: Andres Freund <andres@anarazel.de>
Archived-At: <https://www.postgresql.org/message-id/AD9CFCF4-B2AD-4138-8E69-76DB068873A3%40cleverelephant.ca>
Precedence: bulk


> On Jan 22, 2025, at 8:50=E2=80=AFAM, Andres Freund =
<andres@anarazel.de> wrote:
>=20
>> It is possible we have been Doing It Wrong all this time, and would =
love some pointers on the right way to do this.
>=20
> All your interrupt handler is doing "for you" is setting
> http_interrupt_requested, right?  Why do you need that variable? Seems =
you
> could just check postgres' QueryCancelPending? And perhaps =
ProcDiePending, if
> you want to handle termination too.

This is the Knowledge that was sitting right in front of me, but I could =
not see.
=46rom the road to Damascus,
Paul