public inbox for [email protected]  

help / color / mirror / Atom feed

From: Daniel Gustafsson <[email protected]>
To: Robert Haas <[email protected]>
Cc: Justin Pryzby <[email protected]>
Cc: Mikhail Gribkov <[email protected]>
Cc: [email protected]
Subject: Re: GUC for temporarily disabling event triggers
Date: Mon, 3 Apr 2023 23:35:14 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CA+TgmoZDjc04aPD0LM4LKZ_GstggvAzxmmhWdeX0iHrnC1V2Yg@mail.gmail.com>
References: <[email protected]>
	<CALte62x7c9R0ohKcQSr5N9PFB-D6pCb_THhwWzTscR7ZB6OHvg@mail.gmail.com>
	<167482801126.1114.1095311628314619931.pgcf@coridan.postgresql.org>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CA+Tgmoa7ODAMvJn8sncmMzxkHL=hKmqXa3TLqh-SCLmiB64qzQ@mail.gmail.com>
	<[email protected]>
	<CA+TgmoZDjc04aPD0LM4LKZ_GstggvAzxmmhWdeX0iHrnC1V2Yg@mail.gmail.com>

> On 3 Apr 2023, at 16:09, Robert Haas <[email protected]> wrote:
> On Mon, Apr 3, 2023 at 9:15 AM Daniel Gustafsson <[email protected]> wrote:
>>> On 3 Apr 2023, at 15:09, Robert Haas <[email protected]> wrote:

>>> I continue to think it's odd that the sense of this is inverted as
>>> compared with row_security.
>> 
>> I'm not sure I follow.  Do you propose that the GUC enables classes of event
>> triggers, the default being "all" (or similar) and one would remove the type of
>> EVT for which debugging is needed?  That doesn't seem like a bad idea, just one
>> that hasn't come up in the discussion (and I didn't think about).
> 
> Right. Although to be fair, that idea doesn't sound as good if we're
> going to have settings other than "on" or "off".

Yeah.  The patch as it stands allow for disabling specific types rather than
all-or-nothing, which is why the name was "ignore".

> I'm not sure what the best thing to do is here, I just think it
> deserves some thought.

Absolutely, the discussion is much appreciated.  Having done some thinking I
think I'm still partial to framing it as a disabling GUC rather than an
enabling; with the act of setting it being "As an admin I want to skip
execution of all evt's of type X". 

--
Daniel Gustafsson

view thread (11+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: GUC for temporarily disabling event triggers
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox