Content-Type: multipart/mixed;
 boundary="Apple-Mail=_C423C1BB-12A3-44ED-96D8-23B6AF5E377A"
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: WIP: BRIN multi-range indexes
From: Mark Dilger <hornschnorter@gmail.com>
In-Reply-To: <0577af5d-28ae-3df5-dffd-fc630d681ec2@2ndquadrant.com>
Date: Tue, 19 Dec 2017 11:38:08 -0800
Cc: pgsql-hackers@postgreSQL.org
Message-Id: <AF96CF9E-DEF8-466D-A8BA-FBFD7914B526@gmail.com>
References: <c1138ead-7668-f0e1-0638-c3be3237e812@2ndquadrant.com>
 <7899d6e3-7f30-6de1-d341-0670fc1aff42@2ndquadrant.com>
 <edbce0ff-f5b1-c381-2649-3ac174eb7ca6@2ndquadrant.com>
 <0577af5d-28ae-3df5-dffd-fc630d681ec2@2ndquadrant.com>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Precedence: bulk


--Apple-Mail=_C423C1BB-12A3-44ED-96D8-23B6AF5E377A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii


> On Nov 18, 2017, at 12:45 PM, Tomas Vondra =
<tomas.vondra@2ndquadrant.com> wrote:
>=20
> Hi,
>=20
> Apparently there was some minor breakage due to duplicate OIDs, so =
here
> is the patch series updated to current master.
>=20
> regards
>=20
> --=20
> Tomas Vondra                  http://www.2ndQuadrant.com
> PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
> =
<0001-Pass-all-keys-to-BRIN-consistent-function-at-once.patch.gz><0002-BRI=
N-bloom-indexes.patch.gz><0003-BRIN-multi-range-minmax-indexes.patch.gz><0=
004-Move-IS-NOT-NULL-checks-to-bringetbitmap.patch.gz>


After applying these four patches to my copy of master, the regression
tests fail for F_SATISFIES_HASH_PARTITION 5028 as attached.

mark


--Apple-Mail=_C423C1BB-12A3-44ED-96D8-23B6AF5E377A
Content-Disposition: attachment;
	filename=regression.diffs
Content-Type: application/octet-stream;
	name="regression.diffs"
Content-Transfer-Encoding: 7bit

*** /Users/mark/master/postgresql/src/test/regress/expected/oidjoins.out	2017-11-10 06:50:30.000000000 -0800
--- /Users/mark/master/postgresql/src/test/regress/results/oidjoins.out	2017-12-19 11:31:42.000000000 -0800
***************
*** 621,629 ****
  FROM	pg_catalog.pg_opclass fk
  WHERE	opcfamily != 0 AND
  	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_opfamily pk WHERE pk.oid = fk.opcfamily);
!  ctid | opcfamily 
! ------+-----------
! (0 rows)
  
  SELECT	ctid, opcintype
  FROM	pg_catalog.pg_opclass fk
--- 621,630 ----
  FROM	pg_catalog.pg_opclass fk
  WHERE	opcfamily != 0 AND
  	NOT EXISTS(SELECT 1 FROM pg_catalog.pg_opfamily pk WHERE pk.oid = fk.opcfamily);
!   ctid  | opcfamily 
! --------+-----------
!  (1,57) |      5028
! (1 row)
  
  SELECT	ctid, opcintype
  FROM	pg_catalog.pg_opclass fk

======================================================================

*** /Users/mark/master/postgresql/src/test/regress/expected/opr_sanity.out	2017-12-19 11:28:04.000000000 -0800
--- /Users/mark/master/postgresql/src/test/regress/results/opr_sanity.out	2017-12-19 11:31:44.000000000 -0800
***************
*** 1700,1709 ****
  -- Ask access methods to validate opclasses
  -- (this replaces a lot of SQL-level checks that used to be done in this file)
  SELECT oid, opcname FROM pg_opclass WHERE NOT amvalidate(oid);
!  oid | opcname 
! -----+---------
! (0 rows)
! 
  -- **************** pg_am ****************
  -- Look for illegal values in pg_am fields
  SELECT p1.oid, p1.amname
--- 1700,1706 ----
  -- Ask access methods to validate opclasses
  -- (this replaces a lot of SQL-level checks that used to be done in this file)
  SELECT oid, opcname FROM pg_opclass WHERE NOT amvalidate(oid);
! ERROR:  cache lookup failed for operator family 5028
  -- **************** pg_am ****************
  -- Look for illegal values in pg_am fields
  SELECT p1.oid, p1.amname
***************
*** 1901,1909 ****
  WHERE NOT EXISTS(SELECT 1 FROM pg_amop AS p2
                   WHERE p2.amopfamily = p1.opcfamily
                     AND binary_coercible(p1.opcintype, p2.amoplefttype));
!  opcname | opcfamily 
! ---------+-----------
! (0 rows)
  
  -- Check that each operator listed in pg_amop has an associated opclass,
  -- that is one whose opcintype matches oprleft (possibly by coercion).
--- 1898,1907 ----
  WHERE NOT EXISTS(SELECT 1 FROM pg_amop AS p2
                   WHERE p2.amopfamily = p1.opcfamily
                     AND binary_coercible(p1.opcintype, p2.amoplefttype));
!     opcname    | opcfamily 
! ---------------+-----------
!  oid_bloom_ops |      5028
! (1 row)
  
  -- Check that each operator listed in pg_amop has an associated opclass,
  -- that is one whose opcintype matches oprleft (possibly by coercion).
***************
*** 1918,1924 ****
                     AND binary_coercible(p2.opcintype, p1.amoplefttype));
   amopfamily | amopstrategy | amopopr 
  ------------+--------------+---------
! (0 rows)
  
  -- Operators that are primary members of opclasses must be immutable (else
  -- it suggests that the index ordering isn't fixed).  Operators that are
--- 1916,1923 ----
                     AND binary_coercible(p2.opcintype, p1.amoplefttype));
   amopfamily | amopstrategy | amopopr 
  ------------+--------------+---------
!        5029 |            1 |     607
! (1 row)
  
  -- Operators that are primary members of opclasses must be immutable (else
  -- it suggests that the index ordering isn't fixed).  Operators that are

======================================================================


--Apple-Mail=_C423C1BB-12A3-44ED-96D8-23B6AF5E377A--