From: Chao Li <li.evan.chao@gmail.com>
Message-Id: <B01E4301-5120-4CCA-ABAA-DC5FEE6656ED@gmail.com>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_8583CE95-0BF4-430D-BD8E-42677058ED6F"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Cleanup explain_memoize function after test
Date: Wed, 22 Apr 2026 17:24:33 +0800
In-Reply-To: 
 <CALdSSPij9tx019ZzR+VVj7cEEd7HL4-SPiu+YKx66n9-rVPkUg@mail.gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
To: Kirill Reshke <reshkekirill@gmail.com>
References: 
 <CALdSSPij9tx019ZzR+VVj7cEEd7HL4-SPiu+YKx66n9-rVPkUg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/B01E4301-5120-4CCA-ABAA-DC5FEE6656ED%40gmail.com>
Precedence: bulk


--Apple-Mail=_8583CE95-0BF4-430D-BD8E-42677058ED6F
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


> On Apr 22, 2026, at 14:49, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>=20
> Hi!
>=20
> I was doing some hacking today, when I noticed that the memoize
> regression test does not clean up the explain_memoize function after
> its end. I checked other regression tests and they tend to do it. So,
> I am not sure if there is a rule about `you should drop all objects
> that you create in regression test`, but if there is such a rule, PFA.
>=20
>=20
>=20
> --=20
> Best regards,
> Kirill Reshke
> <v1-0001-Cleanup-explain_memoize-after-resgression-test.patch>

Good catch.

You also need to update the corresponding out file, otherwise the test =
will fail. I have helped update the out file in v2, now =E2=80=9Cmake =
check=E2=80=9D passes with v2 applied.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/


--Apple-Mail=_8583CE95-0BF4-430D-BD8E-42677058ED6F
Content-Disposition: attachment;
	filename=v2-0001-Cleanup-explain_memoize-after-resgression-test.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="v2-0001-Cleanup-explain_memoize-after-resgression-test.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20695443e50e522453f11c442fef6f025e29a0a2e3=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20reshke=20<reshke@double.cloud>=0ADate:=20Wed,=20=
22=20Apr=202026=2006:46:25=20+0000=0ASubject:=20[PATCH=20v2]=20Cleanup=20=
explain_memoize=20after=20resgression=20test=0A=0A---=0A=20=
src/test/regress/expected/memoize.out=20|=201=20+=0A=20=
src/test/regress/sql/memoize.sql=20=20=20=20=20=20|=202=20++=0A=202=20=
files=20changed,=203=20insertions(+)=0A=0Adiff=20--git=20=
a/src/test/regress/expected/memoize.out=20=
b/src/test/regress/expected/memoize.out=0Aindex=20=
218972dfab8..199ef15920a=20100644=0A---=20=
a/src/test/regress/expected/memoize.out=0A+++=20=
b/src/test/regress/expected/memoize.out=0A@@=20-561,4=20+561,5=20@@=20=
SELECT=20*=20FROM=20tab_anti=20t1=20WHERE=20t1.a=20IN=0A=20=20=20=20=20=20=
=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20=20->=20=20Seq=20Scan=20on=20=
tab_anti=20t3=0A=20(10=20rows)=0A=20=0A+DROP=20FUNCTION=20=
explain_memoize;=0A=20DROP=20TABLE=20tab_anti;=0Adiff=20--git=20=
a/src/test/regress/sql/memoize.sql=20b/src/test/regress/sql/memoize.sql=0A=
index=20e39bbb65391..4774d20c624=20100644=0A---=20=
a/src/test/regress/sql/memoize.sql=0A+++=20=
b/src/test/regress/sql/memoize.sql=0A@@=20-272,4=20+272,6=20@@=20SELECT=20=
*=20FROM=20tab_anti=20t1=20WHERE=20t1.a=20IN=0A=20=20(SELECT=20a=20FROM=20=
tab_anti=20t2=20WHERE=20t2.b=20IN=0A=20=20=20(SELECT=20t1.b=20FROM=20=
tab_anti=20t3=20WHERE=20t2.a=20>=201=20OFFSET=200));=0A=20=0A+DROP=20=
FUNCTION=20explain_memoize;=0A+=0A=20DROP=20TABLE=20tab_anti;=0A--=20=0A=
2.50.1=20(Apple=20Git-155)=0A=0A=

--Apple-Mail=_8583CE95-0BF4-430D-BD8E-42677058ED6F--