Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: pg_test_timing: fix unit typo and widen diff type
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAHGQGwEp21h5JUHLP0Rj2GMuOVtH_5E7y3J=BW9yVT8gNaSgLQ@mail.gmail.com>
Date: Fri, 24 Apr 2026 11:30:10 +0800
Cc: "wang.xiao.peng" <wxp_728@163.com>,
 lukas@fittl.com,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>,
 Hannu Krosing <hannuk@google.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B034BD3B-DD95-4D89-AAB2-1C3B5F5D3C2D@gmail.com>
References: <F780CEEB-A237-4302-9F55-60E9D8B6533D@gmail.com>
 <CAP53PkwEZ+UMmwA8cbUSUdE6phXi+xWmn5t-YAnvKf0qoBnOvg@mail.gmail.com>
 <D83C0F3F-0CD8-4D1D-B59C-F2AFBB9B2974@gmail.com>
 <CDC22691-F63E-4FD3-865A-2982E3B56DCA@gmail.com>
 <7d4afbdb.5322.19d70df0de4.Coremail.wxp_728@163.com>
 <CAHGQGwEM=s5vXPpXoismwRMNCnAmwwMJPnQEQYbPFTJGouV0rQ@mail.gmail.com>
 <56B09FF0-13AB-4AF3-A4C4-29428A695FB0@gmail.com>
 <CAHGQGwHFHghHRn1427m_ZH_D9t0gytKRa96Uid-pJ4VyZCvyOw@mail.gmail.com>
 <21E668C0-CEAE-44F8-B585-319F31883AFE@gmail.com>
 <CAHGQGwEp21h5JUHLP0Rj2GMuOVtH_5E7y3J=BW9yVT8gNaSgLQ@mail.gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/B034BD3B-DD95-4D89-AAB2-1C3B5F5D3C2D%40gmail.com>
Precedence: bulk


> On Apr 24, 2026, at 11:15, Fujii Masao <masao.fujii@gmail.com> wrote:
>=20
> On Thu, Apr 23, 2026 at 11:03=E2=80=AFAM Chao Li =
<li.evan.chao@gmail.com> wrote:
>> I just checked old branches. Looks like 0001 can be back-patched down =
to v10. Yes, pre-19, all branches use microsecond, so the back-patch =
should change =E2=80=9Cms=E2=80=9D to =E2=80=9Cus=E2=80=9D.
>=20
> Thanks! So I've pushed this unit change to master and backpatched it =
to
> all supported branches.
>=20
>=20
>> For v16 to v18, we can make a tiny improvement by replacing =E2=80=9C1e=
9=E2=80=9D with a constant macro NS_PER_S. This change has been included =
in the diff.
>=20
> This change looks good to me. However, we should generally keep =
changes to
> old stable branches to the minimum required, so I applied this change =
only
> to master with 0002 patch.
>=20
>=20
>> I see 0002 a bit differently. In v19, the unit changed from =
microseconds to nanoseconds, which introduced a potential overflow: =
nanoseconds require int64, but the local variable remained int32. So I =
think this is actually a v19-only bug.
>=20
> OK, I've pushed 0002 patch. Thanks!
>=20
> Regards,
>=20
> --=20
> Fujii Masao

Hi Fujii-san, thank you very much for pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/