Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\))
Subject: Re: Cirrus-ci is lowering free CI cycles - what to do with cfbot,
 etc?
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <3557216.1692824571@sss.pgh.pa.us>
Date: Wed, 23 Aug 2023 23:12:50 +0200
Cc: Andres Freund <andres@anarazel.de>,
 PostgreSQL Hackers <pgsql-hackers@postgresql.org>,
 Thomas Munro <thomas.munro@gmail.com>,
 Justin Pryzby <pryzby@telsasoft.com>,
 Nazir Bilal Yavuz <byavuz81@gmail.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B0CDD2D6-DBCF-4E8B-8322-4B1D7ED50DCA@yesql.se>
References: <20230808021541.7lbzdefvma7qmn3w@awork3.anarazel.de>
 <20230823065833.vnnfwoi3n2sbw5kf@awork3.anarazel.de>
 <CF26F682-EA8E-485C-A682-E06A7D3D8D37@yesql.se>
 <20230823192239.jxew5s3sjru63lio@awork3.anarazel.de>
 <DCA2CD4A-E99F-4120-AE96-F510D994FE89@yesql.se>
 <3557216.1692824571@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/B0CDD2D6-DBCF-4E8B-8322-4B1D7ED50DCA%40yesql.se>
Precedence: bulk

> On 23 Aug 2023, at 23:02, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Daniel Gustafsson <daniel@yesql.se> writes:
>> On 23 Aug 2023, at 21:22, Andres Freund <andres@anarazel.de> wrote:
>>> I think there's more effective ways to make this cheaper. The basic =
thing
>>> would be to use libpq instead of forking of psql to make a =
connection
>>> check.
>=20
>> I had it in my head that not using libpq in pg_regress was a =
deliberate choice,
>> but I fail to find a reference to it in the archives.
>=20
> I have a vague feeling that you are right about that.  Perhaps the
> concern was that under "make installcheck", pg_regress might be
> using a build-tree copy of libpq rather than the one from the
> system under test.  As long as we're just trying to ping the server,
> that shouldn't matter too much I think ... unless we hit problems
> with, say, a different default port number or socket path compiled =
into
> one copy vs. the other?  That seems like it's probably a "so don't
> do that" case, though.

Ah yes, that does ring a familiar bell.  I agree that using it for =
pinging the
server should be safe either way, but we should document the =
use-with-caution
in pg_regress.c if/when we go down that path.  I'll take a stab at =
changing the
psql retry loop for pinging tomorrow to see what it would look like.

--
Daniel Gustafsson