Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: New Object Access Type hooks
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <1975199.1649099110@sss.pgh.pa.us>
Date: Mon, 4 Apr 2022 13:28:17 -0700
Cc: Thomas Munro <thomas.munro@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Joshua Brindle <joshua.brindle@crunchydata.com>,
 Robert Haas <robertmhaas@gmail.com>,
 Andrew Dunstan <andrew@dunslane.net>,
 Jeff Davis <pgsql@j-davis.com>,
 Joe Conway <joe@crunchydata.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B188F52A-69B8-46E3-A32B-2FAFD9447FEF@enterprisedb.com>
References: <47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com>
 <CA+hUKG+LOza8iSLiv6ymn=0R8S0x-R7KaqZmYfY+_b_cubcDOg@mail.gmail.com>
 <17BD82D7-49AC-40C9-8204-E7ADD30321A0@enterprisedb.com>
 <1918971.1649091790@sss.pgh.pa.us> <1922986.1649094077@sss.pgh.pa.us>
 <1923706.1649094673@sss.pgh.pa.us>
 <AACAF464-092B-4497-ADA2-AE1B122FAC6A@enterprisedb.com>
 <1925660.1649095626@sss.pgh.pa.us>
 <2BD8BDA8-A963-4D64-8B69-8F7EDF9AEA2D@enterprisedb.com>
 <1974785.1649098875@sss.pgh.pa.us> <1975199.1649099110@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/B188F52A-69B8-46E3-A32B-2FAFD9447FEF%40enterprisedb.com>
Precedence: bulk


> On Apr 4, 2022, at 12:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> I wrote:
>> The "terminating connection" warning absolutely should get through,
>=20
> ... oh, no, that's not guaranteed at all, since it's sent from =
quickdie().
> So scratch that.  Maybe we'd better add "could not send data to =
server"
> to the regex?

If it fails in pqsecure_raw_write(), you get either "server closed the =
connection unexpectedly" or "could not send data to server".  Do we need =
to support pgtls_write() or pg_GSS_write(), which have different error =
messages?  Can anybody run the tests with TLS or GSS enabled?  I assume =
the test framework prevents this, but I didn't check too closely....

Is it possible that pgFlush will call pqSendSome which calls pqReadData =
before trying to write anything, and get back a "could not receive data =
from server" from pqsecure_raw_read()?

It's a bit hard to prove to myself which paths might be followed through =
this code.  Thoughts?

=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company