Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxuCu-0006Aq-7H for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jun 2021 16:34:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lxuCt-0007Sn-6E for pgsql-hackers@arkaria.postgresql.org; Mon, 28 Jun 2021 16:33:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lxuCs-0007Sc-Uj for pgsql-hackers@lists.postgresql.org; Mon, 28 Jun 2021 16:33:58 +0000 Received: from mail-pj1-x102b.google.com ([2607:f8b0:4864:20::102b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lxuCq-0004P6-Hl for pgsql-hackers@postgresql.org; Mon, 28 Jun 2021 16:33:57 +0000 Received: by mail-pj1-x102b.google.com with SMTP id bb20so10501822pjb.3 for ; Mon, 28 Jun 2021 09:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=FkVru8DJE9odt0b7vgPKUOLLLofF0IT80u+5JRsHSKs=; b=u3GyQEb2oasIxWiP0kzioKa4JUvjSlmxPwugo935UNDYQ5PEXct3RVQSfYI2YQ8MxO x2Ok+aU4tg3KOJ3wJUUBS8OuE91d1BCVu4IIOwUb5I37XTJeoUtVGFMd08DnYTeEW9l5 Kohyuqkr60buKQjCqxWOf/SQWIvmXEoRohobi99ksOIZybAbaQ7yicXGOlbxYCGU3o4g /5Wq/4xt8vt/Uo2DfRsdoCljnyjZJ5nP8DEpU6SIl8X5jkm6EB+MY2mXkQLqQNOjzHdi vNY86sRRx6B5JkMzIKe1DCJ2hfPMVlWS5z3gbPcPHGXcval/HL/3SBsE+ZDIESOx1scZ D9+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=FkVru8DJE9odt0b7vgPKUOLLLofF0IT80u+5JRsHSKs=; b=Fc3IsBj2YcwK2UJn94dHK1qSs1r803Hy9donPSD4BW20FWti9hWWAgeUrmQi9gfMm8 WI5qvGXxu3QzuYkxKVmdxckx3TALoUW39L16Nh4hVeW4Ohz66AOqJuN6fJNMW99/RyBx QCmxgwSs8eyU83wQ0i3+essY0Zepqxr0PEqHEHFscKO1LPig2T3GRmFjB0Sa8/J56dgJ 7Ta1fsN6+v0QcnSZtbxl8GK/P9siWzituzPROHT6+H4KSwwKXGbz3v/ZDUG1iPkA9TOd VoG6+XjMOGjJEFtH0fa9wD9vnDNJnnoH9WddGgNuiwfH6Fu67BMB+ywBaKeCDD0BAZwD Xdfg== X-Gm-Message-State: AOAM531AdSV3vlvCd8YNGQWZ1hQsakuYIK+4MvSonFgBxnOLFCYDiQAs 2WNIzEZlW+Pf2nhqGLIzmLf/rN4eyoUs6X3ACKM00b3Lx+KdAzFJ72BybkoMbwme98oZz8eVEVo miqC2EB1BGxSTwJSHXgy44/tdM50vpsRZ3IRZdi+lfl/0t3H1EA4wRCQsh86eXyxRiuwIqdzawn F1qWWdMV7m49HxothYiI7QFFeFExApPVlHRWJ/5d0vFDwK X-Google-Smtp-Source: ABdhPJzCD8HkEauk509aEa5N4/PaKOdjodmE6ugyzgGeWeX99aTfO/wQOFinhuxwVw3KNXLEvFLYWA== X-Received: by 2002:a17:90a:3d0d:: with SMTP id h13mr29265364pjc.20.1624898035505; Mon, 28 Jun 2021 09:33:55 -0700 (PDT) Received: from ?IPv6:2600:6c50:157f:eb87:dd68:28b6:445f:e93d? ([2600:6c50:157f:eb87:dd68:28b6:445f:e93d]) by smtp.gmail.com with ESMTPSA id 23sm14339517pfy.113.2021.06.28.09.33.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jun 2021 09:33:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.6\)) Subject: Re: pglz compression performance, take two From: Mark Dilger In-Reply-To: <90649B7F-EF71-40F7-93D0-1029AD0D90F3@enterprisedb.com> Date: Mon, 28 Jun 2021 09:33:53 -0700 Cc: Justin Pryzby , pgsql-hackers@postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <25991595-1848-4178-AA57-872B10309DA2@yandex-team.ru> <20201230043930.GG25152@telsasoft.com> <20210122024811.GE27167@telsasoft.com> <88C049C6-1B86-4EF7-940D-585B07FEB81B@yandex-team.ru> <90649B7F-EF71-40F7-93D0-1029AD0D90F3@enterprisedb.com> To: Andrey Borodin X-Mailer: Apple Mail (2.3608.120.23.2.6) X-CLOUD-SEC-AV-Info: enterprisedb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On Jun 28, 2021, at 9:05 AM, Mark Dilger = wrote: >=20 > Is it worth sharting a static inline function that uses your = optimization in other places? =20 s/sharting/sharing/ > How confident are you that your optimization really helps? By which I mean, is the optimization worth the extra branch checking if = (len >=3D 16)? Is the 14% speedup you report dependent on this extra = complexity? =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company