Feedback-ID: id4a34324:Fastmail
Date: Tue, 31 Jan 2023 23:55:46 -0800
From: Andres Freund <andres@anarazel.de>
To: pgsql-hackers@lists.postgresql.org,
 Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: meson: pkgconfig difference
User-Agent: K-9 Mail for Android
In-Reply-To: <07b37c70-349a-8fcd-bcc9-6c3ce0f6c2a4@enterprisedb.com>
References: <07b37c70-349a-8fcd-bcc9-6c3ce0f6c2a4@enterprisedb.com>
Message-ID: <B21CA1CF-5599-48DC-BA00-2E6F3D804DEC@anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Archived-At: <https://www.postgresql.org/message-id/B21CA1CF-5599-48DC-BA00-2E6F3D804DEC%40anarazel.de>
Precedence: bulk

Hi,=20

On January 31, 2023 11:40:52 PM PST, Peter Eisentraut <peter=2Eeisentraut@=
enterprisedb=2Ecom> wrote:
>I think there is a tiny typo in src/interfaces/ecpg/ecpglib/meson=2Ebuild=
:
>
>diff --git a/src/interfaces/ecpg/ecpglib/meson=2Ebuild b/src/interfaces/e=
cpg/ecpglib/meson=2Ebuild
>index dba9e3c3d9=2E=2Eda8d304f54 100644
>--- a/src/interfaces/ecpg/ecpglib/meson=2Ebuild
>+++ b/src/interfaces/ecpg/ecpglib/meson=2Ebuild
>@@ -57,7 +57,7 @@ pkgconfig=2Egenerate(
>   description: 'PostgreSQL libecpg library',
>   url: pg_url,
>   libraries: ecpglib_so,
>-  libraries_private: [frontend_shlib_code, thread_dep],
>+  libraries_private: [frontend_stlib_code, thread_dep],
>   requires_private: ['libpgtypes', 'libpq'],
> )
>
>This makes it match the other libraries=2E
>
>Without this change, we get
>
>Libs=2Eprivate: =2E=2E=2E -lpgport_shlib -lpgcommon_shlib
>
>which seems wrong=2E

Ugh, yes, that's wrong=2E Do you want me to apply the fix?

Regards,

Andres

--=20
Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E