Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFxrM-005kUo-2h for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 17:29:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.96) (envelope-from ) id 1wFxrK-002ad6-01 for pgsql-hackers@arkaria.postgresql.org; Thu, 23 Apr 2026 17:29:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1wFxrJ-002acy-1w for pgsql-hackers@lists.postgresql.org; Thu, 23 Apr 2026 17:29:01 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wFxrG-00000002RwK-07Tf for pgsql-hackers@postgresql.org; Thu, 23 Apr 2026 17:29:00 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 036765B7EE2 for ; Thu, 23 Apr 2026 19:28:55 +0200 (CEST) Received: from s980.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id DEEE75B93C5; Thu, 23 Apr 2026 19:28:54 +0200 (CEST) Received: from localhost (unknown [172.22.191.6]) by s980.loopia.se (Postfix) with ESMTP id DD0C1220160B; Thu, 23 Apr 2026 19:28:54 +0200 (CEST) X-Virus-Scanned: amavis at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1.2 X-Spam-Level: X-Spam-Status: No, score=-1.2 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1] autolearn=disabled Authentication-Results: s898.loopia.se (amavis); dkim=pass (2048-bit key) header.d=yesql.se Received: from s934.loopia.se ([172.22.191.5]) by localhost (s898.loopia.se [172.22.190.17]) (amavis, port 10024) with LMTP id djN_VsnD4BkM; Thu, 23 Apr 2026 19:28:54 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.236 Received: from smtpclient.apple (customer-89-255-232-236.stosn.net [89.255.232.236]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id 51482917F08; Thu, 23 Apr 2026 19:28:54 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yesql.se; s=loopiadkim1707475645; t=1776965334; bh=5EKvxKSDy43nzOANJ2j8IXW0cyaaHCwZnie6j1suOvo=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=r+QB7CFMOGpmmlLfEh0aJyeir9T9h7wVm0BRH0yIJtMOcmTCSeWzqhHziDdtJOWAl uNLQTcTsu7DoJHlBr/H89xZn55N8mYehfpiRjNYWHFbfaqGM3oPi7nMT82uxjF3nb+ FO6qrDV76gLp6QNW3C3622wbbVO2ACMSsHYbEDCBPbFWJDuQ1GDvVp40cNIoK9PGyC d44vQb69JcUmVUac3dTuNxCI8tnsWf4nbGCrf7bIrAlgUDoZmiUkEjf/b7ZcVPzllS 3SA7vgB09ahS7vUeUa+2EOuUiRmC1yMcfv3JxY8qcBcakCEChAhfzcMQfmiE8SDSU8 Am6CF5H1R0n3g== Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3776.700.51.11.2\)) Subject: Re: oauth integer overflow From: Daniel Gustafsson In-Reply-To: Date: Thu, 23 Apr 2026 19:28:43 +0200 Cc: PostgreSQL Hackers , Jacob Champion Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Andres Freund X-Mailer: Apple Mail (2.3776.700.51.11.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 23 Apr 2026, at 18:12, Andres Freund wrote: > I don't think it's safe to rely on that type of check working without = -fwrapv > support, which in turn we can't rely on having. >=20 > I think this should use pg_add_s32_overflow(). Agreed, I'll write up a patch to fix it. -- Daniel Gustafsson