public inbox for [email protected]  

help / color / mirror / Atom feed
From: Chao Li <[email protected]>
To: David Christensen <[email protected]>
Cc: Tom Lane <[email protected]>
Cc: Peter Eisentraut <[email protected]>
Cc: Andrey Borodin <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: David G. Johnston <[email protected]>
Cc: Jelte Fennema-Nio <[email protected]>
Subject: Re: [PATCH] GROUP BY ALL
Date: Tue, 30 Sep 2025 07:46:25 +0800
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHM0NXjJdKgTC91VegL_SruOBn_PQoeCime_DZkOA02HChPDmw@mail.gmail.com>
References: <[email protected]>
	<[email protected]>
	<CAHM0NXj1Gv_96WxZkiLKhxJVaYOGcmdZ2hApNcvWQ5HxV84Q=A@mail.gmail.com>
	<[email protected]>
	<CAHM0NXgPhe_OF81MyA9ocWZ=b+oEAHtQHoDXw4DverPdbkXzpg@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CAHM0NXgP6-a75XgAR-WdKfzvDRcUv3=CipR+Zt2qmZ0T8bcABg@mail.gmail.com>
	<CAHM0NXjJdKgTC91VegL_SruOBn_PQoeCime_DZkOA02HChPDmw@mail.gmail.com>



> On Sep 29, 2025, at 04:34, David Christensen <[email protected]> wrote:
> 
> On Sun, Sep 28, 2025 at 2:18 PM David Christensen <[email protected] <mailto:[email protected]>> wrote:
>> 
>> On Sat, Sep 27, 2025 at 5:23 PM Tom Lane <[email protected]> wrote:
>>> 
>>> Here's a v6 that's rebased up to HEAD and contains fixes for the
>>> semantic issues we discussed.  It still lacks documentation, but
>>> otherwise I think it's about ready to go.
>> 
>> Here is v7 with a stab at docs; fairly minimal at this point, but
>> touching the two areas that are likely to need adjusting.  When
>> adjusting the docs for sql-select, I noticed that the grammar also
>> supports `GROUP BY ALL <grouping_elements>`, so I also added a test to
>> ensure that this syntax is explicitly supported. (It seems like it
>> works as-is without further grammar adjustments, but I was a little
>> worried when I first saw that fact... :D)  Not sure that
>> aggregates.sql is still the right place for all of these bits, but it
>> does seem like having all things `GROUP BY ALL`-related tested in the
>> same place is a nice property, so leaving there for now.
> 
> This time with attachment!
> <v7-0001-Add-GROUP-BY-ALL.patch>


A nit comment for the doc:

```
+    not contain either an aggregate function or a window function in their
+    expression list.  This can greatly simplify ad-hoc exploration of data.
+   </para>
```

“In their expression list” => “in the <literal>SELECT</literal> list"

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






view thread (49+ messages)  latest in thread

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] GROUP BY ALL
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox