Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Subject: Re: Updated macOS start scripts
From: Mark Dilger <hornschnorter@gmail.com>
In-Reply-To: <5974.1510781873@sss.pgh.pa.us>
Date: Wed, 15 Nov 2017 13:40:38 -0800
Cc: pgsql-hackers@postgreSQL.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <B4217ABF-412F-403D-9B68-BD3D9DF8FB12@gmail.com>
References: <31338.1510763554@sss.pgh.pa.us>
 <6D443E39-13C2-4185-9FE4-B5CB416AB06E@gmail.com>
 <21689.1510772433@sss.pgh.pa.us>
 <F8F64F48-C070-41C1-A1EE-1F25836B6FAF@gmail.com>
 <5974.1510781873@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Precedence: bulk


> On Nov 15, 2017, at 1:37 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Mark Dilger <hornschnorter@gmail.com> writes:
>> I have tested this on 10.11.6. I had no trouble following the =
instructions
>> in the README and everything worked as described.
>> As far as I can tell, this patch has not yet been submitted to any =
commitfest.
>> I would mark it Read for Committer.
>=20
> Thanks for reviewing!  Since you already did review it, I think we can
> probably skip the CF paperwork and just push it.
>=20
> One thing that needs to be figured out is what to do with the old osx
> scripts.  My inclination is to remove that subdirectory in HEAD.
> However, I'd like to also stick these new scripts into the supported
> back branches, since the problem is just as real for any back branch
> as it is for v11.  What I propose for the back branches is to add
> contrib/start-scripts/macos/ alongside .../osx/, keeping the latter,
> but adjust its README to note that those scripts are only for =
pre-10.10
> versions of macOS.

I am reasonably content with your earlier idea of not keeping support
for ancient versions of OS X, but if you want to do what you describe
above, I'd be happy to review that on my 10.6 box to verify that
everything works at least that far back.  I don't have access to =
relevant,
pre-10.4 machines.

mark