Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: pgindent versus struct members and typedefs
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <512380.1764717196@sss.pgh.pa.us>
Date: Wed, 3 Dec 2025 07:31:48 +0800
Cc: Nathan Bossart <nathandbossart@gmail.com>,
 Rahila Syed <rahilasyed90@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B55A39FB-97F4-4869-A2A3-59429486ED5F@gmail.com>
References: <aS9hkwnkWf3dZIA_@nathan>
 <347EA055-D626-414C-B10D-7E70041B9B55@gmail.com>
 <509793.1764715875@sss.pgh.pa.us>
 <5E70CB69-1E2D-471B-8CF8-83205E5E14CE@gmail.com>
 <512380.1764717196@sss.pgh.pa.us>
To: Tom Lane <tgl@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/B55A39FB-97F4-4869-A2A3-59429486ED5F%40gmail.com>
Precedence: bulk


> On Dec 3, 2025, at 07:13, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>=20
> Chao Li <li.evan.chao@gmail.com> writes:
>>> On Dec 3, 2025, at 06:51, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>>> In this case, I think pgindent is indirectly enforcing good style.
>>> I do not like omitting braces around anything that's more than one
>>> line; readers have to pay close attention to whether the code is
>>> doing what it was intended to.
>=20
>> For =E2=80=9Cone line=E2=80=9D, do you mean only a single line of =
statement or one line statement plus one line comment?
>=20
> In my head, a comment and a statement are two lines, and so need
> wrapping braces as much as two statements would do.  I realize that
> C compilers think differently, but for readability and modifiability
> reasons that's the approach I take.
>=20

Totally agreed. In my first job at Lucent Technologies, the coding =
standard was that braces should always be added even if a clause has =
only one line of code. I remember one of the explanations was like, if =
braces has been added, then later when a new line of code is added to =
the clause, there is only one line of diff, otherwise braces need to be =
added, so it would be 3 lines of diffs.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/