public inbox for [email protected]  

help / color / mirror / Atom feed

From: Chao Li <[email protected]>
To: PostgreSQL Hackers <[email protected]>
Subject: Bug: wrong relname in RemoveSubscriptionRel() error detail
Date: Fri, 27 Mar 2026 17:51:57 +0800
Message-ID: <[email protected]> (raw)

Hi,

I just noticed a wrong relation name in the error detail emitted by RemoveSubscriptionRel():
```
*
 * Drop subscription relation mapping. These can be for a particular
 * subscription, or for a particular relation, or both.
 */
void
RemoveSubscriptionRel(Oid subid, Oid relid)
{
	Relation	rel;
	TableScanDesc scan;
	ScanKeyData skey[2];
	HeapTuple	tup;
	int			nkeys = 0;

	rel = table_open(SubscriptionRelRelationId, RowExclusiveLock);

	if (OidIsValid(subid))
	{
		ScanKeyInit(&skey[nkeys++],
					Anum_pg_subscription_rel_srsubid,
					BTEqualStrategyNumber,
					F_OIDEQ,
					ObjectIdGetDatum(subid));
	}

	if (OidIsValid(relid))
	{
		ScanKeyInit(&skey[nkeys++],
					Anum_pg_subscription_rel_srrelid,
					BTEqualStrategyNumber,
					F_OIDEQ,
					ObjectIdGetDatum(relid));
	}

	/* Do the search and delete what we found. */
	scan = table_beginscan_catalog(rel, nkeys, skey);
	while (HeapTupleIsValid(tup = heap_getnext(scan, ForwardScanDirection)))
	{
		Form_pg_subscription_rel subrel;

		subrel = (Form_pg_subscription_rel) GETSTRUCT(tup);

		if (!OidIsValid(subid) &&
			subrel->srsubstate != SUBREL_STATE_READY &&
			get_rel_relkind(subrel->srrelid) != RELKIND_SEQUENCE)
		{
			ereport(ERROR,
					(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
					 errmsg("could not drop relation mapping for subscription \"%s\"",
							get_subscription_name(subrel->srsubid, false)),
					 errdetail("Table synchronization for relation \"%s\" is in progress and is in state \"%c\".",
							   get_rel_name(relid), subrel->srsubstate), // <====== bug is here

```

In the error detail, it uses relid to get the relation name. But at that point we are iterating over subrel, and the function argument relid can be InvalidOid. So the error detail should use subrel->srrelid instead.

This looks like a first-day bug introducing by ce0fdbf, so I think it’s worth back-patching.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/






Attachments:

  [application/octet-stream] v1-0001-Fix-wrong-relname-in-RemoveSubscriptionRel-error-.patch (1.1K, 2-v1-0001-Fix-wrong-relname-in-RemoveSubscriptionRel-error-.patch)
  download | inline diff:
From c49dc0495607c05c6ac8e15cc0300f91bacf0f6c Mon Sep 17 00:00:00 2001
From: "Chao Li (Evan)" <[email protected]>
Date: Fri, 27 Mar 2026 17:39:30 +0800
Subject: [PATCH v1] Fix wrong relname in RemoveSubscriptionRel() error detail

Author: Chao Li <[email protected]>
Reviewed-by:
Discussion: https://postgr.es/m/
---
 src/backend/catalog/pg_subscription.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/backend/catalog/pg_subscription.c b/src/backend/catalog/pg_subscription.c
index 5a733585490..0ee00d91d83 100644
--- a/src/backend/catalog/pg_subscription.c
+++ b/src/backend/catalog/pg_subscription.c
@@ -525,7 +525,7 @@ RemoveSubscriptionRel(Oid subid, Oid relid)
 					 errmsg("could not drop relation mapping for subscription \"%s\"",
 							get_subscription_name(subrel->srsubid, false)),
 					 errdetail("Table synchronization for relation \"%s\" is in progress and is in state \"%c\".",
-							   get_rel_name(relid), subrel->srsubstate),
+							   get_rel_name(subrel->srrelid), subrel->srsubstate),
 
 			/*
 			 * translator: first %s is a SQL ALTER command and second %s is a
-- 
2.50.1 (Apple Git-155)

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected]
  Subject: Re: Bug: wrong relname in RemoveSubscriptionRel() error detail
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox