Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: tablecmds: reject CLUSTER ON for partitioned tables earlier
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <CAN4CZFMUJWM0veLK93Ew8mYaL5pcU6G550STh6AZ-_LWV2zS+w@mail.gmail.com>
Date: Fri, 23 Jan 2026 15:53:06 +0800
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <B9E960BD-9E45-46E7-951E-D11841D43431@gmail.com>
References: <CAEoWx2kggo1N2kDH6OSfXHL_5gKg3DqQ0PdNuL4LH4XSTKJ3-g@mail.gmail.com>
 <CAEoWx2k5800OjHO5KhTDv4JFYpDmyfh3MTtuB=7PP-0hLmG8yQ@mail.gmail.com>
 <07773235-2E94-478F-BEF6-38C73B0553B8@gmail.com>
 <EA6CB317-60C2-4BA9-8E02-DBCAD384F107@gmail.com>
 <CAN4CZFMUJWM0veLK93Ew8mYaL5pcU6G550STh6AZ-_LWV2zS+w@mail.gmail.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Archived-At: <https://www.postgresql.org/message-id/B9E960BD-9E45-46E7-951E-D11841D43431%40gmail.com>
Precedence: bulk


> On Jan 23, 2026, at 15:43, Zsolt Parragi <zsolt.parragi@percona.com> =
wrote:
>=20
> Hello!
>=20
> A simple patch and generally looks good, I only have a few =
observations.
>=20
>> =E2=80=9CALTER TABLE =E2=80=A6 CLUSTER ON=E2=80=9D and "SET WITHOUT =
CLUSTER" are not supported for
>> partitioned tables, but currently ATPrepCmd() allows them through and =
they
>> only fail later at execution time.
>=20
> Looking at the ALTER TABLE documentation, for other options there is a
> mention like "This form is not currently supported on partitioned
> tables." / "This form is not supported for partitioned tables."
>=20
> I don't see this mentioned for CLUSTER or INHERIT. Maybe it would be
> better to also mention this in the documentation?
>=20

Hi Zsolt,

Thank you very much for your review.

I have the other patch for the documentation update, see [1], that is an =
overall clarification for alter table behaviors against partition =
tables. Actually, I just found this issue while working on that patch.

I will handle rest of your comments soon.

[1] =
https://www.postgresql.org/message-id/CAEoWx2%3DmYhCfsnHaN96Qqwq5b0GVS2YgO=
3zpVqPPRd_iO52wRw%40mail.gmail.com

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/