Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: Granting SET and ALTER SYSTE privileges for GUCs
From: Mark Dilger <mark.dilger@enterprisedb.com>
In-Reply-To: <df224438-bcb5-5543-8ff6-841ce91053fb@dunslane.net>
Date: Mon, 13 Dec 2021 12:58:25 -0800
Cc: Robert Haas <robertmhaas@gmail.com>,
 Jeff Davis <pgsql@j-davis.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>,
 Tom Lane <tgl@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BA6C2DC4-A169-4239-B7E2-B4F73EA908E3@enterprisedb.com>
References: <3D691E20-C1D5-4B80-8BA5-6BEB63AF3029@enterprisedb.com>
 <CA+TgmobaKUYZhfXs-7kHjsmDmkcttH7-r9E2BJXUHtv9mkUUcw@mail.gmail.com>
 <AAE7FBCE-7C7D-4E92-A57F-D4496B306DDF@enterprisedb.com>
 <CA+TgmobUt_tSF-9tz-eRvWzT1pbe_ssvxfnPniGGEgLzems40Q@mail.gmail.com>
 <9DB8DABC-0E1E-4AB0-BB11-9BC48E4C71BE@enterprisedb.com>
 <df224438-bcb5-5543-8ff6-841ce91053fb@dunslane.net>
To: Andrew Dunstan <andrew@dunslane.net>
Archived-At: 
 <https://www.postgresql.org/message-id/BA6C2DC4-A169-4239-B7E2-B4F73EA908E3%40enterprisedb.com>
Precedence: bulk


> On Dec 13, 2021, at 12:56 PM, Andrew Dunstan <andrew@dunslane.net> =
wrote:
>=20
> This patch had bit-rotted slightly, and I was attempting to remedy it.

I have that already, and getting ready to post.  Give me a few minutes =
and I'll repost.

> However, I got a failure running the TAP tests because of this change:
>=20
>=20
> diff --git a/src/test/modules/test_pg_dump/t/001_base.pl
> b/src/test/modules/test_pg_dump/t/001_base.pl
> index 16f7610883..7fbf2d871b 100644
> --- a/src/test/modules/test_pg_dump/t/001_base.pl
> +++ b/src/test/modules/test_pg_dump/t/001_base.pl
> @@ -9,7 +9,12 @@ use PostgreSQL::Test::Cluster;
>  use PostgreSQL::Test::Utils;
>  use Test::More;
> =20
> -my $tempdir       =3D PostgreSQL::Test::Utils::tempdir;
> +# my $tempdir       =3D PostgreSQL::Test::Utils::tempdir;
> +my $tempbase =3D '/tmp/test_pg_dump';
> +my $subdir =3D 0;
> +$subdir++ while (-e "$tempbase/$subdir");
> +my $tempdir =3D "$tempbase/$subdir";
> +system("mkdir $tempdir");
> =20
>=20
>=20
> What's going on here?

Yeah, I hit that, too.  That was an accidentally committed bit of local =
testing.  Please ignore it for now.


=E2=80=94
Mark Dilger
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company