Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.300.41.1.7\))
Subject: Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM
 on-access)
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <CALdSSPjnnXyJ3Ma6VTfYOT2KvOf_f6poMrPtAjNc5V2iFSE8Vw@mail.gmail.com>
Date: Fri, 30 Jan 2026 16:09:34 +0500
Cc: Melanie Plageman <melanieplageman@gmail.com>,
 Alexander Lakhin <exclusion@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 Chao Li <li.evan.chao@gmail.com>,
 Xuneng Zhou <xunengzhou@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Heikki Linnakangas <hlinnaka@iki.fi>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BB281DFF-1260-433C-89A3-14953297D800@yandex-team.ru>
References: <CABPTF7X1X810eT7hjRz9M69sjMv1Vui5gXQEGhqYXmkmywhHCQ@mail.gmail.com>
 <CAAKRu_ZcK+ez71W7j+QzMo0gSafTsbGA3TU-fVSptw7yh41BEQ@mail.gmail.com>
 <6BC5DBAB-6084-4BB8-8450-52E9648AB021@gmail.com>
 <CAAKRu_ZCjHoRPfQ8AbMrFY8TOMCPAvZ0_m9SX7yg0edfTk45-g@mail.gmail.com>
 <7F5BCD7A-764D-4D8D-8E27-6F2CAAEA1CEE@gmail.com>
 <CAAKRu_a04jbDACwzRYwzDND31aPyf7Yvz9TAZrTr=+F5bK1aVA@mail.gmail.com>
 <CALdSSPjcv25jmXm29X-MRWZBae6+HwcWfVH1PE8NfD=EMTnkAg@mail.gmail.com>
 <CAAKRu_bwtBEzDwemyim1r6yYonw7FTyFr1HXG8vywCe-MdbPBQ@mail.gmail.com>
 <4379FDA3-9446-4E2C-9C15-32EFE8D4F31B@yandex-team.ru>
 <CAAKRu_YQd=2KvomM+RHcpeDKj0bq+peJ=3W-fip+pkvzA-Jq9w@mail.gmail.com>
 <7ib3sa55sapwjlaz4sijbiq7iezna27kjvvvar4dpgkmadml6t@gfpkkwmdnepx>
 <CAAKRu_bs+gZ83QDacmBxunPvCGnXJ05hxP2BDPJ3BGwdbGRXzg@mail.gmail.com>
 <2b09fba6-6b71-497a-96ef-a6947fcc39f6@gmail.com>
 <CALdSSPjUUfdb5tL0hdH9m3PzRePDSFDBV-jfAj6BdzGE-8SBtw@mail.gmail.com>
 <CAAKRu_ZnJiLaQD_pcTN=KGPHt3m-XirR+=Jj3OqURghPmu01yg@mail.gmail.com>
 <CALdSSPhFrQ4=N6yJ0N4pQ=RKjeSfU7N3wz7xpLTwsUjLc-6Tdg@mail.gmail.com>
 <CALdSSPjnnXyJ3Ma6VTfYOT2KvOf_f6poMrPtAjNc5V2iFSE8Vw@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/BB281DFF-1260-433C-89A3-14953297D800%40yandex-team.ru>
Precedence: bulk

Well, converting to TAP seems feasible to me. This will make test more =
stable.

> On 30 Jan 2026, at 14:59, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>=20
> I use 'autovacuum-worker-start' injection point to 'disable'
> autovacuum until test is done

If you just set autovacuum off - the test will be executed on bf animals =
that has no injection points.

Also
x4mmm@x4mmm-osx postgres % git am =
~/Downloads/v1-0001-Reimplement-regression-tests-from-21796c267-as-TA.patc=
h=20
Applying: Reimplement regression tests from 21796c267 as TAP-test.
.git/rebase-apply/patch:148: trailing whitespace.
# Check that vacuum phase I does not need to modify the heap buffer.  =
warning: 1 line adds whitespace errors.

There are some typos: "flakky", "introduces", "actuvity", "actaully", =
"hilding".

Test descriptions are off: you used 'page_header returned as expected' =
when it's actually about pg_visibility_map_summary.

And, of course, total lack of comments is not good.

However, in principle approach seems good to me.


(FWIW I'm looking into patches 0003-0005 of v33, I'll post when I'll =
find some nits)


Best regards, Andrey Borodin.=