Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Checkpointer write combining
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <4ECED07F-75F2-46D4-8F71-0B0DFA350777@gmail.com>
Date: Wed, 19 Nov 2025 10:09:42 +0800
Cc: Nazir Bilal Yavuz <byavuz81@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
 Andres Freund <andres@anarazel.de>
Content-Transfer-Encoding: quoted-printable
Message-Id: <BDACEACB-8066-4003-8B4F-0C8AA6D366E2@gmail.com>
References: 
 <CAAKRu_bcWRvRwZUop_d9vzF9nHAiT+-uPzkJ=S3ShZ1GqeAYOw@mail.gmail.com>
 <CAAKRu_bQWv5hJH0ncbGw8BEufAxdwMw4KY0KYuYLaw6KA=fpCA@mail.gmail.com>
 <CAN55FZ3FOv+ubp4yyFKt=Rr+ceM0tfXRDVr6nKgqSyWXh8G8Gg@mail.gmail.com>
 <CAAKRu_Yurj0sabXZB5EVqO3fKgwN1vELe1H4e0s1zXV3MKbZjQ@mail.gmail.com>
 <CAAKRu_bv2=_DU-tYFdTQJj7ohKUyFnrJvETyCes3_NpFzvVt4Q@mail.gmail.com>
 <CAAKRu_bz=t1FGXhUytPx9SC648-ozb-UxBps4zWUmS2XMg4Z4A@mail.gmail.com>
 <2FA0BAC7-5413-4ABD-94CA-4398FE77750D@gmail.com>
 <CAAKRu_atZuU3gYY6hVVuvqDW+mfXM+fCWCyYODbZPesxyr=y6g@mail.gmail.com>
 <3FC2442D-1012-4079-A009-A0B8C45E092D@gmail.com>
 <CAAKRu_b3k+KbeFhFgDZ26PvJbvL9W5HYwKrn8bBS4CTU13khpw@mail.gmail.com>
 <6B520FA8-B805-4C0D-B8B9-202B3AF168A9@gmail.com>
 <CAAKRu_Z8GtkTPsbScp8QoNF=V1YT3cVT6mPf1sR-NAtSE+jzoQ@mail.gmail.com>
 <0198DBB9-4A76-49E4-87F8-43D46DD0FD76@gmail.com>
 <CAAKRu_ZfneK9hEQs-ht2696aJ3ZSJs1c_-rXzBmyKjPDYRnqgA@mail.gmail.com>
 <4ECED07F-75F2-46D4-8F71-0B0DFA350777@gmail.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/BDACEACB-8066-4003-8B4F-0C8AA6D366E2%40gmail.com>
Precedence: bulk


> On Nov 19, 2025, at 10:00, Chao Li <li.evan.chao@gmail.com> wrote:
>=20
>=20
>=20
>> On Nov 19, 2025, at 02:49, Melanie Plageman =
<melanieplageman@gmail.com> wrote:
>>=20
>> I no longer remember why I made that patch WIP, so I've removed that
>> designation.
>=20
> I just reviewed 0007. It removes the second parameter "bool =
skip_recently_used=E2=80=9D  from SyncOneBuffer. The function is static =
and is only called in one place with skip_recently_used=3Dtrue, thus =
removing the parameter seems reasonable, and without considering pinned =
buffer, the function is simplified a little bit.
>=20
> I only got a tiny comment:
> ```
> + * We can make these check without taking the buffer content lock so
> ```=20
>=20
> As you changed =E2=80=9Cthis=E2=80=9D to =E2=80=9Cthese=E2=80=9D, =
=E2=80=9Ccheck=E2=80=9D should be changed to =E2=80=9Cchecks=E2=80=9D =
accordingly.
>=20

I just got an compile error:
```
bufmgr.c:3580:33: error: no member named 'dbId' in 'struct CkptSortItem'
 3580 |                                 batch.rlocator.dbOid =3D =
item.dbId;
      |                                                        ~~~~ ^
bufmgr.c:3598:13: error: no member named 'dbId' in 'struct CkptSortItem'
 3598 |                         if (item.dbId !=3D batch.rlocator.dbOid)
      |                             ~~~~ ^
2 errors generated.
make[4]: *** [bufmgr.o] Error 1
```

I tried =E2=80=9Cmake clean=E2=80=9D and =E2=80=9Cmake=E2=80=9D again, =
which didn=E2=80=99t work. I think the error is introduced by 0006.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/