public inbox for [email protected]
help / color / mirror / Atom feedUnexpected message truncation in WaitForAllTransactionsToFinish
2+ messages / 2 participants
[nested] [flat]
* Unexpected message truncation in WaitForAllTransactionsToFinish
@ 2026-06-05 08:30 =?utf-8?B?Y2NhNTUwNw==?= <[email protected]>
0 siblings, 1 reply; 2+ messages in thread
From: =?utf-8?B?Y2NhNTUwNw==?= @ 2026-06-05 08:30 UTC (permalink / raw)
To: =?utf-8?B?cGdzcWwtaGFja2Vycw==?= <[email protected]>; =?utf-8?B?ZGFuaWVs?= <[email protected]>
Hi,
In WaitForAllTransactionsToFinish():
```
char activity[64];
int rc;
/* Oldest running xid is older than us, so wait */
snprintf(activity,
sizeof(activity),
"Waiting for current transactions to finish (waiting for %u)",
waitforxid);
pgstat_report_activity(STATE_RUNNING, activity);
```
The buffer is not big enough to hold the message if the 'waitforxid' is too big.
How about changing the message to this:
"Waiting for transactions older than %u to finish"
--
Regards,
ChangAo Chen
^ permalink raw reply [nested|flat] 2+ messages in thread
* Re: Unexpected message truncation in WaitForAllTransactionsToFinish
@ 2026-06-05 09:45 Daniel Gustafsson <[email protected]>
parent: =?utf-8?B?Y2NhNTUwNw==?= <[email protected]>
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Gustafsson @ 2026-06-05 09:45 UTC (permalink / raw)
To: cca5507 <[email protected]>; +Cc: pgsql-hackers <[email protected]>
> On 5 Jun 2026, at 10:30, cca5507 <[email protected]> wrote:
> The buffer is not big enough to hold the message if the 'waitforxid' is too big.
Nice catch, will fix.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2026-06-05 09:45 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-06-05 08:30 Unexpected message truncation in WaitForAllTransactionsToFinish =?utf-8?B?Y2NhNTUwNw==?= <[email protected]>
2026-06-05 09:45 ` Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox