From: "Amonson, Paul D" <paul.d.amonson@intel.com>
To: "Amonson, Paul D" <paul.d.amonson@intel.com>, Nathan Bossart
	<nathandbossart@gmail.com>
CC: Tom Lane <tgl@sss.pgh.pa.us>, David Rowley <dgrowleyml@gmail.com>, "Andres
 Freund" <andres@anarazel.de>, Alvaro Herrera <alvherre@alvh.no-ip.org>,
	"Shankaran, Akash" <akash.shankaran@intel.com>, Noah Misch
	<noah@leadboat.com>, Matthias van de Meent <boekewurm+postgres@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: RE: Popcount optimization using AVX512
Thread-Topic: Popcount optimization using AVX512
Thread-Index: AdoNliAXaie8RHrzTICrAiLVKKiYCgAsQKyAALaJTAAAAQ7nAAAAxSWAAAGNHgAAA/mZgAAeFdGAAZKQbBAAAw6egA3NuLcAAAvVM4ACbQuxsAAhlXkAAHPWMbAAAkOrAACYCUjgAAMc3wABvefW4AD8TV6wADf+AoAAmWkVgACOpocAAAl+RwAAJXNxYAAA1VoAAABadxAAZi2hAAAIeekAAMiJepAACPYvAAAbpMKQAJeTLYAAcNGUAAAm2oYAAAFGgCAAAIPdAAACb8MAAAdpgwAAADR0AAAAsQcAAAAMEoAAAWCPgAAC3eIAACrnWQAABeBEkAA1zxYAACb9mpAAwL24cAAATJYAAAAxGQAABx2FwABrjaAVAADz8kAAMJJ6AAAAVz0wAAEtAtA=
Date: Thu, 28 Mar 2024 22:29:47 +0000
Message-ID: <BL1PR11MB5304217FFEFB15124CD2EC9EDC3B2@BL1PR11MB5304.namprd11.prod.outlook.com>
References: <BL1PR11MB530414B036FD7E838830E398DC2C2@BL1PR11MB5304.namprd11.prod.outlook.com>
 <CAApHDvrf-oKJ-mCrFZ_g-fZpRrCXJrKcZobwtUgzi0R5aXtVxQ@mail.gmail.com>
 <BL1PR11MB530478ACABE588A836338E74DC322@BL1PR11MB5304.namprd11.prod.outlook.com>
 <BL1PR11MB53040D8E18518B2BDA4BB83ADC362@BL1PR11MB5304.namprd11.prod.outlook.com>
 <2490633.1711379522@sss.pgh.pa.us>
 <BL1PR11MB53043014C10F2D30B4231F9ADC362@BL1PR11MB5304.namprd11.prod.outlook.com>
 <BL1PR11MB53049F1796E834DBE0E05864DC362@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240325200551.GB2924132@nathanxps13> <20240327220010.GA231058@nathanxps13>
 <BL1PR11MB53047289F146DB43C9B2FC71DC342@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240328213854.GA916732@nathanxps13>
 <BL1PR11MB5304E51336123CE6F041A920DC3B2@BL1PR11MB5304.namprd11.prod.outlook.com>
In-Reply-To: <BL1PR11MB5304E51336123CE6F041A920DC3B2@BL1PR11MB5304.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?lld5dwayXBHQiSBxYdeRz6EwHxdm4q5wzCfL/YlZaoLA2LyoBXHEDamIx3vd?=
 =?us-ascii?Q?UKKhA/bfZJaaM4gyGxREv7GIq+tMN6LYz+CIgavXj+oGrXIYw53ZVGoCU4Nf?=
 =?us-ascii?Q?kLej3wTWH2nPI/RW/u53l+2XidT7mES4RGbDQ9mDV3Soskg1ZKAHGHPmPpMJ?=
 =?us-ascii?Q?4AF+49l6h2V26ZIaDdyke8F2nWFh+BnWy+ny5sNN8QQepUjvFmO3CUk0GJgy?=
 =?us-ascii?Q?ZNOhoTSChh3KZb/71OZC2P5an20dUC0DsMFy0EkjJLe+uv96PJzvCm+RpZWU?=
 =?us-ascii?Q?xNkT5Y5ZTy9VbP75Yyqn9NDj25K6UrwnAFYcSu2O3UXUcXHn/F3m+O/JZ/Nd?=
 =?us-ascii?Q?9ANKWtqlyX1zHck1JKztFpU1/zgD/eRKr09dKRxI8V6+/jWKl/oUodqsX/aS?=
 =?us-ascii?Q?e13Wz+5pNs2KCJlJJSILmoCI2ZKcztLjvLx7isdzTBK/kPMOrhH5NFXzHbiY?=
 =?us-ascii?Q?JMYs6g/vYbdiU0WGJli13lWukpkaAy4/99i9v2ILeIXC/HCppYXyaalr+KpP?=
 =?us-ascii?Q?TkRLKsJFnWpP0rgeAkJ8PFTc5gzXmxrrsjd2oNAdlBGJxoDo/lSWMtK310c1?=
 =?us-ascii?Q?fS3qXG65c2C6MgkKP2KtwNT/WgqXOwNi+cKYRGkvPKhNtWBiwfFeQWuL7b8l?=
 =?us-ascii?Q?BHIISlzUDehbmdX0Ac5FMGvURKg0i1LFpXRuDRsNVnriDbHqkXflfuz3b4q2?=
 =?us-ascii?Q?3ol+utLOdNMVqad24guxDKmzbZKhwC/VpmLoy/MQOQBm7EXNX1FuhEz2hOtD?=
 =?us-ascii?Q?MQ+ck7/nLJlv4fdjVki5d+cDbTEXVxzAxgUTckpZfxSbpOxbHjJRXUrMt+BS?=
 =?us-ascii?Q?74HwjMVLgYR0T1s66gS6ev7uFVEI8TI37+oHCmHtdWZ+rTrnFcW0FOHbCQqr?=
 =?us-ascii?Q?AJVOBCfbyt9Ax5k0LgRy3FzdXoBV9ZSDqs5WXfLcYQrVbjbYJw943JgM/O1W?=
 =?us-ascii?Q?zdeyDk9loIp+Tk068+38LX+iK/p527Sgv2Q3C/D/qdwHipoy0aBlT7oKbNDJ?=
 =?us-ascii?Q?Hxgs0wIJehG5OWZJBkAf8fOKZiSIKzoq3w9Oo8qFhIHnnyNva30zeklc10Eh?=
 =?us-ascii?Q?R/Vsl7muLpKvnJI0M7rnzO20YO20fFD550dQyo8Hxd7xUVKLeAjz7nBxDa0x?=
 =?us-ascii?Q?P+meodWwEJ1/2LPvO9luYwc3UFBHtKilBW5bIkGrK8+bSQJuY86iJEs2e4MM?=
 =?us-ascii?Q?bjIDhIi4adYd5DqnQ0Ew4IxgZHom1iiKQfBEtc03o9XL/nag2rJL0kiAgOhC?=
 =?us-ascii?Q?Jy7fTf02x8URPZbNqKAk/KrbKqkdIyaeZWBCoCHMN7yMlQ/lJM6RnntrG5hi?=
 =?us-ascii?Q?mlSGXKPpNwRBfITkpZ3w0Z1L+VVrwzHbpArShsJFVm9sodEPYetTj5S6mTDT?=
 =?us-ascii?Q?WK6JCmbidL9NBEYPbmZwhBT3fxMw+M/9Etjw8s9ZSu2mzcBm+jtLIC+dBKNq?=
 =?us-ascii?Q?p8HDrLMjF4+9nUPfAzG1HmYOoAOTt5S1olL7Vfg6k5JNBCSroMPGEt92nfxV?=
 =?us-ascii?Q?p2cvgs0xtoMWGALf01RhcYlWtXmK98QudETP4YX5TvV6akrwVuSICtXinPqe?=
 =?us-ascii?Q?qMY4r0IUtWNExY+vM7j03uLtSfk5unWivwECy7no?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43b4030f-ef30-4851-17b9-08dc4f769390
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Mar 2024 22:29:47.9839
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OMemBScsUQZzo3807J7FFMjNCG82F8kKqr/Cnp7yrWXkT8tRdBHbfxGsIw0vSiEJZ2A4Xv8nmpRH2qiWFHqAb3li3LeQHiGqCecpwP3hWPY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8518
X-OriginatorOrg: intel.com
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/BL1PR11MB5304217FFEFB15124CD2EC9EDC3B2%40BL1PR11MB5304.namprd11.prod.outlook.com>
Precedence: bulk

> -----Original Message-----
> From: Amonson, Paul D <paul.d.amonson@intel.com>
> Sent: Thursday, March 28, 2024 3:03 PM
> To: Nathan Bossart <nathandbossart@gmail.com>
> ...
> I will review the new patch to see if there are anything that jumps out a=
t me.

I see in the meson.build you added the new file twice?

@@ -7,6 +7,7 @@ pgport_sources =3D [
   'noblock.c',
   'path.c',
   'pg_bitutils.c',
+  'pg_popcount_avx512.c',
   'pg_strong_random.c',
   'pgcheckdir.c',
   'pgmkdirp.c',
@@ -84,6 +85,7 @@ replace_funcs_pos =3D [
   ['pg_crc32c_sse42', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK', 'crc'],
   ['pg_crc32c_sse42_choose', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
   ['pg_crc32c_sb8', 'USE_SSE42_CRC32C_WITH_RUNTIME_CHECK'],
+  ['pg_popcount_avx512', 'USE_AVX512_POPCNT_WITH_RUNTIME_CHECK', 'avx512_p=
opcnt'],

I was putting the file with special flags ONLY in the second section and al=
l seemed to work. :)

Everything else seems good to me.

Thanks,
Paul