From: "Amonson, Paul D" <paul.d.amonson@intel.com>
To: "Amonson, Paul D" <paul.d.amonson@intel.com>, Nathan Bossart
	<nathandbossart@gmail.com>
CC: Andres Freund <andres@anarazel.de>, Alvaro Herrera
	<alvherre@alvh.no-ip.org>, "Shankaran, Akash" <akash.shankaran@intel.com>,
	Noah Misch <noah@leadboat.com>, Tom Lane <tgl@sss.pgh.pa.us>, "Matthias van
 de Meent" <boekewurm+postgres@gmail.com>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>
Subject: RE: Popcount optimization using AVX512
Thread-Topic: Popcount optimization using AVX512
Thread-Index: AdoNliAXaie8RHrzTICrAiLVKKiYCgAsQKyAALaJTAAAAQ7nAAAAxSWAAAGNHgAAA/mZgAAeFdGAAZKQbBAAAw6egA3NuLcAAAvVM4ACbQuxsAAhlXkAAHPWMbAAAkOrAACYCUjgAAMc3wABvefW4AD8TV6wADf+AoAAmWkVgACOpocAAAl+RwAAJXNxYAAA1VoAAABadxAAZi2hAAAIeekAAMiJepAACPYvAAAbpMKQAJeTLYAAAHbzAAAEqdjQ
Date: Fri, 15 Mar 2024 17:43:39 +0000
Message-ID: <BL1PR11MB53043A425DC184F276413504DC282@BL1PR11MB5304.namprd11.prod.outlook.com>
References: <BL1PR11MB5304BFE26BAC25624508CFD2DC232@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240304222118.GB3367383@nathanxps13>
 <BL1PR11MB53047C28DDBA6A2E77B9420ADC222@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240305163730.GA3479896@nathanxps13>
 <BL1PR11MB530444AEE08A91242ABA1915DC222@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240307173318.GA455851@nathanxps13> <20240307213600.GA563369@nathanxps13>
 <BL1PR11MB5304165E7A81E0107E70B069DC242@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240312013436.GA1787866@nathanxps13>
 <BL1PR11MB53042473B7B53B96E43648A7DC292@BL1PR11MB5304.namprd11.prod.outlook.com>
 <20240315150611.GA3495582@nathanxps13>
 <BL1PR11MB530473FB4E9CBD68C28896F7DC282@BL1PR11MB5304.namprd11.prod.outlook.com>
In-Reply-To: <BL1PR11MB530473FB4E9CBD68C28896F7DC282@BL1PR11MB5304.namprd11.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?HWpBuL13oN5VzvLe7VYDPcZ1Iyk0VQ8DgfD7csQFOaGOmN/KS5Bk78KA9FAw?=
 =?us-ascii?Q?Ke5wW215bBadejVb5IQHENvbBinrxW0PLRZIU2eaN4DlAR8rNqtalObxWSwj?=
 =?us-ascii?Q?OWSwx7KNX16yfWQhNs24a31yAtSdtA83c5ReoC2iiKvRHZurncd0Tjij2823?=
 =?us-ascii?Q?7P9Ze/actrII1RLCWhEoLBO4cBHRtBuxIBvZpGcoQiIXQ6dQc/I64x63tuf2?=
 =?us-ascii?Q?9ONf4QGx3T6DRQy8mh/TWWCPwnruJP4FDExzYsIggwRvWRkxqicMdyqlXuoE?=
 =?us-ascii?Q?qjsEnYroV7Dl5WBvtdVefZpj4ENUxNBb4HIWvVWGVSnL/JPjvsxTSlJHdtZ9?=
 =?us-ascii?Q?KbvwVanmh4jhguUFL3ImTjBEXh4LWl7PMN+2jde2XNV9oCz9ieDBAgSCw/iX?=
 =?us-ascii?Q?/E2FTLyKGEdG1DWUxpcQjhGYuBhMl//FBDRHuGEltvXRHG7GUjQvOo09X4F/?=
 =?us-ascii?Q?klFrcYd6+CCriiu9Ip4553txiWlUvRizR1/6WBKLsojwjy02SW8OBaYuPzYZ?=
 =?us-ascii?Q?WhiusSiODxN67+OoCO4NEtoK5u7QX7dv7xOX5ToZ1Ri1MAIg4JfX3vXndRfK?=
 =?us-ascii?Q?X6mOiHSRJDd0UMKQuiuQKeH22dZmh7tgTmxPGvme8U1xofEg3Vs5S3gT4zx1?=
 =?us-ascii?Q?RN8o3/+cLrQVwcVKaw0rZk8yFYCf5nLV8YZEsxyrVv2tsL7BIHrM1+lawN/N?=
 =?us-ascii?Q?LYE86kcotKHHiXoOwSO0kTfSQ22QyA97lIYnQi/HHG+2ypDx3uFuD6Qn939+?=
 =?us-ascii?Q?dgqs9g+ZHDSI8CF8abkD8SykdpNzJYf+o4maugP+bu32j0GOwy4/V54bs1dn?=
 =?us-ascii?Q?TXmg8lhgLeowJhGvPKsPyMkFHsZBcVLSe/Aj+MXlCWvGdHtI0gNkEEDh5l6d?=
 =?us-ascii?Q?PlC3m5pwFUTDiSG6bN2VVU4uBDU+UhMSBVBm6wWH9m+e/n/6U2YtVPKQ7o9M?=
 =?us-ascii?Q?VKsLrnuT9lHxvh+xr2G43Gz290MiCzPb3OLIAfm9byt4DNrFjlHjz7HMko5z?=
 =?us-ascii?Q?UcKQCxXzLAjrntTjgUVdqibWWZRwXnO+bbjHLvXbd47mGVTRN+SedQA4kSPd?=
 =?us-ascii?Q?TaXJvpwSWszB6TJ7OOtZNbqk1RpB70sl9X2rn+0QSaLv9NBLU3OMex4EgMpc?=
 =?us-ascii?Q?vIJ07qY7oPaxLEkDueArAmoscRR/1uWyj5d+Y8OsSyayl1fnRti5SrarXqKd?=
 =?us-ascii?Q?W/7/CMFq21gr5+aSo6eG2kEbvqLSWMuOMxvGpph9GElDmmunqahGISqyfD+f?=
 =?us-ascii?Q?oj1sZL8bgUq3PvpW+hnWKiFlvNzYkSP8oduRlBKPBdinzqKp2Gq7lTAgDIiL?=
 =?us-ascii?Q?4dmBPIEZfzECMxZrZymEPQX2HG30ha1Gpk4etqYuO9vxP+nppWpbkZHQ0bOf?=
 =?us-ascii?Q?cLdD3Ibfi7nGtdEg9++ALmvZc11mJGe7CoH/FZLIP+8GXzhAfsEDKiLn1b9s?=
 =?us-ascii?Q?dB7PX+HKETCsEPYbjsxjHup2IukOUq2kMuQEHiyhtXqLOEwkpL5E+Dpd0zoH?=
 =?us-ascii?Q?OLBeUZ9VmFi7iISxenJYMlESJSgEjXYNhxuVhNO6X+MWFQjTXayc1uOztY1B?=
 =?us-ascii?Q?obcxxt3lCaTNtadmiZQ/Ik75MWtDLL0ys7LC6c5d?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5304.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef86f8f2-29e3-4ca5-4742-08dc45177341
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2024 17:43:39.9735
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 64q5kerKTDzUilmgJLtENBJ3xleOdhG1H7WYzZyxSE63CHRH+ScwGLqoO2cAyHSx+NNIrfg7g+jRY1ehqYvE506dPjfAJiy5K2qeeMTGn8M=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7881
X-OriginatorOrg: intel.com
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/BL1PR11MB53043A425DC184F276413504DC282%40BL1PR11MB5304.namprd11.prod.outlook.com>
Precedence: bulk

> -----Original Message-----
> From: Amonson, Paul D <paul.d.amonson@intel.com>
> Sent: Friday, March 15, 2024 8:31 AM
> To: Nathan Bossart <nathandbossart@gmail.com>
...
> When I tested the code outside postgres in a micro benchmark I got 200-
> 300% improvements. Your results are interesting, as it implies more than
> 300% improvement. Let me do some research on the benchmark you
> referenced. However, in all cases it seems that there is no regression so=
 should
> we move forward on merging while I run some more local tests?

When running quick test with small buffers (1 to 32K) I see up to about a 7=
40% improvement. This was using my stand-alone micro benchmark outside of P=
G. My original 200-300% numbers were averaged including sizes up to 512MB w=
hich seems to not run as well on large buffers.  I will try the referenced =
micro benchmark on Monday. None of my benchmark testing used the command li=
ne "time" command. For Postgres is set "\timing" before the run and for the=
 stand-alone benchmark is took timestamps in the code. In all cases I used =
-O2 for optimization.

Thanks,
Paul