Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\))
Subject: Re: Implement waiting for wal lsn replay: reloaded
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <202512300309.ob42gaafej7v@alvherre.pgsql>
Date: Tue, 30 Dec 2025 11:24:37 +0800
Cc: Xuneng Zhou <xunengzhou@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andres Freund <andres@anarazel.de>,
 Michael Paquier <michael@paquier.xyz>,
 jian he <jian.universality@gmail.com>,
 Tomas Vondra <tomas@vondra.me>,
 Yura Sokolov <y.sokolov@postgrespro.ru>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C015C9FA-5FCE-4984-9F82-F1F2BC0EACF3@gmail.com>
References: <202512300309.ob42gaafej7v@alvherre.pgsql>
To: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Archived-At: 
 <https://www.postgresql.org/message-id/C015C9FA-5FCE-4984-9F82-F1F2BC0EACF3%40gmail.com>
Precedence: bulk


> On Dec 30, 2025, at 11:14, =C3=81lvaro Herrera <alvherre@kurilemu.de> =
wrote:
>=20
> On 2025-Dec-27, Xuneng Zhou wrote:
>=20
>> On Fri, Dec 26, 2025 at 4:25=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>=20
>>> 2 - 0002
>>> ```
>>> +                       else
>>> +                               ereport(ERROR,
>>> +                                               =
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
>>> +                                                =
errmsg("unrecognized value for WAIT option \"%s\": \"%s\"",
>>> +                                                               =
"MODE", mode_str),
>>> ```
>>>=20
>>> I wonder why don=E2=80=99t we directly put MODE into the error =
message?
>>=20
>> Yeah, putting MODE into the error message is cleaner. It's done in =
v8.
>=20
> The reason not to do that (and also put WAIT in a separate string) is =
so
> that the message is identicla to other messages and thus requires no
> separate translation, specifically
>  errmsg("unrecognized value for %s option \"%s\": \"%s\"", ...)
>=20
> See commit 502e256f2262.  Please use that form.
>=20

To follow 502e256f2262, it should use =E2=80=9C%s=E2=80=9D for =
=E2=80=9CWAIT=E2=80=9D as well. I raised the comment because I saw =
=E2=80=9CWAIT=E2=80=9D is the format strings, thus =E2=80=9CMODE=E2=80=9D =
can be there as well.

So, we should do a similar change like:
```
-                                                errmsg("unrecognized =
value for EXPLAIN option \"%s\": \"%s\"",
-                                                               =
opt->defname, p),
+                                                errmsg("unrecognized =
value for %s option \"%s\": \"%s\"",
+                                                               =
"EXPLAIN", opt->defname, p),
```

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/