Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qy6j6-005zCq-B0 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Nov 2023 08:37:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qy6j4-006GFy-U3 for pgsql-hackers@arkaria.postgresql.org; Wed, 01 Nov 2023 08:37:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qy6j4-006GFq-Kg for pgsql-hackers@lists.postgresql.org; Wed, 01 Nov 2023 08:37:22 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qy6iy-0047g6-1T for pgsql-hackers@lists.postgresql.org; Wed, 01 Nov 2023 08:37:21 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 5A4FD2FBD367 for ; Wed, 1 Nov 2023 09:37:14 +0100 (CET) Received: from s981.loopia.se (unknown [172.22.191.5]) by s807.loopia.se (Postfix) with ESMTP id 4B2462E274C5; Wed, 1 Nov 2023 09:37:14 +0100 (CET) Received: from s471.loopia.se (unknown [172.22.191.6]) by s981.loopia.se (Postfix) with ESMTP id 4980322B1779; Wed, 1 Nov 2023 09:37:14 +0100 (CET) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s979.loopia.se ([172.22.191.5]) by s471.loopia.se (s471.loopia.se [172.22.190.35]) (amavisd-new, port 10024) with UTF8LMTP id Vw-_0Fu8qTfh; Wed, 1 Nov 2023 09:37:13 +0100 (CET) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s979.loopia.se (Postfix) with ESMTPSA id DDBD810BC40D; Wed, 1 Nov 2023 09:37:13 +0100 (CET) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.3\)) Subject: Re: Wrong function name in pgstatfuncs.c From: Daniel Gustafsson In-Reply-To: <20231101.172308.1740861597185391383.horikyota.ntt@gmail.com> Date: Wed, 1 Nov 2023 09:37:13 +0100 Cc: pgsql-hackers@lists.postgresql.org Content-Transfer-Encoding: 7bit Message-Id: References: <20231101.172308.1740861597185391383.horikyota.ntt@gmail.com> To: Kyotaro Horiguchi X-Mailer: Apple Mail (2.3696.120.41.1.3) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 1 Nov 2023, at 09:23, Kyotaro Horiguchi wrote: > > Since pgstatfuncs.c was refactored, the comments for synthesized > function names are significant to find the function body. > > I happened to find a misspelling among the function name > comments. "pg_stat_get_mods_since_analyze" should be > "pg_stat_get_mod_since_analyze". > > Upon checking the file using a rudimentary script, I found no other > similar mistakes in the same file. Nice catch, that's indeed a tiny typo, will fix. -- Daniel Gustafsson