Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Add missing period to HINT messages
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: 
 <CAJSLCQ08y3pECMLyLE7-GKZ9n3mHRx3Pru0ji_W0y0GX0O5zjg@mail.gmail.com>
Date: Tue, 14 Apr 2026 09:10:42 +0800
Cc: Amit Kapila <amit.kapila16@gmail.com>,
 Peter Smith <smithpb2250@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <C2ECD6BD-BA75-4E15-A884-A821ECE71BF0@gmail.com>
References: 
 <CAHut+PvikGr4AtoFSs=jq=hmTybVF2NCMEZ57-sjwbGudfuqsQ@mail.gmail.com>
 <9FE5AA84-F1A1-4E1C-8EF8-3AFD6C46B318@gmail.com>
 <CAHut+PsUQfddBnjE9m1x4aoWAgRMEnsVFeg2cZJt9BCC_nbwfg@mail.gmail.com>
 <0B7E46E8-EA1B-48AA-A1A5-BC39B5073D40@gmail.com>
 <CAHut+PuxV8wAULnNv+i1_YKyvDrD7jvWne48Yf82e3hRR=+qQw@mail.gmail.com>
 <CABV9wwPNeMM9wrtYtwmG_F6y=-f8hcnPbeVMmgXE4DEaZkFQew@mail.gmail.com>
 <CAHut+PsdwfnT3yMM8r9y7c5MZU2sv27JJd2riFipdQ8PvXs7Dw@mail.gmail.com>
 <CAA4eK1JmqgZQ9HRvF6t7Eie6Z4sDGAEyH5fYbt1F69tvwLFUdQ@mail.gmail.com>
 <CAJSLCQ08y3pECMLyLE7-GKZ9n3mHRx3Pru0ji_W0y0GX0O5zjg@mail.gmail.com>
To: Robert Treat <rob@xzilla.net>
Archived-At: 
 <https://www.postgresql.org/message-id/C2ECD6BD-BA75-4E15-A884-A821ECE71BF0%40gmail.com>
Precedence: bulk


> On Apr 14, 2026, at 08:39, Robert Treat <rob@xzilla.net> wrote:
>=20
> On Mon, Apr 13, 2026 at 4:28=E2=80=AFAM Amit Kapila =
<amit.kapila16@gmail.com> wrote:
>> On Mon, Apr 13, 2026 at 6:32=E2=80=AFAM Peter Smith =
<smithpb2250@gmail.com> wrote:
>>> On Fri, Apr 10, 2026 at 11:10=E2=80=AFPM Robert Treat =
<rob@xzilla.net> wrote:
>>>>=20
>>>> On Thu, Apr 9, 2026 at 9:05=E2=80=AFPM Peter Smith =
<smithpb2250@gmail.com> wrote:
>>>>> On Thu, Apr 9, 2026 at 1:34=E2=80=AFPM Chao Li =
<li.evan.chao@gmail.com> wrote:
>>>>>>=20
>>>>> ...
>>>>>>=20
>>>>>> I am not sure if your scope includes contrib/, if yes, I am sure =
you will find some occurrences there.
>>>>>>=20
>>>>>=20
>>>>> Updated one more message found in contrib.
>>>>>=20
>>>>> PSA v2.
>>>>>=20
>>>>=20
>>>> +1 to the general idea here, although at the risk of looking at
>>>> patches before the morning coffee has settled in, ISTM you might =
have
>>>> missed some entries? And/or this patch isn't against HEAD?  For
>>>> example, you seem to be catching the line here
>>>> =
https://github.com/postgres/postgres/blame/009ea1b08d7b8843435bd0f1137fa3d=
f09aac79f/src/test/regress/expected/partition_split.out#L60,
>>>> but not the one on line 52, maybe because it looks like a comment =
(but
>>>> istm we should clean these all up. no?)
>>>>=20
>>>=20
>>> Thanks for your review!
>>>=20
>>> Yes, the patch applies to HEAD. It looks like I was a bit slack in
>>> updating some test comments. Hopefully, I have found them all now.
>>>=20
>>=20
>> BTW, I find such a code cleanup exercise can be done even after
>> feature freeze. If so, shall we do it as a HEAD-only patch or do it =
in
>> bank branches as well?
>>=20
>=20
> I don't have a strong opinion on it, but I think generally that clean
> up patches (where we aren't fixing some kind of document mistake or
> misleading information) generally just go into HEAD for the next
> release, though if it easily applies cleanly to back branches and you
> want to do it, it's probably ok to apply it backwards, but I wouldn't
> spend any time on it if it didn't.
>=20
> Robert Treat
> https://xzilla.net

I don=E2=80=99t see a branch for 19 is cut out, so is HEAD still 19 =
today?

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/