From: Daniel Gustafsson <daniel@yesql.se>
Content-Type: multipart/mixed;
	boundary="Apple-Mail=_0024AF68-445F-4B80-865E-B9F3DBD923A2"
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.600.62\))
Subject: Additional minor pg_dump cleanups
Message-Id: <C2F05B3C-1414-45DD-AE09-6FEE4D0F89BD@yesql.se>
Date: Wed, 3 Jul 2024 09:37:32 +0200
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Archived-At: <https://www.postgresql.org/message-id/C2F05B3C-1414-45DD-AE09-6FEE4D0F89BD%40yesql.se>
Precedence: bulk


--Apple-Mail=_0024AF68-445F-4B80-865E-B9F3DBD923A2
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

Re-reading Nathans recent 8213df9effaf I noticed a few more small things =
which
can be cleaned up.  In two of the get<Object> functions we lack a =
fast-path for
when no tuples are found which leads to pg_malloc(0) calls.  Another =
thing is
that we in one place reset the PQExpBuffer immediately after creating it =
which
isn't required.

--
Daniel Gustafsson


--Apple-Mail=_0024AF68-445F-4B80-865E-B9F3DBD923A2
Content-Disposition: attachment;
	filename=0001-Remove-superfluous-PQExpBuffer-resetting.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0001-Remove-superfluous-PQExpBuffer-resetting.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=20f1a0952d441dfcfe45e77d939598b427c1e40bb9=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20=
<dgustafsson@postgresql.org>=0ADate:=20Wed,=203=20Jul=202024=2009:11:05=20=
+0200=0ASubject:=20[PATCH=201/2]=20Remove=20superfluous=20PQExpBuffer=20=
resetting=0A=0ASince=20the=20buffer=20was=20just=20created,=20there=20is=20=
no=20reason=20to=20immediately=0Areset=20it.=0A---=0A=20=
src/bin/pg_dump/pg_dump.c=20|=202=20--=0A=201=20file=20changed,=202=20=
deletions(-)=0A=0Adiff=20--git=20a/src/bin/pg_dump/pg_dump.c=20=
b/src/bin/pg_dump/pg_dump.c=0Aindex=207aec016a9f..7ccf943522=20100644=0A=
---=20a/src/bin/pg_dump/pg_dump.c=0A+++=20b/src/bin/pg_dump/pg_dump.c=0A=
@@=20-4198,8=20+4198,6=20@@=20getPublications(Archive=20*fout)=0A=20=0A=20=
=09query=20=3D=20createPQExpBuffer();=0A=20=0A-=09=
resetPQExpBuffer(query);=0A-=0A=20=09/*=20Get=20the=20publications.=20*/=0A=
=20=09if=20(fout->remoteVersion=20>=3D=20130000)=0A=20=09=09=
appendPQExpBufferStr(query,=0A--=20=0A2.39.3=20(Apple=20Git-146)=0A=0A=

--Apple-Mail=_0024AF68-445F-4B80-865E-B9F3DBD923A2
Content-Disposition: attachment;
	filename=0002-Add-fastpaths-for-when-no-objects-are-found.patch
Content-Type: application/octet-stream;
	x-unix-mode=0644;
	name="0002-Add-fastpaths-for-when-no-objects-are-found.patch"
Content-Transfer-Encoding: quoted-printable

=46rom=204777fc98ee642b99c2bdab250e2a6311ee3022e6=20Mon=20Sep=2017=20=
00:00:00=202001=0AFrom:=20Daniel=20Gustafsson=20=
<dgustafsson@postgresql.org>=0ADate:=20Wed,=203=20Jul=202024=2009:12:12=20=
+0200=0ASubject:=20[PATCH=202/2]=20Add=20fastpaths=20for=20when=20no=20=
objects=20are=20found=0A=0AIf=20there=20are=20no=20objects=20found,=20=
there=20is=20no=20reason=20to=20inspect=20the=0Aresult=20columns=20and=20=
mallocing=20a=20zero-sized=20(which=20will=20be=201=20byte=0Ain=20=
reality)=20heap=20buffer=20for=20it.=20Add=20fast-paths=20like=20how=20=
other=0Aobject=20inspection=20functions=20are=20already=20doing=20it.=0A=
---=0A=20src/bin/pg_dump/pg_dump.c=20|=208=20++++++++=0A=201=20file=20=
changed,=208=20insertions(+)=0A=0Adiff=20--git=20=
a/src/bin/pg_dump/pg_dump.c=20b/src/bin/pg_dump/pg_dump.c=0Aindex=20=
7ccf943522..6e0ddb637e=20100644=0A---=20a/src/bin/pg_dump/pg_dump.c=0A=
+++=20b/src/bin/pg_dump/pg_dump.c=0A@@=20-4222,6=20+4222,9=20@@=20=
getPublications(Archive=20*fout)=0A=20=0A=20=09ntups=20=3D=20=
PQntuples(res);=0A=20=0A+=09if=20(ntups=20=3D=3D=200)=0A+=09=09goto=20=
cleanup;=0A+=0A=20=09i_tableoid=20=3D=20PQfnumber(res,=20"tableoid");=0A=20=
=09i_oid=20=3D=20PQfnumber(res,=20"oid");=0A=20=09i_pubname=20=3D=20=
PQfnumber(res,=20"pubname");=0A@@=20-4260,6=20+4263,8=20@@=20=
getPublications(Archive=20*fout)=0A=20=09=09/*=20Decide=20whether=20we=20=
want=20to=20dump=20it=20*/=0A=20=09=09=
selectDumpableObject(&(pubinfo[i].dobj),=20fout);=0A=20=09}=0A+=0A=
+cleanup:=0A=20=09PQclear(res);=0A=20=0A=20=09destroyPQExpBuffer(query);=0A=
@@=20-5701,6=20+5706,8=20@@=20getExtensions(Archive=20*fout,=20int=20=
*numExtensions)=0A=20=09res=20=3D=20ExecuteSqlQuery(fout,=20query->data,=20=
PGRES_TUPLES_OK);=0A=20=0A=20=09ntups=20=3D=20PQntuples(res);=0A+=09if=20=
(ntups=20=3D=3D=200)=0A+=09=09goto=20cleanup;=0A=20=0A=20=09extinfo=20=3D=20=
(ExtensionInfo=20*)=20pg_malloc(ntups=20*=20sizeof(ExtensionInfo));=0A=20=
=0A@@=20-5730,6=20+5737,7=20@@=20getExtensions(Archive=20*fout,=20int=20=
*numExtensions)=0A=20=09=09selectDumpableExtension(&(extinfo[i]),=20=
dopt);=0A=20=09}=0A=20=0A+cleanup:=0A=20=09PQclear(res);=0A=20=09=
destroyPQExpBuffer(query);=0A=20=0A--=20=0A2.39.3=20(Apple=20Git-146)=0A=0A=

--Apple-Mail=_0024AF68-445F-4B80-865E-B9F3DBD923A2--